[jira] [Commented] (YUNIKORN-1421) Update the "Build and Run" page of the docs

["Wilfred Spiegelenburg (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YUNIKORN-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17638071#comment-17638071 ] 

Wilfred Spiegelenburg commented on YUNIKORN-1421:
-------------------------------------------------

We should also update the Makefiles to use the .go_version file:
{code:java}
MOD_VERSION := $(shell awk '/^go/ {print $$2}' go.mod) {code}
should be:
{code:java}
MOD_VERSION := $(shell cat .go_version) {code}
that will cause the {{make}} to fail as expected if go is too old. All repos would need an update.

> Update the "Build and Run" page of the docs
> -------------------------------------------
>
>                 Key: YUNIKORN-1421
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-1421
>             Project: Apache YuniKorn
>          Issue Type: Improvement
>          Components: documentation
>            Reporter: Wu hsuang zong
>            Assignee: Wu hsuang zong
>            Priority: Minor
>              Labels: pull-request-available
>
> After the YUNIKORN-1411 updated the k8shim dependencies, the go version turn from 1.16 to 1.18. Therefore {color:#ff8b00}_make run_{color} is not working on go1.16 anymore. But the document on Build and Run page is still ask for go1.16+.
> As a result, the {color:#ff8b00}"build and run"{color} page should pointing to the {color:#ff8b00}.go_version{color} file as a guideline
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org