You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Leif Hedstrom (JIRA)" <ji...@apache.org> on 2016/02/04 19:55:45 UTC

[jira] [Closed] (TS-3769) CID 1311647: Null pointer dereferences in HttpTransact.cc

     [ https://issues.apache.org/jira/browse/TS-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leif Hedstrom closed TS-3769.
-----------------------------

> CID 1311647:  Null pointer dereferences in HttpTransact.cc
> ----------------------------------------------------------
>
>                 Key: TS-3769
>                 URL: https://issues.apache.org/jira/browse/TS-3769
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: HTTP
>            Reporter: Leif Hedstrom
>            Assignee: Alan M. Carroll
>            Priority: Critical
>              Labels: Coverity
>             Fix For: 6.0.0
>
>
> {code}
> Hi,
> Please find the latest report on new defect(s) introduced to Apache Traffic Server found with Coverity Scan.
> 1 new defect(s) introduced to Apache Traffic Server found with Coverity Scan.
> New defect(s) Reported-by: Coverity Scan
> Showing 1 of 1 defect(s)
> ** CID 1311647:  Null pointer dereferences  (REVERSE_INULL)
> /proxy/http/HttpTransact.cc: 1596 in HttpTransact::ReDNSRoundRobin(HttpTransact::State *)()
> ________________________________________________________________________________________________________
> *** CID 1311647:  Null pointer dereferences  (REVERSE_INULL)
> /proxy/http/HttpTransact.cc: 1596 in HttpTransact::ReDNSRoundRobin(HttpTransact::State *)()
> 1590         //  failure mark
> 1591         s->current.server->clear_connect_fail();
> 1592     
> 1593         // Our ReDNS of the server succeeded so update the necessary
> 1594         //  information and try again. Need to preserve the current port value if possible.
> 1595         in_port_t server_port =
>    CID 1311647:  Null pointer dereferences  (REVERSE_INULL)
>    Null-checking "s->current.server" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
> 1596           s->current.server ? s->current.server->dst_addr.host_order_port() : s->server_info.dst_addr.isValid() ?
> 1597                                    s->server_info.dst_addr.host_order_port() :
> 1598                                    s->hdr_info.client_request.port_get();
> 1599     
> 1600         ats_ip_copy(&s->server_info.dst_addr, s->host_db_info.ip());
> 1601         s->server_info.dst_addr.port() = htons(server_port);
> ________________________________________________________________________________________________________
> To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/431?tab=overview
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)