You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by QiangCai <gi...@git.apache.org> on 2018/02/11 09:17:50 UTC
[GitHub] carbondata pull request #1969: [CARBONDATA-2151][Streaming] Fix filter query...
GitHub user QiangCai opened a pull request:
https://github.com/apache/carbondata/pull/1969
[CARBONDATA-2151][Streaming] Fix filter query issue on streaming table
1. Fix filter query issue for timestamp, date, decimal
2. Add more test case
dataType: int, streaming, float, double, decimal, timestamp, date, complex
operation: =, <>, >=, >, <, <=, in, like, between, is null, is not null
- [x] Any interfaces changed?
no
- [x] Any backward compatibility impacted?
no
- [x] Document update required?
no
- [x] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
enhanced test case
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
small changes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/QiangCai/carbondata streaming_timestamp
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1969.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1969
----
commit a318c6773f3fc45a63f34e4dd3c35f893f22c0b9
Author: QiangCai <qi...@...>
Date: 2018-02-11T08:06:01Z
fix filter query issue on streaming table
----
---
[GitHub] carbondata issue #1969: [CARBONDATA-2151][Streaming] Fix filter query issue ...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1969
LGTM
---
[GitHub] carbondata pull request #1969: [CARBONDATA-2151][Streaming] Fix filter query...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1969#discussion_r170180010
--- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RangeValueFilterExecuterImpl.java ---
@@ -145,6 +146,34 @@ public BitSetGroup applyFilter(BlocksChunkHolder blockChunkHolder, boolean useBi
return applyNoAndDirectFilter(blockChunkHolder);
}
+ /**
+ * apply range filter on a row
--- End diff --
explain the return value
---
[GitHub] carbondata issue #1969: [CARBONDATA-2151][Streaming] Fix filter query issue ...
Posted by QiangCai <gi...@git.apache.org>.
Github user QiangCai commented on the issue:
https://github.com/apache/carbondata/pull/1969
retest this please
---
[GitHub] carbondata issue #1969: [CARBONDATA-2151][Streaming] Fix filter query issue ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1969
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3617/
---
[GitHub] carbondata pull request #1969: [CARBONDATA-2151][Streaming] Fix filter query...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1969#discussion_r170179962
--- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/FilterUtil.java ---
@@ -1790,6 +1790,9 @@ public static void removeNullValues(DimensionColumnDataChunk dimensionColumnData
}
public static void updateIndexOfColumnExpression(Expression exp, int dimOridnalMax) {
+ if (exp == null) {
+ return;
--- End diff --
add one comment to explain it can be null
---
[GitHub] carbondata issue #1969: [CARBONDATA-2151][Streaming] Fix filter query issue ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1969
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3829/
---
[GitHub] carbondata issue #1969: [CARBONDATA-2151][Streaming] Fix filter query issue ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1969
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3519/
---
[GitHub] carbondata issue #1969: [CARBONDATA-2151][Streaming] Fix filter query issue ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1969
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3836/
---
[GitHub] carbondata issue #1969: [CARBONDATA-2151][Streaming] Fix filter query issue ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1969
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3840/
---
[GitHub] carbondata issue #1969: [CARBONDATA-2151][Streaming] Fix filter query issue ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1969
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3717/
---
[GitHub] carbondata issue #1969: [CARBONDATA-2151][Streaming] Fix filter query issue ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1969
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2591/
---
[GitHub] carbondata pull request #1969: [CARBONDATA-2151][Streaming] Fix filter query...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1969
---
[GitHub] carbondata issue #1969: [CARBONDATA-2151][Streaming] Fix filter query issue ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1969
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2585/
---
[GitHub] carbondata issue #1969: [CARBONDATA-2151][Streaming] Fix filter query issue ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1969
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3696/
---
[GitHub] carbondata issue #1969: [CARBONDATA-2151][Streaming] Fix filter query issue ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1969
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2477/
---
[GitHub] carbondata issue #1969: [CARBONDATA-2151][Streaming] Fix filter query issue ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1969
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2595/
---
[GitHub] carbondata issue #1969: [CARBONDATA-2151][Streaming] Fix filter query issue ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1969
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2456/
---
[GitHub] carbondata issue #1969: [CARBONDATA-2151][Streaming] Fix filter query issue ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1969
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3624/
---