You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "beiwei30 (GitHub)" <gi...@apache.org> on 2018/11/08 03:05:44 UTC
[GitHub] [incubator-dubbo] beiwei30 opened issue #2757:
ReferenceBean's getObject() called in toString()
Intellij Idea's debugger renders object to string in object view (Preferences -> Build, Execution, Deployment -> Debugger -> Data Views -> Java -> Enable 'toString()' object view). This behavior is enabled by default and it leads some strange problem when debug in Dubbo, for examples: #2431, or user may observe a ReferenceConfig may init twice or ReferenceConfig#urls may have two same entries if the breakpoint happens to set in the relevant places. You may interested in looking into the details from http://t.cn/EAhta27, where @code4wt gives the excellent analysis.
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2757 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] code4wt commented on issue #2757:
ReferenceBean's getObject() called in toString()
Posted by "code4wt (GitHub)" <gi...@apache.org>.
> I like the proposed pull request from @code4wt
Thanks.
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2757 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh commented on issue #2757:
ReferenceBean's getObject() called in toString()
Posted by "carryxyh (GitHub)" <gi...@apache.org>.
@beiwei30
How do u think about that toString method print getObject's result.
IMO, toString method should not print this info because this is meaningless.
So I support @code4wt revision.
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2757 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] beiwei30 commented on issue #2757:
ReferenceBean's getObject() called in toString()
Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
@carryxyh I like the proposed pull request from @code4wt
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2757 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh closed issue #2757:
ReferenceBean's getObject() called in toString()
Posted by "carryxyh (GitHub)" <gi...@apache.org>.
[ issue closed by carryxyh ]
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2757 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] code4wt commented on issue #2757:
ReferenceBean's getObject() called in toString()
Posted by "code4wt (GitHub)" <gi...@apache.org>.
ReferenceBean does not have an attribute named "object", So toString should
> I like the proposed pull request from @code4wt
Thanks.
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2757 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh commented on issue #2757:
ReferenceBean's getObject() called in toString()
Posted by "carryxyh (GitHub)" <gi...@apache.org>.
Nice pr and analysis.
Thx
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2757 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org