You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/10/16 02:53:03 UTC

[GitHub] [incubator-dolphinscheduler] codecov-io commented on pull request #3402: [Improvement][common] unit test for TheadUtilsTest

codecov-io commented on pull request #3402:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3402#issuecomment-709699164


   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3402?src=pr&el=h1) Report
   > Merging [#3402](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3402?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/6ecc95a338fbb73558c983964d2611f3df2e6dc7?el=desc) will **increase** coverage by `3.44%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3402/graphs/tree.svg?width=650&height=150&src=pr&token=bv9iXXRLi9)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3402?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##                dev    #3402      +/-   ##
   ============================================
   + Coverage     36.60%   40.04%   +3.44%     
   - Complexity     2637     2936     +299     
   ============================================
     Files           448      460      +12     
     Lines         20846    21818     +972     
     Branches       2554     2650      +96     
   ============================================
   + Hits           7631     8738    +1107     
   + Misses        12511    12254     -257     
   - Partials        704      826     +122     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3402?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...g/apache/dolphinscheduler/api/dto/ProcessMeta.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3402/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2R0by9Qcm9jZXNzTWV0YS5qYXZh) | `40.81% <0.00%> (-51.03%)` | `14.00% <0.00%> (-17.00%)` | |
   | [...inscheduler/common/thread/ThreadPoolExecutors.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3402/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3RocmVhZC9UaHJlYWRQb29sRXhlY3V0b3JzLmphdmE=) | `33.65% <0.00%> (-46.16%)` | `6.00% <0.00%> (-2.00%)` | |
   | [.../master/dispatch/host/assign/AbstractSelector.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3402/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9kaXNwYXRjaC9ob3N0L2Fzc2lnbi9BYnN0cmFjdFNlbGVjdG9yLmphdmE=) | `66.66% <0.00%> (-33.34%)` | `3.00% <0.00%> (-1.00%)` | |
   | [...he/dolphinscheduler/common/thread/ThreadUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3402/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3RocmVhZC9UaHJlYWRVdGlscy5qYXZh) | `40.00% <0.00%> (-32.31%)` | `8.00% <0.00%> (-6.00%)` | |
   | [...rg/apache/dolphinscheduler/dao/entity/Project.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3402/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9Qcm9qZWN0LmphdmE=) | `35.52% <0.00%> (-27.27%)` | `18.00% <0.00%> (ø%)` | |
   | [...er/master/processor/queue/TaskResponseService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3402/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9wcm9jZXNzb3IvcXVldWUvVGFza1Jlc3BvbnNlU2VydmljZS5qYXZh) | `32.69% <0.00%> (-23.31%)` | `5.00% <0.00%> (-1.00%)` | |
   | [...er/master/dispatch/host/assign/RandomSelector.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3402/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9kaXNwYXRjaC9ob3N0L2Fzc2lnbi9SYW5kb21TZWxlY3Rvci5qYXZh) | `77.77% <0.00%> (-22.23%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
   | [...che/dolphinscheduler/common/utils/StringUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3402/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1N0cmluZ1V0aWxzLmphdmE=) | `66.66% <0.00%> (-19.05%)` | `10.00% <0.00%> (ø%)` | |
   | [...dolphinscheduler/common/utils/EncryptionUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3402/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0VuY3J5cHRpb25VdGlscy5qYXZh) | `33.33% <0.00%> (-16.67%)` | `2.00% <0.00%> (ø%)` | |
   | [...lphinscheduler/common/utils/SensitiveLogUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3402/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL1NlbnNpdGl2ZUxvZ1V0aWxzLmphdmE=) | `60.00% <0.00%> (-15.00%)` | `2.00% <0.00%> (ø%)` | |
   | ... and [149 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3402/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3402?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3402?src=pr&el=footer). Last update [6ecc95a...29a083c](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3402?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org