You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ofbiz.apache.org by GitBox <gi...@apache.org> on 2021/02/12 14:44:52 UTC

[GitHub] [ofbiz-plugins] mbrohl commented on pull request #27: OFBIZ-11756 vue js renderer

mbrohl commented on pull request #27:
URL: https://github.com/apache/ofbiz-plugins/pull/27#issuecomment-778237015


   @Olivier-Heintz This PR seems to be problematic in several aspects:
   - there is too much code duplication, see sonarcloud analysis. Please try to avoid copied inline functions and write them in separate function to reuse them
   - the commits do not follow the commit message template (Fixed:, Improved: etc.)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org