You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/07/08 13:44:53 UTC

[GitHub] [incubator-kvrocks] kezhenxu94 opened a new pull request, #721: Update kvrocks.yaml

kezhenxu94 opened a new pull request, #721:
URL: https://github.com/apache/incubator-kvrocks/pull/721

   We have a dedicate GitHub actions for header check so this should be updated, and we don't recommend using `@main` so there is no unexpected behaviors when we have changes in our codebase.
   
   See https://github.com/apache/skywalking-eyes/pull/123


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] PragmaTwice merged pull request #721: Update kvrocks.yaml

Posted by GitBox <gi...@apache.org>.
PragmaTwice merged PR #721:
URL: https://github.com/apache/incubator-kvrocks/pull/721


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #721: Update kvrocks.yaml

Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on PR #721:
URL: https://github.com/apache/incubator-kvrocks/pull/721#issuecomment-1179107824

   > We haven't had a release 0.4.0 so for now we have to use a commit hash, we will manage to release 0.4.0 soon so you can change to `@v0.4.0`.
   
   Got it. Merging, thanks for you contribution.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] xiaobiaozhao commented on pull request #721: Update kvrocks.yaml

Posted by GitBox <gi...@apache.org>.
xiaobiaozhao commented on PR #721:
URL: https://github.com/apache/incubator-kvrocks/pull/721#issuecomment-1179071147

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] kezhenxu94 commented on pull request #721: Update kvrocks.yaml

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on PR #721:
URL: https://github.com/apache/incubator-kvrocks/pull/721#issuecomment-1179015242

   > LGTM. BTW is there a suitable tag rather than a commit hash?
   
   We haven't had a release 0.4.0 so for now we have to use a commit hash, we will manage to release 0.4.0 soon so you can change to `@v0.4.0`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org