You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@spark.apache.org by "Sean Owen (JIRA)" <ji...@apache.org> on 2016/04/18 12:13:28 UTC

[jira] [Commented] (SPARK-14697) mllib DenseMatrix toArray could use the internal values

    [ https://issues.apache.org/jira/browse/SPARK-14697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15245416#comment-15245416 ] 

Sean Owen commented on SPARK-14697:
-----------------------------------

I think the problem is that you're then accessing the internal representation, and that ends up being generally problematic. At least, I think returning a defensive copy is on purpose.

> mllib DenseMatrix toArray could use the internal values
> -------------------------------------------------------
>
>                 Key: SPARK-14697
>                 URL: https://issues.apache.org/jira/browse/SPARK-14697
>             Project: Spark
>          Issue Type: Bug
>          Components: MLlib
>    Affects Versions: 1.6.1
>            Reporter: Tamas Jambor
>            Priority: Minor
>
> When toArray is called from an mllib Densematrix, it calls the function from the superclass Matrix, where it creates a new array (and iterates through all the values).
> This is not necessary as values are stored in DenseMatrix, in exactly the format that this function would require. Why not just call that?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org