You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "zwoop (via GitHub)" <gi...@apache.org> on 2023/03/03 17:47:46 UTC
[GitHub] [trafficserver] zwoop opened a new pull request, #9491: Adds a new percentage options, cleans up pressure calculations
zwoop opened a new pull request, #9491:
URL: https://github.com/apache/trafficserver/pull/9491
The new option is --iprep_percentage, and allows us to start rate limiting at any percentage of the max allowed. Before, it would rate limit (with the IP reputation) at 90% always.
Also, this fixes a problem where the IP reputation is always on, I think that's not a good idea. You have to explicitly set the bucket sizes at a minimum.
This needs to go into 9.2.x as well, since the old code doesn't work as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #9491: Adds a new percentage option, cleans up pressure calculations
Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop commented on PR #9491:
URL: https://github.com/apache/trafficserver/pull/9491#issuecomment-1458512277
Cherry-picked to v9.2.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #9491: Adds a new percentage option, cleans up pressure calculations
Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop commented on PR #9491:
URL: https://github.com/apache/trafficserver/pull/9491#issuecomment-1457567106
@bneradt I've addressed the docs issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop merged pull request #9491: Adds a new percentage option, cleans up pressure calculations
Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop merged PR #9491:
URL: https://github.com/apache/trafficserver/pull/9491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on a diff in pull request #9491: Adds a new percentage option, cleans up pressure calculations
Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop commented on code in PR #9491:
URL: https://github.com/apache/trafficserver/pull/9491#discussion_r1128159010
##########
doc/admin-guide/plugins/rate_limit.en.rst:
##########
@@ -161,21 +161,28 @@ The following options are available:
.. option:: --iprep_buckets
The number of LRU buckets to use for the IP reputation. A good number here
- is 10, but can be configured. The reason for the different buckets is to
- account for a pseudo-sorted list of IPs on the frequency seen. Too few buckets
- will not be enough to keep such a sorting, rendering the algorithm useless. To
- function in our setup, the number of buckets must be less than ``100``.
+ is ``10``, which is the default, but can be configured. The reason for the different
+ buckets is to account for a pseudo-sorted list of IPs on the frequency seen. Too
+ few buckets will not be enough to keep such sorting, rendering the algorithm useless.
+ To function in our setup, the number of buckets must be less than ``100``.
.. option:: --iprep_bucketsize
- This is the size of the largest LRU bucket (the `entry bucket`), `15` is a good
- value. This is a power of 2, so `15` means the largest LRU can hold `32768` entries.
- Note that this option must be bigger then the `--iprep_buckets` setting, for the
+ This is the size of the largest LRU bucket (the ``entry bucket``), ``15`` is a good
+ value. This is a power of 2, so ``15``` means the largest LRU can hold ``32768`` entries.
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on a diff in pull request #9491: Adds a new percentage option, cleans up pressure calculations
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on code in PR #9491:
URL: https://github.com/apache/trafficserver/pull/9491#discussion_r1127155975
##########
doc/admin-guide/plugins/rate_limit.en.rst:
##########
@@ -161,10 +161,10 @@ The following options are available:
.. option:: --iprep_buckets
The number of LRU buckets to use for the IP reputation. A good number here
- is 10, but can be configured. The reason for the different buckets is to
- account for a pseudo-sorted list of IPs on the frequency seen. Too few buckets
- will not be enough to keep such a sorting, rendering the algorithm useless. To
- function in our setup, the number of buckets must be less than ``100``.
+ is `10`, which is the default, but can be configured. The reason for the different
Review Comment:
Need two ticks around 10. Otherwise this is italicized instead of a code space string.
There's a few examples of this in this patch, but just marking this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on a diff in pull request #9491: Adds a new percentage option, cleans up pressure calculations
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on code in PR #9491:
URL: https://github.com/apache/trafficserver/pull/9491#discussion_r1128146606
##########
doc/admin-guide/plugins/rate_limit.en.rst:
##########
@@ -161,21 +161,28 @@ The following options are available:
.. option:: --iprep_buckets
The number of LRU buckets to use for the IP reputation. A good number here
- is 10, but can be configured. The reason for the different buckets is to
- account for a pseudo-sorted list of IPs on the frequency seen. Too few buckets
- will not be enough to keep such a sorting, rendering the algorithm useless. To
- function in our setup, the number of buckets must be less than ``100``.
+ is ``10``, which is the default, but can be configured. The reason for the different
+ buckets is to account for a pseudo-sorted list of IPs on the frequency seen. Too
+ few buckets will not be enough to keep such sorting, rendering the algorithm useless.
+ To function in our setup, the number of buckets must be less than ``100``.
.. option:: --iprep_bucketsize
- This is the size of the largest LRU bucket (the `entry bucket`), `15` is a good
- value. This is a power of 2, so `15` means the largest LRU can hold `32768` entries.
- Note that this option must be bigger then the `--iprep_buckets` setting, for the
+ This is the size of the largest LRU bucket (the ``entry bucket``), ``15`` is a good
+ value. This is a power of 2, so ``15``` means the largest LRU can hold ``32768`` entries.
Review Comment:
Three ticks after the 15.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org