You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/07/20 23:05:36 UTC

[GitHub] [incubator-mxnet] leezu edited a comment on pull request #18721: Remove Makefile

leezu edited a comment on pull request #18721:
URL: https://github.com/apache/incubator-mxnet/pull/18721#issuecomment-661416199


   The Makefile targets are undocumented and are tied to the CI:
   
   https://github.com/apache/incubator-mxnet/blob/faccd91071cc34ed0b3a192d3c7932441fe7e35e/ci/docker/install/requirements#L35-L36
   
   For now using the `python ci/build.py --platform ubuntu_cpu /work/runtime_functions.sh sanity_check` or manually running `pylint` and `cpplint` should be acceptable. We can have a separate PR that removes the technical debt of the linting system (https://github.com/apache/incubator-mxnet/issues/17968#issuecomment-613681904). For pylint, just moving `ci/other/pylintrc` to the root of the repo should be sufficient. For cpplint, we need to migrate to `clang-format` and cmake will run it automatically.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org