You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/03/18 14:11:29 UTC
[GitHub] [nifi] joewitt commented on issue #3917: Adding GetSmbFile and
PutSmbFile processors
joewitt commented on issue #3917: Adding GetSmbFile and PutSmbFile processors
URL: https://github.com/apache/nifi/pull/3917#issuecomment-600645546
this ideally needs to be rebased against latest. The updates to NOTICE/LiCENSE look really well done. The code itself looks quite thoughtful. Not sure how well tests will work on different platforms but a rebase/update to latest master will help highlight that. In general though this looks like a solid contrib
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services