[GitHub] brodybits commented on issue #578: Plugin target-dir error handling for source-file element

[GitBox <gi...@apache.org>]

brodybits commented on issue #578: Plugin target-dir error handling for source-file element
URL: https://github.com/apache/cordova-android/issues/578#issuecomment-441303211
 
 
   The forms in the description of this issue should be considered corner cases, which rarely happen in the real world. In these cases I can think of the following options:
   * emit a warning and continue with some form of behavior
   * fail with an error message
   * ignore them
   
   If we would just emit a warning what kind of behavior do you think we should have?
   
   If you want to propose more changes to `getInstallDestination` I suggest you open a new PR where we can discuss in more detail, line-by-line where needed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org