[GitHub] [incubator-tvm] t-vi commented on a change in pull request #6374: [Torch] Support logsumexp, clean up unnecessary infer_shape usage

[GitBox <gi...@apache.org>]

t-vi commented on a change in pull request #6374:
URL: https://github.com/apache/incubator-tvm/pull/6374#discussion_r481836239



##########
File path: python/tvm/relay/frontend/pytorch.py
##########
@@ -110,12 +102,20 @@ def inplace_add_to_add(op_name):
     if len(intersect) > 0 and intersect != set(["aten::add"]):
         return True
 
-    if is_used_by_list_add(filter(lambda use: use.user.kind() != "prim::Loop", uses)):
-        return True
+    # if add op outputs list, it is dynamic so we need to construct List ADT
+    for use in filter(lambda use: use.user.kind() in ["aten::add", "aten::add_"], uses):

Review comment:
       I'm a bit weary that this is very brittle. Probably not more than before, though.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org