You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by mallman <gi...@git.apache.org> on 2017/10/02 11:46:41 UTC

[GitHub] spark pull request #16578: [SPARK-4502][SQL] Parquet nested column pruning

Github user mallman commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16578#discussion_r142117188
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetReadSupport.scala ---
    @@ -63,9 +74,22 @@ private[parquet] class ParquetReadSupport extends ReadSupport[UnsafeRow] with Lo
           StructType.fromString(schemaString)
         }
     
    -    val parquetRequestedSchema =
    +    val clippedParquetSchema =
           ParquetReadSupport.clipParquetSchema(context.getFileSchema, catalystRequestedSchema)
     
    +    val parquetRequestedSchema = if (parquetMrCompatibility) {
    +      // Parquet-mr will throw an exception if we try to read a superset of the file's schema.
    +      // Therefore, we intersect our clipped schema with the underlying file's schema
    --- End diff --
    
    As I wrote below, this problem does exist with parquet-mr 1.8.2. Hence, I've reverted back to the version with the `parquetMrCompatibility`-related logic.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org