[GitHub] [beam] steveniemitz edited a comment on pull request #11814: [BEAM-10078] uniquify Dataflow specific jars when staging

[GitBox <gi...@apache.org>]

steveniemitz edited a comment on pull request #11814:
URL: https://github.com/apache/beam/pull/11814#issuecomment-635015560


   I just tested this change out, it seems like things work as they did before in 2.20.  The only difference I noticed is that my `filesToStage` are slightly different.
   
   Previously they looked like:
   ```
   dataflow-worker.jar=<my dataflow jar>,
   <some other jar>
   ```
   
   however now they're just:
   ```
   <my dataflow jar>,
   <some other jar>
   ```
   
   It seems like the job launches correctly and uses the jar I set, so it seems like it's still working correctly, but I'm not sure if that missing might cause other issues down the road.  Also, the names are deterministic again which is great!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org