You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/12/10 20:56:54 UTC
[kudu-CR] [Java] Add a Schema and Data Generator
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12061
Change subject: [Java] Add a Schema and Data Generator
......................................................................
[Java] Add a Schema and Data Generator
This patch adds a schema and data generator utility
class that can be used to create random tables and
random data. These utilities are usefull in fuzz tests
and for various load and scale test applications.
The initial implementation is inteneded to be
fairly flexble without being overengineered.
Follow on patches will improve the API and options.
The classes are currently marked private, but could be
changed in the future.
Change-Id: I750d2d346c3eeb7075b21c3fec0fd25236da4f56
---
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
A java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java
A java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java
4 files changed, 572 insertions(+), 152 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/12061/1
--
To view, visit http://gerrit.cloudera.org:8080/12061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I750d2d346c3eeb7075b21c3fec0fd25236da4f56
Gerrit-Change-Number: 12061
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [Java] Add a Schema and Data Generator
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12061 )
Change subject: [Java] Add a Schema and Data Generator
......................................................................
Patch Set 1:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/12061/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12061/1//COMMIT_MSG@9
PS1, Line 9: This patch adds a schema and data generator utility
: class
> Nit: This patch adds schema and data generate utility classes
Done
http://gerrit.cloudera.org:8080/#/c/12061/1//COMMIT_MSG@11
PS1, Line 11: usefull
> useful
Done
http://gerrit.cloudera.org:8080/#/c/12061/1/java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java
File java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java:
PS1:
> License header.
Done
http://gerrit.cloudera.org:8080/#/c/12061/1/java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java@58
PS1, Line 58: public void randomizeRow(PartialRow row) {
> Seems redundant to have both randomizeRow and randomRow. The TestKuduBackup
Done
http://gerrit.cloudera.org:8080/#/c/12061/1/java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java@97
PS1, Line 97: i++;
> It's easy to miss this; perhaps convert into a for loop on i (capped at col
Done
http://gerrit.cloudera.org:8080/#/c/12061/1/java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java@129
PS1, Line 129: public static class DataGeneratorBuilder {
> Since the only way to create a DataGenerator is through here, maybe doc thi
Done
http://gerrit.cloudera.org:8080/#/c/12061/1/java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java
File java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java:
PS1:
> License header.
Done
--
To view, visit http://gerrit.cloudera.org:8080/12061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I750d2d346c3eeb7075b21c3fec0fd25236da4f56
Gerrit-Change-Number: 12061
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 12 Dec 2018 22:09:10 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Java] Add a Schema and Data Generator
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12061 )
Change subject: [Java] Add a Schema and Data Generator
......................................................................
[Java] Add a Schema and Data Generator
This patch adds schema and data generator utility
classes that can be used to create random tables and
random data. These utilities are useful in fuzz tests
and for various load and scale test applications.
The initial implementation is inteneded to be
fairly flexble without being overengineered.
Follow on patches will improve the API and options.
The classes are currently marked private, but could be
changed in the future.
Change-Id: I750d2d346c3eeb7075b21c3fec0fd25236da4f56
Reviewed-on: http://gerrit.cloudera.org:8080/12061
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
A java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java
A java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java
4 files changed, 622 insertions(+), 152 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I750d2d346c3eeb7075b21c3fec0fd25236da4f56
Gerrit-Change-Number: 12061
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [Java] Add a Schema and Data Generator
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12061 )
Change subject: [Java] Add a Schema and Data Generator
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I750d2d346c3eeb7075b21c3fec0fd25236da4f56
Gerrit-Change-Number: 12061
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 12 Dec 2018 23:43:58 +0000
Gerrit-HasComments: No
[kudu-CR] [Java] Add a Schema and Data Generator
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12061
to look at the new patch set (#2).
Change subject: [Java] Add a Schema and Data Generator
......................................................................
[Java] Add a Schema and Data Generator
This patch adds schema and data generator utility
classes that can be used to create random tables and
random data. These utilities are useful in fuzz tests
and for various load and scale test applications.
The initial implementation is inteneded to be
fairly flexble without being overengineered.
Follow on patches will improve the API and options.
The classes are currently marked private, but could be
changed in the future.
Change-Id: I750d2d346c3eeb7075b21c3fec0fd25236da4f56
---
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
M java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
A java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java
A java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java
4 files changed, 622 insertions(+), 152 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/12061/2
--
To view, visit http://gerrit.cloudera.org:8080/12061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I750d2d346c3eeb7075b21c3fec0fd25236da4f56
Gerrit-Change-Number: 12061
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [Java] Add a Schema and Data Generator
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12061 )
Change subject: [Java] Add a Schema and Data Generator
......................................................................
Patch Set 1:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/12061/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12061/1//COMMIT_MSG@9
PS1, Line 9: This patch adds a schema and data generator utility
: class
Nit: This patch adds schema and data generate utility classes
http://gerrit.cloudera.org:8080/#/c/12061/1//COMMIT_MSG@11
PS1, Line 11: usefull
useful
http://gerrit.cloudera.org:8080/#/c/12061/1/java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java
File java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java:
PS1:
License header.
http://gerrit.cloudera.org:8080/#/c/12061/1/java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java@58
PS1, Line 58: public void randomizeRow(PartialRow row) {
Seems redundant to have both randomizeRow and randomRow. The TestKuduBackup case shows a need for randomizeRow; can we omit randomRow?
If not, could you at least rename one? The two names are quite similar.
http://gerrit.cloudera.org:8080/#/c/12061/1/java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java@97
PS1, Line 97: i++;
It's easy to miss this; perhaps convert into a for loop on i (capped at columns.size())?
http://gerrit.cloudera.org:8080/#/c/12061/1/java/kudu-client/src/main/java/org/apache/kudu/util/DataGenerator.java@129
PS1, Line 129: public static class DataGeneratorBuilder {
Since the only way to create a DataGenerator is through here, maybe doc this a bit?
http://gerrit.cloudera.org:8080/#/c/12061/1/java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java
File java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java:
PS1:
License header.
--
To view, visit http://gerrit.cloudera.org:8080/12061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I750d2d346c3eeb7075b21c3fec0fd25236da4f56
Gerrit-Change-Number: 12061
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 11 Dec 2018 06:54:53 +0000
Gerrit-HasComments: Yes