You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Ryota Egashira <eg...@yahoo-inc.com> on 2014/03/25 17:11:25 UTC
Review Request 19619: OOZIE-1754 add order(sort) option to "oozie job -info"
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19619/
-----------------------------------------------------------
Review request for oozie.
Bugs: OOZIE-1754
https://issues.apache.org/jira/browse/OOZIE-1754
Repository: oozie-git
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1754
Diffs
-----
client/src/main/java/org/apache/oozie/cli/OozieCLI.java a6203c6
client/src/main/java/org/apache/oozie/client/OozieClient.java b0a85fd
core/src/test/java/org/apache/oozie/client/TestOozieCLI.java e90d28a
core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java f174b06
Diff: https://reviews.apache.org/r/19619/diff/
Testing
-------
did local test
Thanks,
Ryota Egashira
Re: Review Request 19619: OOZIE-1754 add order(sort) option to "oozie job
-info"
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19619/#review38512
-----------------------------------------------------------
Please update the WebServices doc with the order option and also the commandline doc.
- Rohini Palaniswamy
On March 25, 2014, 4:11 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19619/
> -----------------------------------------------------------
>
> (Updated March 25, 2014, 4:11 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1754
> https://issues.apache.org/jira/browse/OOZIE-1754
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1754
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/cli/OozieCLI.java a6203c6
> client/src/main/java/org/apache/oozie/client/OozieClient.java b0a85fd
> core/src/test/java/org/apache/oozie/client/TestOozieCLI.java e90d28a
> core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java f174b06
>
> Diff: https://reviews.apache.org/r/19619/diff/
>
>
> Testing
> -------
>
> did local test
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request 19619: OOZIE-1754 add order(sort) option to "oozie job
-info"
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19619/#review38807
-----------------------------------------------------------
Ship it!
Please just fix the minor documentation change and upload a new patch to jira.
docs/src/site/twiki/WebServicesAPI.twiki
<https://reviews.apache.org/r/19619/#comment71133>
Default is offset=0,len=0 for v2/job (i.e does not return any coordinator actions) and offset=0,len=1000 with v1/job and v0/job. So if you need actions to be returned with v2 API, specifying =len= parameter is necessary.
- Rohini Palaniswamy
On March 27, 2014, 6:53 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19619/
> -----------------------------------------------------------
>
> (Updated March 27, 2014, 6:53 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1754
> https://issues.apache.org/jira/browse/OOZIE-1754
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1754
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/cli/OozieCLI.java 6dc4a3b
> client/src/main/java/org/apache/oozie/client/OozieClient.java 6164447
> client/src/main/java/org/apache/oozie/client/rest/RestConstants.java a7fe06e
> core/src/main/java/org/apache/oozie/BaseEngine.java 135a0a3
> core/src/main/java/org/apache/oozie/BundleEngine.java 5bf1538
> core/src/main/java/org/apache/oozie/CoordinatorEngine.java 3f10024
> core/src/main/java/org/apache/oozie/DagEngine.java 300d6eb
> core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 0a030af
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java 21506ab
> core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java ac399e9
> core/src/test/java/org/apache/oozie/TestBundleEngineSimple.java bb69d7f
> core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java 85ef53b
> core/src/test/java/org/apache/oozie/client/TestOozieCLI.java e90d28a
> core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java db591e2
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java da7d16c
> core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java f174b06
> docs/src/site/twiki/DG_CommandLineTool.twiki ee4c7d9
> docs/src/site/twiki/WebServicesAPI.twiki 37c0bc0
>
> Diff: https://reviews.apache.org/r/19619/diff/
>
>
> Testing
> -------
>
> did local test
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request 19619: OOZIE-1754 add order(sort) option to "oozie job
-info"
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19619/#review38849
-----------------------------------------------------------
core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java
<https://reviews.apache.org/r/19619/#comment71171>
Can we just pass null instead of instantiating a empty arraylist and handle null in CoordJobGetActionsSubsetJPAExecutor. Can be done for filterList as well?
- Rohini Palaniswamy
On March 27, 2014, 10:35 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19619/
> -----------------------------------------------------------
>
> (Updated March 27, 2014, 10:35 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1754
> https://issues.apache.org/jira/browse/OOZIE-1754
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1754
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/cli/OozieCLI.java 6dc4a3b
> client/src/main/java/org/apache/oozie/client/OozieClient.java 6164447
> client/src/main/java/org/apache/oozie/client/rest/RestConstants.java a7fe06e
> core/src/main/java/org/apache/oozie/BaseEngine.java 135a0a3
> core/src/main/java/org/apache/oozie/BundleEngine.java 5bf1538
> core/src/main/java/org/apache/oozie/CoordinatorEngine.java 3f10024
> core/src/main/java/org/apache/oozie/DagEngine.java 300d6eb
> core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 0a030af
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java 21506ab
> core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java ac399e9
> core/src/test/java/org/apache/oozie/TestBundleEngineSimple.java bb69d7f
> core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java 85ef53b
> core/src/test/java/org/apache/oozie/client/TestOozieCLI.java e90d28a
> core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java db591e2
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java da7d16c
> core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java f174b06
> docs/src/site/twiki/DG_CommandLineTool.twiki ee4c7d9
> docs/src/site/twiki/WebServicesAPI.twiki 37c0bc0
>
> Diff: https://reviews.apache.org/r/19619/diff/
>
>
> Testing
> -------
>
> did local test
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request 19619: OOZIE-1754 add order(sort) option to "oozie job
-info"
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19619/#review39323
-----------------------------------------------------------
Only looked at filter changes.
client/src/main/java/org/apache/oozie/cli/OozieCLI.java
<https://reviews.apache.org/r/19619/#comment71664>
we should change the example
status=<S1>|status!=<S1> and {status=<S2>|status!=<S2> looks incorrect. User should specify =,= or !=,!=. Combination doesn't make sense.
client/src/main/java/org/apache/oozie/cli/OozieCLI.java
<https://reviews.apache.org/r/19619/#comment71665>
space after ,
core/src/main/java/org/apache/oozie/CoordinatorEngine.java
<https://reviews.apache.org/r/19619/#comment71667>
We can simply this to.
String filter = POSITIVE_FILTER;
if(token.contains("!=")) {
pair = token.split("!=");
filter = NEGATIVE_FILTER;
}
else {
pair = token.split("=");
}
core/src/main/java/org/apache/oozie/CoordinatorEngine.java
<https://reviews.apache.org/r/19619/#comment71668>
We can simply this to
List<String> filterlist = filterMap.get(filter);
if (filterlist == null) {
filterlist = new ArrayList<String();
filterMap.put(filter, filterlist);
}
filterlist.add(statusValue);
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java
<https://reviews.apache.org/r/19619/#comment71669>
We should only support POSITIVE_FILTER or NEGATIVE_FILTER, not both.
in this case sql will look like
select * from .... where .. and a.statusStr IN () and a.statusStr NOT IN ()..
It should be only IN or not IN.
core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java
<https://reviews.apache.org/r/19619/#comment71670>
This should throw error.
docs/src/site/twiki/DG_CommandLineTool.twiki
<https://reviews.apache.org/r/19619/#comment71675>
combination of -ve and +ve filter will always return empty list. We should only support -ve or +ve.
- Purshotam Shah
On April 2, 2014, 1:03 a.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19619/
> -----------------------------------------------------------
>
> (Updated April 2, 2014, 1:03 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1754
> https://issues.apache.org/jira/browse/OOZIE-1754
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1754
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/cli/OozieCLI.java 6dc4a3b
> client/src/main/java/org/apache/oozie/client/OozieClient.java 6164447
> core/src/main/java/org/apache/oozie/CoordinatorEngine.java 3f10024
> core/src/main/java/org/apache/oozie/DagEngine.java 300d6eb
> core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 0a030af
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java 21506ab
> core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java 85ef53b
> core/src/test/java/org/apache/oozie/client/TestOozieCLI.java e90d28a
> core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java db591e2
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java da7d16c
> core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java f174b06
> docs/src/site/twiki/DG_CommandLineTool.twiki ee4c7d9
> docs/src/site/twiki/WebServicesAPI.twiki 37c0bc0
>
> Diff: https://reviews.apache.org/r/19619/diff/
>
>
> Testing
> -------
>
> did local test
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request 19619: OOZIE-1754 add order(sort) option to "oozie job
-info"
Posted by Rohini Palaniswamy <ro...@gmail.com>.
> On April 7, 2014, 6:04 p.m., Rohini Palaniswamy wrote:
> > core/src/main/java/org/apache/oozie/CoordinatorEngine.java, lines 591-592
> > <https://reviews.apache.org/r/19619/diff/6/?file=548223#file548223line591>
> >
> > Why is this check there? You can only have positive only or negative only filters right?
> >
> > Can you remove this in the final patch before check in?
Though it does not make sense and will only be equivalent to status=A, currently no error is thrown if -filter status=A;status!=B is specified. It is very minor problem and ok with it. Can drop this issue.
- Rohini
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19619/#review39705
-----------------------------------------------------------
On April 3, 2014, 9:24 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19619/
> -----------------------------------------------------------
>
> (Updated April 3, 2014, 9:24 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1754
> https://issues.apache.org/jira/browse/OOZIE-1754
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1754
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/cli/OozieCLI.java e1f551d
> client/src/main/java/org/apache/oozie/client/OozieClient.java 46c4288
> core/src/main/java/org/apache/oozie/CoordinatorEngine.java 3f10024
> core/src/main/java/org/apache/oozie/DagEngine.java 300d6eb
> core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 0a030af
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java 21506ab
> core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java 85ef53b
> core/src/test/java/org/apache/oozie/client/TestOozieCLI.java e90d28a
> core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java db591e2
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java da7d16c
> core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java f174b06
> docs/src/site/twiki/DG_CommandLineTool.twiki 351f0f2
> docs/src/site/twiki/WebServicesAPI.twiki 37c0bc0
>
> Diff: https://reviews.apache.org/r/19619/diff/
>
>
> Testing
> -------
>
> did local test
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request 19619: OOZIE-1754 add order(sort) option to "oozie job
-info"
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19619/#review39705
-----------------------------------------------------------
Ship it!
core/src/main/java/org/apache/oozie/CoordinatorEngine.java
<https://reviews.apache.org/r/19619/#comment72310>
Why is this check there? You can only have positive only or negative only filters right?
Can you remove this in the final patch before check in?
- Rohini Palaniswamy
On April 3, 2014, 9:24 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19619/
> -----------------------------------------------------------
>
> (Updated April 3, 2014, 9:24 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1754
> https://issues.apache.org/jira/browse/OOZIE-1754
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1754
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/cli/OozieCLI.java e1f551d
> client/src/main/java/org/apache/oozie/client/OozieClient.java 46c4288
> core/src/main/java/org/apache/oozie/CoordinatorEngine.java 3f10024
> core/src/main/java/org/apache/oozie/DagEngine.java 300d6eb
> core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 0a030af
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java 21506ab
> core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java 85ef53b
> core/src/test/java/org/apache/oozie/client/TestOozieCLI.java e90d28a
> core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java db591e2
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java da7d16c
> core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java f174b06
> docs/src/site/twiki/DG_CommandLineTool.twiki 351f0f2
> docs/src/site/twiki/WebServicesAPI.twiki 37c0bc0
>
> Diff: https://reviews.apache.org/r/19619/diff/
>
>
> Testing
> -------
>
> did local test
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request 19619: OOZIE-1754 add order(sort) option to "oozie job
-info"
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19619/
-----------------------------------------------------------
(Updated April 3, 2014, 9:24 p.m.)
Review request for oozie.
Changes
-------
fixed review comments.
added error check for the case where -filter status=S1;status!=S1, also changed doc
Bugs: OOZIE-1754
https://issues.apache.org/jira/browse/OOZIE-1754
Repository: oozie-git
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1754
Diffs (updated)
-----
client/src/main/java/org/apache/oozie/cli/OozieCLI.java e1f551d
client/src/main/java/org/apache/oozie/client/OozieClient.java 46c4288
core/src/main/java/org/apache/oozie/CoordinatorEngine.java 3f10024
core/src/main/java/org/apache/oozie/DagEngine.java 300d6eb
core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 0a030af
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java 21506ab
core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java 85ef53b
core/src/test/java/org/apache/oozie/client/TestOozieCLI.java e90d28a
core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java db591e2
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java da7d16c
core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java f174b06
docs/src/site/twiki/DG_CommandLineTool.twiki 351f0f2
docs/src/site/twiki/WebServicesAPI.twiki 37c0bc0
Diff: https://reviews.apache.org/r/19619/diff/
Testing
-------
did local test
Thanks,
Ryota Egashira
Re: Review Request 19619: OOZIE-1754 add order(sort) option to "oozie job
-info"
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19619/
-----------------------------------------------------------
(Updated April 2, 2014, 1:03 a.m.)
Review request for oozie.
Changes
-------
removed -exclude, instead support negative symbol '!=' inside filter, such as "-filter status!=SUCCEEDED"
Bugs: OOZIE-1754
https://issues.apache.org/jira/browse/OOZIE-1754
Repository: oozie-git
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1754
Diffs (updated)
-----
client/src/main/java/org/apache/oozie/cli/OozieCLI.java 6dc4a3b
client/src/main/java/org/apache/oozie/client/OozieClient.java 6164447
core/src/main/java/org/apache/oozie/CoordinatorEngine.java 3f10024
core/src/main/java/org/apache/oozie/DagEngine.java 300d6eb
core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 0a030af
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java 21506ab
core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java 85ef53b
core/src/test/java/org/apache/oozie/client/TestOozieCLI.java e90d28a
core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java db591e2
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java da7d16c
core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java f174b06
docs/src/site/twiki/DG_CommandLineTool.twiki ee4c7d9
docs/src/site/twiki/WebServicesAPI.twiki 37c0bc0
Diff: https://reviews.apache.org/r/19619/diff/
Testing
-------
did local test
Thanks,
Ryota Egashira
Re: Review Request 19619: OOZIE-1754 add order(sort) option to "oozie job
-info"
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19619/
-----------------------------------------------------------
(Updated March 27, 2014, 10:35 p.m.)
Review request for oozie.
Changes
-------
doc change + minor test case fix. this is final version (hope)
Bugs: OOZIE-1754
https://issues.apache.org/jira/browse/OOZIE-1754
Repository: oozie-git
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1754
Diffs (updated)
-----
client/src/main/java/org/apache/oozie/cli/OozieCLI.java 6dc4a3b
client/src/main/java/org/apache/oozie/client/OozieClient.java 6164447
client/src/main/java/org/apache/oozie/client/rest/RestConstants.java a7fe06e
core/src/main/java/org/apache/oozie/BaseEngine.java 135a0a3
core/src/main/java/org/apache/oozie/BundleEngine.java 5bf1538
core/src/main/java/org/apache/oozie/CoordinatorEngine.java 3f10024
core/src/main/java/org/apache/oozie/DagEngine.java 300d6eb
core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 0a030af
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java 21506ab
core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java ac399e9
core/src/test/java/org/apache/oozie/TestBundleEngineSimple.java bb69d7f
core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java 85ef53b
core/src/test/java/org/apache/oozie/client/TestOozieCLI.java e90d28a
core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java db591e2
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java da7d16c
core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java f174b06
docs/src/site/twiki/DG_CommandLineTool.twiki ee4c7d9
docs/src/site/twiki/WebServicesAPI.twiki 37c0bc0
Diff: https://reviews.apache.org/r/19619/diff/
Testing
-------
did local test
Thanks,
Ryota Egashira
Re: Review Request 19619: OOZIE-1754 add order(sort) option to "oozie job
-info"
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19619/
-----------------------------------------------------------
(Updated March 27, 2014, 6:53 p.m.)
Review request for oozie.
Changes
-------
added exclude filter to satisfy user needs (-exclude status=SUCCEEDED), exclude added as API and CLI command both.
verified it works in my local envrionment
Bugs: OOZIE-1754
https://issues.apache.org/jira/browse/OOZIE-1754
Repository: oozie-git
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1754
Diffs (updated)
-----
client/src/main/java/org/apache/oozie/cli/OozieCLI.java 6dc4a3b
client/src/main/java/org/apache/oozie/client/OozieClient.java 6164447
client/src/main/java/org/apache/oozie/client/rest/RestConstants.java a7fe06e
core/src/main/java/org/apache/oozie/BaseEngine.java 135a0a3
core/src/main/java/org/apache/oozie/BundleEngine.java 5bf1538
core/src/main/java/org/apache/oozie/CoordinatorEngine.java 3f10024
core/src/main/java/org/apache/oozie/DagEngine.java 300d6eb
core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 0a030af
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java 21506ab
core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java ac399e9
core/src/test/java/org/apache/oozie/TestBundleEngineSimple.java bb69d7f
core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java 85ef53b
core/src/test/java/org/apache/oozie/client/TestOozieCLI.java e90d28a
core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java db591e2
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java da7d16c
core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java f174b06
docs/src/site/twiki/DG_CommandLineTool.twiki ee4c7d9
docs/src/site/twiki/WebServicesAPI.twiki 37c0bc0
Diff: https://reviews.apache.org/r/19619/diff/
Testing
-------
did local test
Thanks,
Ryota Egashira
Re: Review Request 19619: OOZIE-1754 add order(sort) option to "oozie job
-info"
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
> On March 25, 2014, 11:10 p.m., Rohini Palaniswamy wrote:
> > Weren't we also planning to add a --non-succeeded option (or some other nice name which is also easy to type) to filter out SUCCEEDED actions and show everything else which is what the users mainly wanted? Is that part of a separate jira? Doing --filter=status=RUNNING\;status=WAITING\;status=PREP\;STATUS=FAILED\;STATUS=KILLED\;STATUS=SUSPENDED is really not appealing.
original ask from customers was to sort result by status, and they want to see TIMEDOUT/FAILED/KILLED on top.
I felt reluctant to add very specific option for filter like --non-succeeded, since some like to see FAILED/KILLED only, others like FAILED/KILED/TIMEOUT, or FAILED/KILLED/TIEEOUT/SUSPENDED, and we should not add new option for each combination, hence kept this patch minimum.
but totally agree with that it's cumbersome for customers to add multiple status in filter. for the same reason, exclude filter also might not so appealing, since we still need to append multiple status similarly..
i'm inclined to add -groupby/-sortby option (e.g,. -groupby status) which used for better format on CLI (no change on API/backend side), also sounds standard option.
- Ryota
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19619/#review38551
-----------------------------------------------------------
On March 25, 2014, 10:43 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19619/
> -----------------------------------------------------------
>
> (Updated March 25, 2014, 10:43 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1754
> https://issues.apache.org/jira/browse/OOZIE-1754
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1754
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/cli/OozieCLI.java a6203c6
> client/src/main/java/org/apache/oozie/client/OozieClient.java b0a85fd
> core/src/test/java/org/apache/oozie/client/TestOozieCLI.java e90d28a
> core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java f174b06
> docs/src/site/twiki/DG_CommandLineTool.twiki c13b78a
> docs/src/site/twiki/WebServicesAPI.twiki 4b20075
>
> Diff: https://reviews.apache.org/r/19619/diff/
>
>
> Testing
> -------
>
> did local test
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request 19619: OOZIE-1754 add order(sort) option to "oozie job
-info"
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19619/#review38551
-----------------------------------------------------------
Weren't we also planning to add a --non-succeeded option (or some other nice name which is also easy to type) to filter out SUCCEEDED actions and show everything else which is what the users mainly wanted? Is that part of a separate jira? Doing --filter=status=RUNNING\;status=WAITING\;status=PREP\;STATUS=FAILED\;STATUS=KILLED\;STATUS=SUSPENDED is really not appealing.
docs/src/site/twiki/WebServicesAPI.twiki
<https://reviews.apache.org/r/19619/#comment70804>
Retrieve a subset of actions
docs/src/site/twiki/WebServicesAPI.twiki
<https://reviews.apache.org/r/19619/#comment70806>
Query parameters offset and length can be specified with a workflow job to retrieve specific actions. Default is offset=0,len=1000
docs/src/site/twiki/WebServicesAPI.twiki
<https://reviews.apache.org/r/19619/#comment70805>
Query parameters offset, length and filter can be specified with a coordinator job to retrieve specific actions. Query parameter order with value "desc" can be used to retrieve the latest coordinator actions materialized instead of actions from @1 which is more useful. Default is offset=0,len=0 for v2/job (i.e does not return any coordinator actions) and offset=0,len=1000 with v1/job. Default order is "asc".
Need to mention this behavior change between v1 and v2 as users are facing issues with that.
- Rohini Palaniswamy
On March 25, 2014, 10:43 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19619/
> -----------------------------------------------------------
>
> (Updated March 25, 2014, 10:43 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1754
> https://issues.apache.org/jira/browse/OOZIE-1754
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1754
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/oozie/cli/OozieCLI.java a6203c6
> client/src/main/java/org/apache/oozie/client/OozieClient.java b0a85fd
> core/src/test/java/org/apache/oozie/client/TestOozieCLI.java e90d28a
> core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java f174b06
> docs/src/site/twiki/DG_CommandLineTool.twiki c13b78a
> docs/src/site/twiki/WebServicesAPI.twiki 4b20075
>
> Diff: https://reviews.apache.org/r/19619/diff/
>
>
> Testing
> -------
>
> did local test
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request 19619: OOZIE-1754 add order(sort) option to "oozie job
-info"
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19619/
-----------------------------------------------------------
(Updated March 25, 2014, 10:43 p.m.)
Review request for oozie.
Changes
-------
updated WebService/CommandLine twiki
Bugs: OOZIE-1754
https://issues.apache.org/jira/browse/OOZIE-1754
Repository: oozie-git
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1754
Diffs (updated)
-----
client/src/main/java/org/apache/oozie/cli/OozieCLI.java a6203c6
client/src/main/java/org/apache/oozie/client/OozieClient.java b0a85fd
core/src/test/java/org/apache/oozie/client/TestOozieCLI.java e90d28a
core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java f174b06
docs/src/site/twiki/DG_CommandLineTool.twiki c13b78a
docs/src/site/twiki/WebServicesAPI.twiki 4b20075
Diff: https://reviews.apache.org/r/19619/diff/
Testing
-------
did local test
Thanks,
Ryota Egashira