You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/01/05 10:47:12 UTC
[GitHub] [hive] dengzhhu653 commented on a change in pull request #1822: HIVE-24575: VectorGroupByOperator reusing keys can lead to wrong results
dengzhhu653 commented on a change in pull request #1822:
URL: https://github.com/apache/hive/pull/1822#discussion_r551854615
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/wrapper/VectorHashKeyWrapperGeneral.java
##########
@@ -348,8 +348,8 @@ public void copyKey(KeyWrapper oldWrapper) {
}
} else {
System.arraycopy(byteLengths, 0, clone.byteLengths, 0, byteValues.length);
- Arrays.fill(byteStarts, 0);
- System.arraycopy(byteStarts, 0, clone.byteStarts, 0, byteValues.length);
+ Arrays.fill(clone.byteStarts, 0);
+ // System.arraycopy(byteStarts, 0, clone.byteStarts, 0, byteValues.length);
Review comment:
Fixed and added a test for this. Thanks very much for the review!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org