[GitHub] [spark] holdenk commented on a change in pull request #30116: [SPARK-33202][CORE] Fix BlockManagerDecommissioner to return the correct migration status

[GitBox <gi...@apache.org>]

holdenk commented on a change in pull request #30116:
URL: https://github.com/apache/spark/pull/30116#discussion_r509559908



##########
File path: core/src/test/scala/org/apache/spark/storage/BlockManagerDecommissionUnitSuite.scala
##########
@@ -183,7 +183,7 @@ class BlockManagerDecommissionUnitSuite extends SparkFunSuite with Matchers {
     val bmDecomManager = new BlockManagerDecommissioner(sparkConf, bm)
     bmDecomManager.migratingShuffles += ShuffleBlockInfo(10, 10)
 
-    validateDecommissionTimestampsOnManager(bmDecomManager)
+    validateDecommissionTimestampsOnManager(bmDecomManager, fail = false, assertDone = false)

Review comment:
       We could also increment migratedShuffles and then we would expect it to finish.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org