You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/07 18:02:11 UTC

[GitHub] [beam] lukecwik commented on pull request #17112: [BEAM-14064] fix es io windowing

lukecwik commented on PR #17112:
URL: https://github.com/apache/beam/pull/17112#issuecomment-1092045118

   > Based on the discussion https://lists.apache.org/thread/10db7l9bhnhmo484myps723sfxtjwwmv I think that if we add the `getAllowedTimestampSkew()` call we can safely merge this. There will be some fix needed in FlinkRunner (and a @ValidatesRunner test). I created https://issues.apache.org/jira/browse/BEAM-14196 to track this and will look into that.
   
   It might make sense to fix flink and remove the `DoFnOperator.java` work around for Flink before we merge this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org