You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Anthony Baker <ab...@apache.org> on 2015/12/30 16:12:10 UTC
Review Request 41801: GEODE-627: Add source distribution
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41801/
-----------------------------------------------------------
Review request for geode, Dick Cavender, Jens Deppe, and Dan Smith.
Repository: geode
Description
-------
GEODE-627: Add source distribution
Add another distribution to create source archives, without gradle
wrapper binaries included.
Diffs
-----
gemfire-assembly/build.gradle 373d77a
Diff: https://reviews.apache.org/r/41801/diff/
Testing
-------
Thanks,
Anthony Baker
Re: Review Request 41801: GEODE-627: Add source distribution
Posted by Jens Deppe <jd...@pivotal.io>.
> On Dec. 30, 2015, 4:22 p.m., Jens Deppe wrote:
> > gemfire-assembly/build.gradle, line 195
> > <https://reviews.apache.org/r/41801/diff/1/?file=1178509#file1178509line195>
> >
> > For IntelliJ projects you should also add *.ipr and *.iws
That should be `*.ipr` and `*.iws`
- Jens
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41801/#review112318
-----------------------------------------------------------
On Dec. 30, 2015, 3:12 p.m., Anthony Baker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41801/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2015, 3:12 p.m.)
>
>
> Review request for geode, Dick Cavender, Jens Deppe, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-627: Add source distribution
>
> Add another distribution to create source archives, without gradle
> wrapper binaries included.
>
>
> Diffs
> -----
>
> gemfire-assembly/build.gradle 373d77a
>
> Diff: https://reviews.apache.org/r/41801/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Baker
>
>
Re: Review Request 41801: GEODE-627: Add source distribution
Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41801/#review112318
-----------------------------------------------------------
gemfire-assembly/build.gradle (line 195)
<https://reviews.apache.org/r/41801/#comment172752>
For IntelliJ projects you should also add *.ipr and *.iws
- Jens Deppe
On Dec. 30, 2015, 3:12 p.m., Anthony Baker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41801/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2015, 3:12 p.m.)
>
>
> Review request for geode, Dick Cavender, Jens Deppe, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-627: Add source distribution
>
> Add another distribution to create source archives, without gradle
> wrapper binaries included.
>
>
> Diffs
> -----
>
> gemfire-assembly/build.gradle 373d77a
>
> Diff: https://reviews.apache.org/r/41801/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Baker
>
>
Re: Review Request 41801: GEODE-627: Add source distribution
Posted by Anthony Baker <ab...@apache.org>.
> On Dec. 30, 2015, 9:51 p.m., Dick Cavender wrote:
> > The NOTICE file that ships with the sources is going to be different than the one that ships with the binary so there still may be work to do on this where one is excluded while the other isn't in this distribution.
Yep. The NOTICE file for the binary should be placed at gemfire-assembly/src/main/dist. The version for the src distribution can remain at the project root or be moved to gemfire-assembly/src/src/dist.
- Anthony
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41801/#review112349
-----------------------------------------------------------
On Dec. 30, 2015, 3:12 p.m., Anthony Baker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41801/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2015, 3:12 p.m.)
>
>
> Review request for geode, Dick Cavender, Jens Deppe, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-627: Add source distribution
>
> Add another distribution to create source archives, without gradle
> wrapper binaries included.
>
>
> Diffs
> -----
>
> gemfire-assembly/build.gradle 373d77a
>
> Diff: https://reviews.apache.org/r/41801/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Baker
>
>
Re: Review Request 41801: GEODE-627: Add source distribution
Posted by Dick Cavender <dc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41801/#review112349
-----------------------------------------------------------
Ship it!
The NOTICE file that ships with the sources is going to be different than the one that ships with the binary so there still may be work to do on this where one is excluded while the other isn't in this distribution.
- Dick Cavender
On Dec. 30, 2015, 3:12 p.m., Anthony Baker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41801/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2015, 3:12 p.m.)
>
>
> Review request for geode, Dick Cavender, Jens Deppe, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-627: Add source distribution
>
> Add another distribution to create source archives, without gradle
> wrapper binaries included.
>
>
> Diffs
> -----
>
> gemfire-assembly/build.gradle 373d77a
>
> Diff: https://reviews.apache.org/r/41801/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Baker
>
>
Re: Review Request 41801: GEODE-627: Add source distribution
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41801/#review112332
-----------------------------------------------------------
Ship it!
- Dan Smith
On Dec. 30, 2015, 3:12 p.m., Anthony Baker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41801/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2015, 3:12 p.m.)
>
>
> Review request for geode, Dick Cavender, Jens Deppe, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-627: Add source distribution
>
> Add another distribution to create source archives, without gradle
> wrapper binaries included.
>
>
> Diffs
> -----
>
> gemfire-assembly/build.gradle 373d77a
>
> Diff: https://reviews.apache.org/r/41801/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Baker
>
>