You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2021/09/27 15:34:08 UTC
[GitHub] [incubator-eventmesh] JunjieChou opened a new pull request #545: [ISSUE #536] fix OpenSchemaRegistryApplication start error
JunjieChou opened a new pull request #545:
URL: https://github.com/apache/incubator-eventmesh/pull/545
Fixes ISSUE #536 .
### Motivation
*Explain the content here.*
1. fix OpenSchemaRegistryApplication start error
2. change h2-db path in ```application.yml```
*Explain why you want to make the changes and what problem you're trying to solve.*
1. Spring version conflict makes OpenSchemaRegistryApplication start error. The way to solve it is by updating all spring-related dependencies to the latest.
2. Change h2-db path so that ```.db``` is created under ```eventmesh-schema-registry-server/resources```.
### Modifications
1. update dependencies version
2. change h2-db path
### Documentation
- Does this pull request introduce a new feature? no, it solves a bug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov-commenter edited a comment on pull request #545: [ISSUE #536] [ISSUE #339] fix start error & add skeleton of openschema plugin
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #545:
URL: https://github.com/apache/incubator-eventmesh/pull/545#issuecomment-928057373
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/545?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#545](https://codecov.io/gh/apache/incubator-eventmesh/pull/545?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8ef0ded) into [develop](https://codecov.io/gh/apache/incubator-eventmesh/commit/546765e5a9fd7bce1de99d6b50705220dc32293d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (546765e) will **increase** coverage by `0.02%`.
> The diff coverage is `44.44%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-eventmesh/pull/545/graphs/tree.svg?width=650&height=150&src=pr&token=IfkrgV55GT&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-eventmesh/pull/545?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #545 +/- ##
=============================================
+ Coverage 10.99% 11.02% +0.02%
+ Complexity 376 372 -4
=============================================
Files 257 258 +1
Lines 12191 12227 +36
Branches 1036 1040 +4
=============================================
+ Hits 1341 1348 +7
- Misses 10735 10764 +29
Partials 115 115
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/545?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/eventmesh/runtime/boot/EventMeshServer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/545/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2Jvb3QvRXZlbnRNZXNoU2VydmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...rg/apache/eventmesh/runtime/schema/OpenSchema.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/545/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL3NjaGVtYS9PcGVuU2NoZW1hLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...e/eventmesh/common/config/CommonConfiguration.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/545/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9jb25maWcvQ29tbW9uQ29uZmlndXJhdGlvbi5qYXZh) | `85.88% <94.11%> (+2.05%)` | :arrow_up: |
| [...tandalone/broker/task/HistoryMessageClearTask.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/545/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL3Rhc2svSGlzdG9yeU1lc3NhZ2VDbGVhclRhc2suamF2YQ==) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [...mesh/connector/standalone/broker/MessageQueue.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/545/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL01lc3NhZ2VRdWV1ZS5qYXZh) | `32.46% <0.00%> (-7.80%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/545?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/545?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [546765e...8ef0ded](https://codecov.io/gh/apache/incubator-eventmesh/pull/545?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] qqeasonchen commented on a change in pull request #545: [ISSUE #536] [ISSUE #339] fix start error & add skeleton of openschema plugin
Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on a change in pull request #545:
URL: https://github.com/apache/incubator-eventmesh/pull/545#discussion_r724756284
##########
File path: eventmesh-admin/README.md
##########
@@ -20,7 +20,7 @@ EventMesh Administration Module for EventMesh. It manages Admin Service, Configu
```json
{
"topic": "mytopic1",
- "created_time": "2021-09-03",
+ "created_time": "2021-09-03"
}
```
### DELETE /clientmanage/topics/(string: topic)/
Review comment:
@JunjieChou schemaregistry does not need to include in admin module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] qqeasonchen commented on pull request #545: [ISSUE #536] [ISSUE #339] fix start error & add skeleton of openschema plugin
Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on pull request #545:
URL: https://github.com/apache/incubator-eventmesh/pull/545#issuecomment-932899371
> # Open Question
> 1. I think the openschema-related names for properties and module are little lengthy. Do you have any suggestions on naming, so that names can be simple and clear ?
@JunjieChou I think schmeaRegistry-server, schemaRegistry-client is ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov-commenter edited a comment on pull request #545: [ISSUE #536] [ISSUE #339] fix start error & add skeleton of openschema plugin
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #545:
URL: https://github.com/apache/incubator-eventmesh/pull/545#issuecomment-928057373
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/545?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#545](https://codecov.io/gh/apache/incubator-eventmesh/pull/545?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7a90bd8) into [develop](https://codecov.io/gh/apache/incubator-eventmesh/commit/546765e5a9fd7bce1de99d6b50705220dc32293d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (546765e) will **increase** coverage by `0.09%`.
> The diff coverage is `44.44%`.
> :exclamation: Current head 7a90bd8 differs from pull request most recent head 89b3307. Consider uploading reports for the commit 89b3307 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-eventmesh/pull/545/graphs/tree.svg?width=650&height=150&src=pr&token=IfkrgV55GT&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-eventmesh/pull/545?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #545 +/- ##
=============================================
+ Coverage 10.99% 11.09% +0.09%
Complexity 376 376
=============================================
Files 257 258 +1
Lines 12191 12227 +36
Branches 1036 1040 +4
=============================================
+ Hits 1341 1357 +16
- Misses 10735 10754 +19
- Partials 115 116 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/545?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/eventmesh/runtime/boot/EventMeshServer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/545/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2Jvb3QvRXZlbnRNZXNoU2VydmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...rg/apache/eventmesh/runtime/schema/OpenSchema.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/545/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL3NjaGVtYS9PcGVuU2NoZW1hLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...e/eventmesh/common/config/CommonConfiguration.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/545/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9jb25maWcvQ29tbW9uQ29uZmlndXJhdGlvbi5qYXZh) | `85.88% <94.11%> (+2.05%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/545?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/545?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [546765e...89b3307](https://codecov.io/gh/apache/incubator-eventmesh/pull/545?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] qqeasonchen commented on a change in pull request #545: [ISSUE #536] [ISSUE #339] fix start error & add skeleton of openschema plugin
Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on a change in pull request #545:
URL: https://github.com/apache/incubator-eventmesh/pull/545#discussion_r724757911
##########
File path: eventmesh-common/src/main/java/org/apache/eventmesh/common/config/CommonConfiguration.java
##########
@@ -32,13 +32,17 @@
public String eventMeshSecurityPluginType = "security";
public int eventMeshPrometheusPort = 19090;
public String eventMeshRegistryPluginType = "namesrv";
+ public String eventMeshServerOpenSchemaPluginType = "openschema";
Review comment:
@JunjieChou it better add to schemaregistry-common.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] JunjieChou commented on pull request #545: [ISSUE #536] [ISSUE #339] fix start error & add skeleton of openschema plugin
Posted by GitBox <gi...@apache.org>.
JunjieChou commented on pull request #545:
URL: https://github.com/apache/incubator-eventmesh/pull/545#issuecomment-945928340
Since there are heavy modifications, I will close this pr and create another two prs. One for fix #536 , another for schema registry client sdk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] JunjieChou commented on a change in pull request #545: [ISSUE #536] [ISSUE #339] fix start error & add skeleton of openschema plugin
Posted by GitBox <gi...@apache.org>.
JunjieChou commented on a change in pull request #545:
URL: https://github.com/apache/incubator-eventmesh/pull/545#discussion_r731089463
##########
File path: eventmesh-schema-registry/eventmesh-schema-registry-plugin/eventmesh-schema-registry-common/src/main/java/org/apache/eventmesh/schema/registry/domain/SchemaWithSubjectName.java
##########
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.eventmesh.schema.registry.domain;
+
+import lombok.*;
+
+@Setter
+@Getter
+@AllArgsConstructor
+@NoArgsConstructor
+@Builder
+public class SchemaWithSubjectName {
+ private long id;
+
+ private String name;
+
+ private String comment;
+
+ private String serialization;
+
+ private String schemaType;
+
+ private String schemaDefinition;
+
+ private String validator;
+
+ private int version;
+
+ private String subject;
Review comment:
Compatibility is an attribute of subject. Check [design doc](https://github.com/apache/incubator-eventmesh/blob/develop/docs/en/features/eventmesh-schemaregistry-design.md) and [schema registry server side](https://github.com/apache/incubator-eventmesh/tree/develop/eventmesh-schema-registry/eventmesh-schema-registry-server) for design of classes.
Also, welcome for code improvements if you have a better way for organizing it.
Btw, the community has a new plan for schema registry, so I will close this pr, and further come back with a schema registry client side SDK. Would like to hear your idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] JunjieChou commented on a change in pull request #545: [ISSUE #536] fix OpenSchemaRegistryApplication start error
Posted by GitBox <gi...@apache.org>.
JunjieChou commented on a change in pull request #545:
URL: https://github.com/apache/incubator-eventmesh/pull/545#discussion_r716863635
##########
File path: tool/license/allowed-licenses.txt
##########
@@ -889,6 +889,96 @@
"moduleLicense": "The Apache Software License, Version 2.0",
"moduleVersion": "2.2.0",
"moduleName": "io.cloudevents:cloudevents-core"
+ },
+ {
+ "moduleLicense": "Apache License, Version 2.0",
+ "moduleVersion": "2.12.4",
+ "moduleName": "com.fasterxml.jackson.datatype:jackson-datatype-jdk8"
+ },
+ {
+ "moduleLicense": "The Apache Software License, Version 2.0",
+ "moduleVersion": "2.12.4",
+ "moduleName": "com.fasterxml.jackson.datatype:jackson-datatype-jdk8"
+ },
+ {
+ "moduleLicense": "Apache License, Version 2.0",
+ "moduleVersion": "2.12.4",
+ "moduleName": "com.fasterxml.jackson.datatype:jackson-datatype-jsr310"
+ },
+ {
+ "moduleLicense": "The Apache Software License, Version 2.0",
+ "moduleVersion": "2.12.4",
+ "moduleName": "com.fasterxml.jackson.datatype:jackson-datatype-jsr310"
+ },
+ {
+ "moduleLicense": "Apache License, Version 2.0",
+ "moduleVersion": "2.12.4",
+ "moduleName": "com.fasterxml.jackson.module:jackson-module-parameter-names"
+ },
+ {
+ "moduleLicense": "The Apache Software License, Version 2.0",
+ "moduleVersion": "2.12.4",
+ "moduleName": "com.fasterxml.jackson.module:jackson-module-parameter-names"
+ },
+ {
+ "moduleLicense": "Apache License, Version 2.0",
+ "moduleVersion": "9.0.52",
+ "moduleName": "org.apache.tomcat.embed:tomcat-embed-core"
+ },
+ {
+ "moduleLicense": "Apache License, Version 2.0",
+ "moduleVersion": "9.0.52",
+ "moduleName": "org.apache.tomcat.embed:tomcat-embed-el"
+ },
+ {
+ "moduleLicense": "Apache License, Version 2.0",
+ "moduleVersion": "9.0.52",
+ "moduleName": "org.apache.tomcat.embed:tomcat-embed-websocket"
+ },
+ {
+ "moduleLicense": "Apache License, Version 2.0",
+ "moduleVersion": "2.5.4",
+ "moduleName": "org.springframework.boot:spring-boot-starter-json"
+ },
+ {
+ "moduleLicense": "Apache License, Version 2.0",
+ "moduleVersion": "2.5.4",
+ "moduleName": "org.springframework.boot:spring-boot-starter-tomcat"
+ },
+ {
+ "moduleLicense": "Apache License, Version 2.0",
+ "moduleVersion": "2.5.4",
+ "moduleName": "org.springframework.boot:spring-boot-starter-web"
+ },
+ {
+ "moduleLicense": "Apache License, Version 2.0",
+ "moduleVersion": "5.3.10",
+ "moduleName": "org.springframework:spring-beans"
+ },
+ {
+ "moduleLicense": "Apache License, Version 2.0",
+ "moduleVersion": "5.3.10",
+ "moduleName": "org.springframework:spring-core"
+ },
+ {
+ "moduleLicense": "Apache License, Version 2.0",
+ "moduleVersion": "5.3.10",
+ "moduleName": "org.springframework:spring-jcl"
+ },
+ {
+ "moduleLicense": "Apache License, Version 2.0",
+ "moduleVersion": "5.3.9",
+ "moduleName": "org.springframework:spring-web"
+ },
+ {
+ "moduleLicense": "Apache License, Version 2.0",
+ "moduleVersion": "5.3.9",
+ "moduleName": "org.springframework:spring-webmvc"
+ },
+ {
+ "moduleLicense": null,
Review comment:
Here seems an invalid license.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov-commenter edited a comment on pull request #545: [ISSUE #536] [ISSUE #339] fix start error & add skeleton of openschema plugin
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #545:
URL: https://github.com/apache/incubator-eventmesh/pull/545#issuecomment-928057373
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/545?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#545](https://codecov.io/gh/apache/incubator-eventmesh/pull/545?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8ef0ded) into [develop](https://codecov.io/gh/apache/incubator-eventmesh/commit/546765e5a9fd7bce1de99d6b50705220dc32293d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (546765e) will **increase** coverage by `0.02%`.
> The diff coverage is `44.44%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-eventmesh/pull/545/graphs/tree.svg?width=650&height=150&src=pr&token=IfkrgV55GT&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-eventmesh/pull/545?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #545 +/- ##
=============================================
+ Coverage 10.99% 11.02% +0.02%
+ Complexity 376 372 -4
=============================================
Files 257 258 +1
Lines 12191 12227 +36
Branches 1036 1040 +4
=============================================
+ Hits 1341 1348 +7
- Misses 10735 10764 +29
Partials 115 115
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/545?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/eventmesh/runtime/boot/EventMeshServer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/545/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2Jvb3QvRXZlbnRNZXNoU2VydmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...rg/apache/eventmesh/runtime/schema/OpenSchema.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/545/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL3NjaGVtYS9PcGVuU2NoZW1hLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...e/eventmesh/common/config/CommonConfiguration.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/545/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9jb25maWcvQ29tbW9uQ29uZmlndXJhdGlvbi5qYXZh) | `85.88% <94.11%> (+2.05%)` | :arrow_up: |
| [...tandalone/broker/task/HistoryMessageClearTask.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/545/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL3Rhc2svSGlzdG9yeU1lc3NhZ2VDbGVhclRhc2suamF2YQ==) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [...mesh/connector/standalone/broker/MessageQueue.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/545/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL01lc3NhZ2VRdWV1ZS5qYXZh) | `32.46% <0.00%> (-7.80%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/545?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/545?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [546765e...8ef0ded](https://codecov.io/gh/apache/incubator-eventmesh/pull/545?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] qqeasonchen commented on a change in pull request #545: [ISSUE #536] [ISSUE #339] fix start error & add skeleton of openschema plugin
Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on a change in pull request #545:
URL: https://github.com/apache/incubator-eventmesh/pull/545#discussion_r724759020
##########
File path: eventmesh-runtime/conf/eventmesh.properties
##########
@@ -72,4 +72,10 @@ eventMesh.registry.plugin.type=namesrv
eventMesh.server.registry.enabled=false
#prometheusPort
-eventMesh.metrics.prometheus.port=19090
\ No newline at end of file
+eventMesh.metrics.prometheus.port=19090
+
+#openschema plugin
+eventMesh.server.openschema.enabled=false
Review comment:
@JunjieChou eventmesh.server.schema is fine, no need to use openschema
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] JunjieChou closed pull request #545: [ISSUE #536] [ISSUE #339] fix start error & add skeleton of openschema plugin
Posted by GitBox <gi...@apache.org>.
JunjieChou closed pull request #545:
URL: https://github.com/apache/incubator-eventmesh/pull/545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] qqeasonchen commented on a change in pull request #545: [ISSUE #536] [ISSUE #339] fix start error & add skeleton of openschema plugin
Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on a change in pull request #545:
URL: https://github.com/apache/incubator-eventmesh/pull/545#discussion_r724758226
##########
File path: eventmesh-common/src/main/java/org/apache/eventmesh/common/config/CommonConfiguration.java
##########
@@ -32,13 +32,17 @@
public String eventMeshSecurityPluginType = "security";
public int eventMeshPrometheusPort = 19090;
public String eventMeshRegistryPluginType = "namesrv";
+ public String eventMeshServerOpenSchemaPluginType = "openschema";
Review comment:
@JunjieChou it better add to schemaregistry-common.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] ruanwenjun commented on pull request #545: [ISSUE #536] [ISSUE #339] fix start error & add skeleton of openschema plugin
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on pull request #545:
URL: https://github.com/apache/incubator-eventmesh/pull/545#issuecomment-935428135
@JunjieChou Hi, Junjie, you can add `close #536 ` in your description, this can auto close the issue after the PR been merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov-commenter commented on pull request #545: [ISSUE #536] fix OpenSchemaRegistryApplication start error
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #545:
URL: https://github.com/apache/incubator-eventmesh/pull/545#issuecomment-928057373
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/545?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#545](https://codecov.io/gh/apache/incubator-eventmesh/pull/545?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7220e21) into [develop](https://codecov.io/gh/apache/incubator-eventmesh/commit/546765e5a9fd7bce1de99d6b50705220dc32293d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (546765e) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 7220e21 differs from pull request most recent head db09ec4. Consider uploading reports for the commit db09ec4 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-eventmesh/pull/545/graphs/tree.svg?width=650&height=150&src=pr&token=IfkrgV55GT&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-eventmesh/pull/545?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #545 +/- ##
==========================================
Coverage 10.99% 10.99%
Complexity 376 376
==========================================
Files 257 257
Lines 12191 12191
Branches 1036 1036
==========================================
Hits 1341 1341
Misses 10735 10735
Partials 115 115
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/545?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/545?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [546765e...db09ec4](https://codecov.io/gh/apache/incubator-eventmesh/pull/545?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] JunjieChou commented on pull request #545: [ISSUE #536] [ISSUE #339] fix start error & add skeleton of openschema plugin
Posted by GitBox <gi...@apache.org>.
JunjieChou commented on pull request #545:
URL: https://github.com/apache/incubator-eventmesh/pull/545#issuecomment-935623328
> @JunjieChou Hi, Junjie, you can add `close #536 ` in your description, this can auto close the issue after the PR been merged.
>
sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] JunjieChou commented on pull request #545: [ISSUE #536] [ISSUE #339] fix start error & add skeleton of openschema plugin
Posted by GitBox <gi...@apache.org>.
JunjieChou commented on pull request #545:
URL: https://github.com/apache/incubator-eventmesh/pull/545#issuecomment-938738066
@qqeasonchen ok, I will modify this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov-commenter edited a comment on pull request #545: [ISSUE #536] [ISSUE #339] fix start error & add skeleton of openschema plugin
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #545:
URL: https://github.com/apache/incubator-eventmesh/pull/545#issuecomment-928057373
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/545?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#545](https://codecov.io/gh/apache/incubator-eventmesh/pull/545?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7a90bd8) into [develop](https://codecov.io/gh/apache/incubator-eventmesh/commit/546765e5a9fd7bce1de99d6b50705220dc32293d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (546765e) will **increase** coverage by `0.09%`.
> The diff coverage is `44.44%`.
> :exclamation: Current head 7a90bd8 differs from pull request most recent head 89b3307. Consider uploading reports for the commit 89b3307 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-eventmesh/pull/545/graphs/tree.svg?width=650&height=150&src=pr&token=IfkrgV55GT&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-eventmesh/pull/545?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #545 +/- ##
=============================================
+ Coverage 10.99% 11.09% +0.09%
Complexity 376 376
=============================================
Files 257 258 +1
Lines 12191 12227 +36
Branches 1036 1040 +4
=============================================
+ Hits 1341 1357 +16
- Misses 10735 10754 +19
- Partials 115 116 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/545?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/eventmesh/runtime/boot/EventMeshServer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/545/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2Jvb3QvRXZlbnRNZXNoU2VydmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...rg/apache/eventmesh/runtime/schema/OpenSchema.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/545/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL3NjaGVtYS9PcGVuU2NoZW1hLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...e/eventmesh/common/config/CommonConfiguration.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/545/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9jb25maWcvQ29tbW9uQ29uZmlndXJhdGlvbi5qYXZh) | `85.88% <94.11%> (+2.05%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/545?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/545?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [546765e...89b3307](https://codecov.io/gh/apache/incubator-eventmesh/pull/545?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org