You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/09/18 09:07:28 UTC

[GitHub] [flink] link3280 opened a new pull request #17320: [FLINK-24319][Tests] Fix invalid surefire work directory for flink-tests

link3280 opened a new pull request #17320:
URL: https://github.com/apache/flink/pull/17320


   ## What is the purpose of the change
   
   Commit https://github.com/apache/flink/commit/7aa510c9e5dad2f0d2bcdcf1abc6b4f9e0374470#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8 changed the working dir of surefire plugin to project base dir, which leads to jar not found exception in ClassLoaderITCase, because it locates jar files via relative paths.
   
   
   ## Brief change log
   
   - Make flink-tests run in the project build directory.
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no 
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #17320: [FLINK-24319][Tests] Fix invalid surefire work directory for flink-tests

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17320:
URL: https://github.com/apache/flink/pull/17320#issuecomment-922249656


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6e6710706b5ff129386ca5dc3a4253b1cd3069d8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6e6710706b5ff129386ca5dc3a4253b1cd3069d8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6e6710706b5ff129386ca5dc3a4253b1cd3069d8 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #17320: [FLINK-24319][Tests] Fix invalid surefire work directory for flink-tests

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17320:
URL: https://github.com/apache/flink/pull/17320#issuecomment-922245796


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 6e6710706b5ff129386ca5dc3a4253b1cd3069d8 (Sat Sep 18 09:10:32 UTC 2021)
   
   **Warnings:**
    * **1 pom.xml files were touched**: Check for build and licensing issues.
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-24319).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17320: [FLINK-24319][Tests] Fix invalid surefire work directory for flink-tests

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17320:
URL: https://github.com/apache/flink/pull/17320#issuecomment-922249656


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6e6710706b5ff129386ca5dc3a4253b1cd3069d8",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24298",
       "triggerID" : "6e6710706b5ff129386ca5dc3a4253b1cd3069d8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6e6710706b5ff129386ca5dc3a4253b1cd3069d8 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24298) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17320: [FLINK-24319][Tests] Fix invalid surefire work directory for flink-tests

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17320:
URL: https://github.com/apache/flink/pull/17320#issuecomment-922249656


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6e6710706b5ff129386ca5dc3a4253b1cd3069d8",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24298",
       "triggerID" : "6e6710706b5ff129386ca5dc3a4253b1cd3069d8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6e6710706b5ff129386ca5dc3a4253b1cd3069d8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24298) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] link3280 commented on pull request #17320: [FLINK-24319][Tests] Fix invalid surefire work directory for flink-tests

Posted by GitBox <gi...@apache.org>.
link3280 commented on pull request #17320:
URL: https://github.com/apache/flink/pull/17320#issuecomment-939240605


   @zentol PTAL, this blocks users from running Flink tests outside of official CI pipelines.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] link3280 edited a comment on pull request #17320: [FLINK-24319][Tests] Fix invalid surefire work directory for flink-tests

Posted by GitBox <gi...@apache.org>.
link3280 edited a comment on pull request #17320:
URL: https://github.com/apache/flink/pull/17320#issuecomment-939240605


   @zentol PTAL, this blocks users from running Flink tests outside of the official CI pipeline.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17320: [FLINK-24319][Tests] Fix invalid surefire work directory for flink-tests

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17320:
URL: https://github.com/apache/flink/pull/17320#issuecomment-922249656


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6e6710706b5ff129386ca5dc3a4253b1cd3069d8",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24298",
       "triggerID" : "6e6710706b5ff129386ca5dc3a4253b1cd3069d8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6e6710706b5ff129386ca5dc3a4253b1cd3069d8 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24298) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] link3280 commented on pull request #17320: [FLINK-24319][Tests] Fix invalid surefire work directory for flink-tests

Posted by GitBox <gi...@apache.org>.
link3280 commented on pull request #17320:
URL: https://github.com/apache/flink/pull/17320#issuecomment-1066343155


   ping @zentol 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org