You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/23 16:33:53 UTC

[GitHub] [beam] lukecwik commented on a change in pull request #11178: [BEAM-9430] Update CHANGES.md to reflect removal of ProcessContext#updateWatermark

lukecwik commented on a change in pull request #11178: [BEAM-9430] Update CHANGES.md to reflect removal of ProcessContext#updateWatermark
URL: https://github.com/apache/beam/pull/11178#discussion_r396588302
 
 

 ##########
 File path: CHANGES.md
 ##########
 @@ -58,6 +58,7 @@
 ## Breaking Changes
 
 * HBaseIO.ReadAll now requires a PCollection of HBaseIO.Read objects instead of HBaseQuery objects ([BEAM-9279](https://issues.apache.org/jira/browse/BEAM-9279)).
+* ProcessContext.updateWatermark has been removed in favor of using a WatermarkEstimator ([BEAM-9430](https://issues.apache.org/jira/browse/BEAM-9430)).
 
 Review comment:
   Yes, there should be some examples of how to write SDFs added to our docs.
   After Java SDFs have a way to report progress and backlog, then we should be able to do this in Python and Java (and mention that Go is in the works).
   
   Are the docs something you were interested in doing?
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services