You are viewing a plain text version of this content. The canonical link for it is here.
Posted to proton@qpid.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2014/12/11 05:13:12 UTC

[jira] [Commented] (PROTON-769) Simplify the trace flag logic by only keeping a single copy

    [ https://issues.apache.org/jira/browse/PROTON-769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14242113#comment-14242113 ] 

ASF subversion and git services commented on PROTON-769:
--------------------------------------------------------

Commit e093b8c26396952ccd643beecbac11f1b02410da in qpid-proton's branch refs/heads/master from [~astitcher]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=e093b8c ]

PROTON-769: Move trace flags entirely to transport code


> Simplify the trace flag logic by only keeping a single copy
> -----------------------------------------------------------
>
>                 Key: PROTON-769
>                 URL: https://issues.apache.org/jira/browse/PROTON-769
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: proton-c
>            Reporter: Andrew Stitcher
>            Assignee: Andrew Stitcher
>
> The code that produces log output in Proton C is split into multiple places in the code. It would make more sense to me to centralise the trace flags into the pn_transport_t object to as currently the logging API is there but the flags are duplicated.
> As an aside it would also make sense to introduce some new flags to allow control of logging at other levels besides Frame dumps and Raw frame bytes. I'd suggest PN_TRACE_DBG for debug tracing and maybe INF for more informational messages.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)