[GitHub] ocket8888 commented on issue #3337: CIAB: Traffic Stats integration

[GitBox <gi...@apache.org>]

ocket8888 commented on issue #3337: CIAB: Traffic Stats integration
URL: https://github.com/apache/trafficcontrol/pull/3337#issuecomment-466608321
 
 
   There's no mandate that you use spaces vs tabs in bash or json files. Documentation needs to use tabs, Go and Perl code should be run through formatters, so you don't actually need to worry but fwiw the output will be tabs. At some point in the future we're going to introduce linting for Python (and JS?) code, and I'm going to fight hard to mandate tabs.
   But aside from that, there are no guidelines or restrictions.
   
   I'd like to make grafana into an optional container. I'm not sure what impact that'll have on the startup script for Traffic Stats - we're not very good in general about making components plug-and-play like that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services