[GitHub] [pulsar] codelipenghui commented on a change in pull request #6471: [Issue #5395][broker] Implement AutoTopicCreation by namespace override

[GitBox <gi...@apache.org>]

codelipenghui commented on a change in pull request #6471: [Issue #5395][broker] Implement AutoTopicCreation by namespace override
URL: https://github.com/apache/pulsar/pull/6471#discussion_r389224168
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java
 ##########
 @@ -298,6 +299,28 @@ public void modifyDeduplication(@PathParam("tenant") String tenant, @PathParam("
         internalModifyDeduplication(enableDeduplication);
     }
 
+    @POST
+    @Path("/{tenant}/{namespace}/allowAutoTopicCreationOverride")
+    @ApiOperation(value = "Override broker's allowAutoTopicCreation setting for a namespace")
+    @ApiResponses(value = { @ApiResponse(code = 403, message = "Don't have admin permission"),
+            @ApiResponse(code = 404, message = "Tenant or cluster or namespace doesn't exist"),
+            @ApiResponse(code = 400, message = "Invalid autoTopicCreation override") })
+    public void setAllowAutoTopicCreationOverride(@PathParam("tenant") String tenant, @PathParam("namespace") String namespace,
 
 Review comment:
   It's better to leverage with `AsyncResponse`, you can take a look https://github.com/apache/pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java#L198.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services