You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/03/22 13:18:41 UTC

[jira] [Commented] (FLINK-6162) Fix bug in ByteArrayOutputStreamWithPos#setPosition

    [ https://issues.apache.org/jira/browse/FLINK-6162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936280#comment-15936280 ] 

ASF GitHub Bot commented on FLINK-6162:
---------------------------------------

GitHub user wenlong88 opened a pull request:

    https://github.com/apache/flink/pull/3595

    [FLINK-6162]Fix bug in ByteArrayOutputStreamWithPos#setPosition

    Currently the precondition check in setPosition will fail when the buffer is full: 
    {{Preconditions.checkArgument(position < getEndPosition(), "Position out of bounds.");{{
    We should allow the expected position to be the end position
    
    I have added a test on the fix.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wenlong88/flink bugfix-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3595.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3595
    
----
commit 905e513612142a934bde78e54bf8a311c25a3107
Author: wenlong.lwl <we...@alibaba-inc.com>
Date:   2017-03-22T01:48:42Z

    Fix bug in ByteArrayOutputStreamWithPos

commit 09cc96adf52f78052bb3555f2ccda0d860da4895
Author: wenlong.lwl <we...@alibaba-inc.com>
Date:   2017-03-22T06:30:59Z

    fix typo

----


> Fix bug in ByteArrayOutputStreamWithPos#setPosition
> ---------------------------------------------------
>
>                 Key: FLINK-6162
>                 URL: https://issues.apache.org/jira/browse/FLINK-6162
>             Project: Flink
>          Issue Type: Bug
>          Components: Core
>            Reporter: Wenlong Lyu
>            Assignee: Wenlong Lyu
>
> Currently the precondition check in setPosition will fail when the buffer is full: 
> {{Preconditions.checkArgument(position < getEndPosition(), "Position out of bounds.");}}
> We should allow the expected position to be the end position



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)