You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/08/04 12:11:44 UTC

[GitHub] [pulsar] Bklyn opened a new pull request #7745: [pulsar-client-cpp] Some clarification of docs for partition and ordering key

Bklyn opened a new pull request #7745:
URL: https://github.com/apache/pulsar/pull/7745


   ### Motivation
   
   As a Pulsar newbie, the role of "partition key" and "ordering key" aren't entirely clear from the Doxygen comments.  These names are not used in the public Pulsar documentation that I saw, so expanding the comments felt useful to me and may help other users.
   
   ### Modifications
   
   Expanded doc strings for `MessageBuilder.setPartitionKey` and `setOrderingKey`
   
   ### Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Documentation
   
   This change improves the C++ Doxygen output.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Bklyn commented on pull request #7745: [pulsar-client-cpp] Some clarification of docs for partition and ordering key

Posted by GitBox <gi...@apache.org>.
Bklyn commented on pull request #7745:
URL: https://github.com/apache/pulsar/pull/7745#issuecomment-669147202


   Seems like the CI builds failed, but I don't think that was due to my change.  Is there any way to re-run them, aside from perhaps pushing a non-change diff, like re-wording the commit message?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] jiazhai merged pull request #7745: [pulsar-client-cpp] Some clarification of docs for partition and ordering key

Posted by GitBox <gi...@apache.org>.
jiazhai merged pull request #7745:
URL: https://github.com/apache/pulsar/pull/7745


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org