You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Rob Godfrey (Commented) (JIRA)" <ji...@apache.org> on 2012/02/27 22:51:48 UTC

[jira] [Commented] (QPID-2020) AMQConnection.create[Durable]ConnectionConsumer should do something better than just return null

    [ https://issues.apache.org/jira/browse/QPID-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217600#comment-13217600 ] 

Rob Godfrey commented on QPID-2020:
-----------------------------------

Reading the javadoc 

throws "JMSException - if the Connection object fails to create a connection consumer due to some internal error or invalid arguments for sessionPool and messageSelector. "

it seems more appropriate to throw a JMSException than to return null.  Actually implementing correctly seems non-trivial, and possibly better left until after the client is re-written.

 
                
> AMQConnection.create[Durable]ConnectionConsumer should do something better than just return null
> ------------------------------------------------------------------------------------------------
>
>                 Key: QPID-2020
>                 URL: https://issues.apache.org/jira/browse/QPID-2020
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client
>            Reporter: Rafael H. Schloming
>            Assignee: Rob Godfrey
>
> In some cases these methods are expected to throw IllegalStateExceptions. At a minimum we should do this even if we aren't going to implement them for real.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org