You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2019/06/09 16:03:17 UTC

[GitHub] [nifi] matthew-formosa-gig opened a new pull request #3526: NIFI-6368: Avro logical decimal type with precision and scale

matthew-formosa-gig opened a new pull request #3526: NIFI-6368: Avro logical decimal type with precision and scale
URL: https://github.com/apache/nifi/pull/3526
 
 
   Thank you for submitting a contribution to Apache NiFi.
   
   Please provide a short description of the PR here:
   
   Description of PR
   
   Controller services such as the JsonSetRecordWriter do no take into account the precision and scale in the case of Avro logical decimal types. While this may not be classified as a bug since the output is Json and not Avro, this improvement should help eliminate any misunderstandings between the different serialisations.
   
   This should also improve functionality of other processors making use of such utils.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   For all changes:
   
     Is there a JIRA ticket associated with this PR? Is it referenced
   in the commit message?
   
     Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
     Has your PR been rebased against the latest commit within the target branch (typically master)?
   
     Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.
   
   For code changes:
   
     Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
     Have you written or updated unit tests to verify your changes?
   Note:
   
   Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services