You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Rishi Bhardwaj (JIRA)" <ji...@apache.org> on 2010/10/21 20:32:16 UTC

[jira] Created: (CASSANDRA-1643) Endpoint cache for a token should be part of AbstractReplicationStrategy and not Snitch

Endpoint cache for a token should be part of AbstractReplicationStrategy and not Snitch
---------------------------------------------------------------------------------------

                 Key: CASSANDRA-1643
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1643
             Project: Cassandra
          Issue Type: Bug
          Components: Core
    Affects Versions: 0.7 beta 2, 0.7 beta 1
            Reporter: Rishi Bhardwaj
             Fix For: 0.7.0


There is a single DynamicEndpointSnitch object for all ReplicationStrategy objects. This DynamicEndpointSnitch object contains a single IEndpointSnitch subsnitch object. This subsnitch object contains the Endpoint cache for a token. Thus there is a single endpoint cache for all ReplicationStrategy objects. This implies that replica nodes for a Token as returned by the Cache would be same irrespective of the ReplicationStrategy object. This is a bug, the Endpoint cache should be a part of "AbstractReplicationStrategy" object rather than the IEndpointSnitch object.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (CASSANDRA-1643) Endpoint cache for a token should be part of AbstractReplicationStrategy and not Snitch

Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923626#action_12923626 ] 

Brandon Williams commented on CASSANDRA-1643:
---------------------------------------------

+1

> Endpoint cache for a token should be part of AbstractReplicationStrategy and not Snitch
> ---------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1643
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1643
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7 beta 1
>            Reporter: Rishi Bhardwaj
>            Assignee: Jonathan Ellis
>             Fix For: 0.7.0
>
>         Attachments: 1643-v2.txt, 1643.txt
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> There is a single DynamicEndpointSnitch object for all ReplicationStrategy objects. This DynamicEndpointSnitch object contains a single IEndpointSnitch subsnitch object. This subsnitch object contains the Endpoint cache for a token. Thus there is a single endpoint cache for all ReplicationStrategy objects. This implies that replica nodes for a Token as returned by the Cache would be same irrespective of the ReplicationStrategy object. This is a bug, the Endpoint cache should be a part of "AbstractReplicationStrategy" object rather than the IEndpointSnitch object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (CASSANDRA-1643) Endpoint cache for a token should be part of AbstractReplicationStrategy and not Snitch

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923827#action_12923827 ] 

Hudson commented on CASSANDRA-1643:
-----------------------------------

Integrated in Cassandra #573 (See [https://hudson.apache.org/hudson/job/Cassandra/573/])
    move endpoint cache from snitch to strategy
patch by jbellis; reviewed by brandonwilliams for CASSANDRA-1643


> Endpoint cache for a token should be part of AbstractReplicationStrategy and not Snitch
> ---------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1643
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1643
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7 beta 1
>            Reporter: Rishi Bhardwaj
>            Assignee: Jonathan Ellis
>             Fix For: 0.7.0
>
>         Attachments: 1643-v2.txt, 1643.txt
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> There is a single DynamicEndpointSnitch object for all ReplicationStrategy objects. This DynamicEndpointSnitch object contains a single IEndpointSnitch subsnitch object. This subsnitch object contains the Endpoint cache for a token. Thus there is a single endpoint cache for all ReplicationStrategy objects. This implies that replica nodes for a Token as returned by the Cache would be same irrespective of the ReplicationStrategy object. This is a bug, the Endpoint cache should be a part of "AbstractReplicationStrategy" object rather than the IEndpointSnitch object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (CASSANDRA-1643) Endpoint cache for a token should be part of AbstractReplicationStrategy and not Snitch

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-1643:
--------------------------------------

    Attachment: 1643-v2.txt

fixed test

> Endpoint cache for a token should be part of AbstractReplicationStrategy and not Snitch
> ---------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1643
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1643
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7 beta 1
>            Reporter: Rishi Bhardwaj
>            Assignee: Jonathan Ellis
>             Fix For: 0.7.0
>
>         Attachments: 1643-v2.txt, 1643.txt
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> There is a single DynamicEndpointSnitch object for all ReplicationStrategy objects. This DynamicEndpointSnitch object contains a single IEndpointSnitch subsnitch object. This subsnitch object contains the Endpoint cache for a token. Thus there is a single endpoint cache for all ReplicationStrategy objects. This implies that replica nodes for a Token as returned by the Cache would be same irrespective of the ReplicationStrategy object. This is a bug, the Endpoint cache should be a part of "AbstractReplicationStrategy" object rather than the IEndpointSnitch object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (CASSANDRA-1643) Endpoint cache for a token should be part of AbstractReplicationStrategy and not Snitch

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-1643:
--------------------------------------

    Attachment: 1643.txt

> Endpoint cache for a token should be part of AbstractReplicationStrategy and not Snitch
> ---------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1643
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1643
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7 beta 1
>            Reporter: Rishi Bhardwaj
>             Fix For: 0.7.0
>
>         Attachments: 1643.txt
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> There is a single DynamicEndpointSnitch object for all ReplicationStrategy objects. This DynamicEndpointSnitch object contains a single IEndpointSnitch subsnitch object. This subsnitch object contains the Endpoint cache for a token. Thus there is a single endpoint cache for all ReplicationStrategy objects. This implies that replica nodes for a Token as returned by the Cache would be same irrespective of the ReplicationStrategy object. This is a bug, the Endpoint cache should be a part of "AbstractReplicationStrategy" object rather than the IEndpointSnitch object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (CASSANDRA-1643) Endpoint cache for a token should be part of AbstractReplicationStrategy and not Snitch

Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923612#action_12923612 ] 

Brandon Williams commented on CASSANDRA-1643:
---------------------------------------------

SimpleStrategyTest is broken:

    [junit] Testsuite: org.apache.cassandra.locator.SimpleStrategyTest
    [junit] Tests run: 4, Failures: 1, Errors: 0, Time elapsed: 0.591 sec
    [junit]
    [junit] Testcase: tryBogusTable(org.apache.cassandra.locator.SimpleStrategyTest):   FAILED
    [junit] No replica strategy configured for SomeBogusTableThatDoesntExist
    [junit] junit.framework.AssertionFailedError: No replica strategy configured for SomeBogusTableThatDoesntExist
    [junit]     at org.apache.cassandra.service.StorageService.getReplicationStrategy(StorageService.java:254)
    [junit]     at org.apache.cassandra.locator.SimpleStrategyTest.tryBogusTable(SimpleStrategyTest.java:48)
    [junit]
    [junit]
    [junit] Test org.apache.cassandra.locator.SimpleStrategyTest FAILED


> Endpoint cache for a token should be part of AbstractReplicationStrategy and not Snitch
> ---------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1643
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1643
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7 beta 1
>            Reporter: Rishi Bhardwaj
>            Assignee: Jonathan Ellis
>             Fix For: 0.7.0
>
>         Attachments: 1643.txt
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> There is a single DynamicEndpointSnitch object for all ReplicationStrategy objects. This DynamicEndpointSnitch object contains a single IEndpointSnitch subsnitch object. This subsnitch object contains the Endpoint cache for a token. Thus there is a single endpoint cache for all ReplicationStrategy objects. This implies that replica nodes for a Token as returned by the Cache would be same irrespective of the ReplicationStrategy object. This is a bug, the Endpoint cache should be a part of "AbstractReplicationStrategy" object rather than the IEndpointSnitch object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.