You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2018/10/25 17:12:50 UTC
[GitHub] spark pull request #22829: [SPARK-25836][BUILD][K8S] For now disable kuberne...
GitHub user srowen opened a pull request:
https://github.com/apache/spark/pull/22829
[SPARK-25836][BUILD][K8S] For now disable kubernetes-integration-tests
## What changes were proposed in this pull request?
For now make building and running kubernetes-integration-tests manual.
## How was this patch tested?
N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srowen/spark SPARK-25836
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22829.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22829
----
commit fea27cca1d015d02d9b78470250fa9a39d0e318d
Author: Sean Owen <se...@...>
Date: 2018-10-25T17:10:09Z
For now disable kubernetes-integration-tests
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22829: [SPARK-25836][BUILD][K8S] For now disable kubernetes-int...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22829
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22829: [SPARK-25836][BUILD][K8S] For now disable kubernetes-int...
Posted by skonto <gi...@git.apache.org>.
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/22829
ok seems this to be closed. I will copy it to the other PR.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22829: [SPARK-25836][BUILD][K8S] For now disable kubernetes-int...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22829
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22829: [SPARK-25836][BUILD][K8S] For now disable kubernetes-int...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22829
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4488/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22829: [SPARK-25836][BUILD][K8S] For now disable kubernetes-int...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22829
**[Test build #98031 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98031/testReport)** for PR 22829 at commit [`fea27cc`](https://github.com/apache/spark/commit/fea27cca1d015d02d9b78470250fa9a39d0e318d).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22829: [SPARK-25836][BUILD][K8S] For now disable kubernetes-int...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22829
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4488/
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22829: [SPARK-25836][BUILD][K8S] For now disable kubernetes-int...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22829
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4497/
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22829: [SPARK-25836][BUILD][K8S] For now disable kuberne...
Posted by srowen <gi...@git.apache.org>.
Github user srowen closed the pull request at:
https://github.com/apache/spark/pull/22829
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22829: [SPARK-25836][BUILD][K8S] For now disable kubernetes-int...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22829
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4497/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22829: [SPARK-25836][BUILD][K8S] For now disable kuberne...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22829#discussion_r228285511
--- Diff: pom.xml ---
@@ -2656,7 +2656,8 @@
<id>kubernetes</id>
<modules>
<module>resource-managers/kubernetes/core</module>
- <module>resource-managers/kubernetes/integration-tests</module>
+ <!-- for now, don't automatically build and run the integration tests -->
+ <!-- <module>resource-managers/kubernetes/integration-tests</module> -->
--- End diff --
That's fine too. I even think this is a temporary measure, and that ideally these all live in the kubernetes module as test artifacts.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22829: [SPARK-25836][BUILD][K8S] For now disable kubernetes-int...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22829
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4497/
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22829: [SPARK-25836][BUILD][K8S] For now disable kubernetes-int...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22829
**[Test build #98042 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98042/testReport)** for PR 22829 at commit [`8ee6b30`](https://github.com/apache/spark/commit/8ee6b304d3f2c8376f2cc61a675e4c35234addb3).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22829: [SPARK-25836][BUILD][K8S] For now disable kubernetes-int...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22829
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98031/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22829: [SPARK-25836][BUILD][K8S] For now disable kubernetes-int...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22829
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22829: [SPARK-25836][BUILD][K8S] For now disable kubernetes-int...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22829
**[Test build #98031 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98031/testReport)** for PR 22829 at commit [`fea27cc`](https://github.com/apache/spark/commit/fea27cca1d015d02d9b78470250fa9a39d0e318d).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22829: [SPARK-25836][BUILD][K8S] For now disable kuberne...
Posted by mccheah <gi...@git.apache.org>.
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22829#discussion_r228281269
--- Diff: pom.xml ---
@@ -2656,7 +2656,8 @@
<id>kubernetes</id>
<modules>
<module>resource-managers/kubernetes/core</module>
- <module>resource-managers/kubernetes/integration-tests</module>
+ <!-- for now, don't automatically build and run the integration tests -->
+ <!-- <module>resource-managers/kubernetes/integration-tests</module> -->
--- End diff --
I think this would mean it's not possible to run the integration tests at all via Maven, because the integration tests module will never be available. What about creating a separate profile, `kubernetes-integration-tests`, which includes both the `kubernetes` and the `kubernetes/integration-tests` module?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22829: [SPARK-25836][BUILD][K8S] For now disable kubernetes-int...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22829
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22829: [SPARK-25836][BUILD][K8S] For now disable kubernetes-int...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22829
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4488/
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22829: [SPARK-25836][BUILD][K8S] For now disable kubernetes-int...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22829
**[Test build #98042 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98042/testReport)** for PR 22829 at commit [`8ee6b30`](https://github.com/apache/spark/commit/8ee6b304d3f2c8376f2cc61a675e4c35234addb3).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22829: [SPARK-25836][BUILD][K8S] For now disable kubernetes-int...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22829
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98042/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org