You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by ji...@codehaus.org on 2004/10/26 22:47:08 UTC
[jira] Created: (MPJCOVERAGE-18) Inner/anonymous classes report uncomplete
Message:
A new issue has been created in JIRA.
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPJCOVERAGE-18
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPJCOVERAGE-18
Summary: Inner/anonymous classes report uncomplete
Type: Bug
Status: Open
Priority: Major
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-jcoverage-plugin
Versions:
1.0.8
Assignee: Emmanuel Venisse
Reporter: Daniel Frey
Created: Tue, 26 Oct 2004 4:46 PM
Updated: Tue, 26 Oct 2004 4:46 PM
Description:
Since I use maven (1.0b8 or so) up to now (1.0) I observe that the JCoverage plugin does produce wrong results for inner/anonymous classes. I.e. I have got a class called ClassOne, which has an anonymouls inner class. The two classes are displayed in the coverage report as ClassOnewith 44% and ClassOne$1 with 0% tested, which is correct. The underlining reference to the html-file is in both cases the same. However, the file displays only the coverage of the inner class, the outer class does not contain any counts, red or green lines.
I doublechecked whether the coverage.xml file contains the corresponding values, which it does. So it seems to be a problem of the plugin itself.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MPJCOVERAGE-18) Inner/anonymous classes report uncomplete
Posted by ji...@codehaus.org.
The following issue has been updated:
Updater: Stephen Colebourne (mailto:scolebourne@btopenworld.com)
Date: Sun, 23 Jan 2005 2:05 PM
Comment:
PATCH to fix the problem described here which affects all inner classes.
Changes:
Attachment changed to JCoveragePatch.txt
---------------------------------------------------------------------
For a full history of the issue, see:
http://jira.codehaus.org/browse/MPJCOVERAGE-18?page=history
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPJCOVERAGE-18
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPJCOVERAGE-18
Summary: Inner/anonymous classes report uncomplete
Type: Bug
Status: Open
Priority: Major
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-jcoverage-plugin
Versions:
1.0.8
Assignee: Emmanuel Venisse
Reporter: Daniel Frey
Created: Tue, 26 Oct 2004 4:46 PM
Updated: Sun, 23 Jan 2005 2:05 PM
Description:
Since I use maven (1.0b8 or so) up to now (1.0) I observe that the JCoverage plugin does produce wrong results for inner/anonymous classes. I.e. I have got a class called ClassOne, which has an anonymouls inner class. The two classes are displayed in the coverage report as ClassOnewith 44% and ClassOne$1 with 0% tested, which is correct. The underlining reference to the html-file is in both cases the same. However, the file displays only the coverage of the inner class, the outer class does not contain any counts, red or green lines.
I doublechecked whether the coverage.xml file contains the corresponding values, which it does. So it seems to be a problem of the plugin itself.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPJCOVERAGE-18) Inner/anonymous classes report uncomplete
Posted by "Erik Forkalsrud (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPJCOVERAGE-18?page=comments#action_31759 ]
Erik Forkalsrud commented on MPJCOVERAGE-18:
--------------------------------------------
I tried the patch and it works pretty well. However, the additional html files it generates don't seem to be linked from the allcallses-frame.html and package-frame.html files. I was able to fix that by using the getShortFileName() method on line 187 (CoverageReport.java) and remove the if-statement following it, so all classes get listed. I updated the patch, but I havent figured out how to put it in JIRA. (it's at http://forkalsrud.org/~erik/JCoveragePatch2.txt for now)
Also, setting up a developer environment for maven plugins turned out to be pretty simple. I did this using eclipse with these steps:
1 - File->Import... -- "Checkout Projects from CVS"
2 - Select: "Create a new repository location"
3 - Enter values:
Host == cvs.apache.org
Repository Path == /home/cvspublic
User == anoncvs
Connection Type == pserver
4 - Select: User specified module name: "maven-plugins/jcoverage"
5 - Select: "Check out as project configured using the New Project Wizard"
6 - Select: "HEAD" and "Finish"
7 - Now, go though the regular eclipse project wizard.
I use MevenIde (http://mevenide.codehaus.org/) to add "Maven Nature" to
the project and cofigure all jars through the POM Synchronizer
8 - Go through steps 1-7, again, but this time, check out the module
"maven-plugins/plugin-parent"
(Also, you can "use an existing repoitory location" this time i.e. the
one you created in step 3)
9 - Right-click on CoverageReport.java and select: Team->Apply Patch...
to apply JCoveragePatch.txt
10 - Go to your eclipse workspace folder where the jcoverage plugin is,
and type "maven plugin:install" to try out your code changes.
> Inner/anonymous classes report uncomplete
> -----------------------------------------
>
> Key: MPJCOVERAGE-18
> URL: http://jira.codehaus.org/browse/MPJCOVERAGE-18
> Project: maven-jcoverage-plugin
> Type: Bug
> Versions: 1.0.8
> Reporter: Daniel Frey
> Assignee: Emmanuel Venisse
> Fix For: 1.0.10
> Attachments: JCoveragePatch.txt
>
>
> Since I use maven (1.0b8 or so) up to now (1.0) I observe that the JCoverage plugin does produce wrong results for inner/anonymous classes. I.e. I have got a class called ClassOne, which has an anonymouls inner class. The two classes are displayed in the coverage report as ClassOnewith 44% and ClassOne$1 with 0% tested, which is correct. The underlining reference to the html-file is in both cases the same. However, the file displays only the coverage of the inner class, the outer class does not contain any counts, red or green lines.
>
> I doublechecked whether the coverage.xml file contains the corresponding values, which it does. So it seems to be a problem of the plugin itself.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Closed: (MPJCOVERAGE-18) Inner/anonymous classes report uncomplete
Posted by ji...@codehaus.org.
Message:
The following issue has been closed.
Resolver: Emmanuel Venisse
Date: Wed, 26 Jan 2005 5:23 PM
Applied. Thanks.
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPJCOVERAGE-18
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPJCOVERAGE-18
Summary: Inner/anonymous classes report uncomplete
Type: Bug
Status: Closed
Priority: Major
Resolution: FIXED
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-jcoverage-plugin
Fix Fors:
1.0.10
Versions:
1.0.8
Assignee: Emmanuel Venisse
Reporter: Daniel Frey
Created: Tue, 26 Oct 2004 4:46 PM
Updated: Wed, 26 Jan 2005 5:23 PM
Description:
Since I use maven (1.0b8 or so) up to now (1.0) I observe that the JCoverage plugin does produce wrong results for inner/anonymous classes. I.e. I have got a class called ClassOne, which has an anonymouls inner class. The two classes are displayed in the coverage report as ClassOnewith 44% and ClassOne$1 with 0% tested, which is correct. The underlining reference to the html-file is in both cases the same. However, the file displays only the coverage of the inner class, the outer class does not contain any counts, red or green lines.
I doublechecked whether the coverage.xml file contains the corresponding values, which it does. So it seems to be a problem of the plugin itself.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPJCOVERAGE-18) Inner/anonymous classes report uncomplete
Posted by ji...@codehaus.org.
The following comment has been added to this issue:
Author: Michael Heuer
Created: Wed, 19 Jan 2005 3:59 PM
Body:
I'm not smart enough to set up a development environment for maven plugins, but I believe the following changes to CoverageReport.java will do the trick:
In coverage.xml, you see
<coverage src="...
<class name="org.mydomain.MyClass$InnerClass0">
<file name="org/mydomain/MyClass.java">
<line ...
</class>
<class name="org.mydomain.MyClass$InnerClass1">
<file name="org/mydomain/MyClass.java">
<line ...
</class>
<class name="org.mydomain.MyClass">
<file name="org/mydomain/MyClass.java">
<line ...
</class>
But all three html reports are written to a file org/mydomain/MyClass.html.
At line numbers 283, 334, 357, and 367-375 in CoverageReport.java a file name based on Clazz.getName() instead of Clazz.getFile() should be created, e.g.
org/mydomain/MyClass$InnerClass0.html
org/mydomain/MyClass$InnerClass1.html
org/mydomain/MyClass.html
I'll leave the simple code fix to someone who knows how to build and deploy maven plugins. :)
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MPJCOVERAGE-18?page=comments#action_29078
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPJCOVERAGE-18
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPJCOVERAGE-18
Summary: Inner/anonymous classes report uncomplete
Type: Bug
Status: Open
Priority: Major
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-jcoverage-plugin
Versions:
1.0.8
Assignee: Emmanuel Venisse
Reporter: Daniel Frey
Created: Tue, 26 Oct 2004 4:46 PM
Updated: Wed, 19 Jan 2005 3:59 PM
Description:
Since I use maven (1.0b8 or so) up to now (1.0) I observe that the JCoverage plugin does produce wrong results for inner/anonymous classes. I.e. I have got a class called ClassOne, which has an anonymouls inner class. The two classes are displayed in the coverage report as ClassOnewith 44% and ClassOne$1 with 0% tested, which is correct. The underlining reference to the html-file is in both cases the same. However, the file displays only the coverage of the inner class, the outer class does not contain any counts, red or green lines.
I doublechecked whether the coverage.xml file contains the corresponding values, which it does. So it seems to be a problem of the plugin itself.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPJCOVERAGE-18) Inner/anonymous classes report uncomplete
Posted by ji...@codehaus.org.
The following comment has been added to this issue:
Author: Michael Heuer
Created: Wed, 26 Jan 2005 2:53 PM
Body:
The patch looks good, thank you Stephen.
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MPJCOVERAGE-18?page=comments#action_29302
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPJCOVERAGE-18
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPJCOVERAGE-18
Summary: Inner/anonymous classes report uncomplete
Type: Bug
Status: Open
Priority: Major
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-jcoverage-plugin
Versions:
1.0.8
Assignee: Emmanuel Venisse
Reporter: Daniel Frey
Created: Tue, 26 Oct 2004 4:46 PM
Updated: Wed, 26 Jan 2005 2:53 PM
Description:
Since I use maven (1.0b8 or so) up to now (1.0) I observe that the JCoverage plugin does produce wrong results for inner/anonymous classes. I.e. I have got a class called ClassOne, which has an anonymouls inner class. The two classes are displayed in the coverage report as ClassOnewith 44% and ClassOne$1 with 0% tested, which is correct. The underlining reference to the html-file is in both cases the same. However, the file displays only the coverage of the inner class, the outer class does not contain any counts, red or green lines.
I doublechecked whether the coverage.xml file contains the corresponding values, which it does. So it seems to be a problem of the plugin itself.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPJCOVERAGE-18) Inner/anonymous classes report uncomplete
Posted by "Julie Cowart (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MPJCOVERAGE-18?page=comments#action_31625 ]
Julie Cowart commented on MPJCOVERAGE-18:
-----------------------------------------
This fix doesn't actually appear to have been applied to CVS.
> Inner/anonymous classes report uncomplete
> -----------------------------------------
>
> Key: MPJCOVERAGE-18
> URL: http://jira.codehaus.org/browse/MPJCOVERAGE-18
> Project: maven-jcoverage-plugin
> Type: Bug
> Versions: 1.0.8
> Reporter: Daniel Frey
> Assignee: Emmanuel Venisse
> Fix For: 1.0.10
> Attachments: JCoveragePatch.txt
>
>
> Since I use maven (1.0b8 or so) up to now (1.0) I observe that the JCoverage plugin does produce wrong results for inner/anonymous classes. I.e. I have got a class called ClassOne, which has an anonymouls inner class. The two classes are displayed in the coverage report as ClassOnewith 44% and ClassOne$1 with 0% tested, which is correct. The underlining reference to the html-file is in both cases the same. However, the file displays only the coverage of the inner class, the outer class does not contain any counts, red or green lines.
>
> I doublechecked whether the coverage.xml file contains the corresponding values, which it does. So it seems to be a problem of the plugin itself.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org