[Impala-ASF-CR] IMPALA-8648: Add a simple stress test for reading ACID tables

["Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>]

Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13751 )

Change subject: IMPALA-8648: Add a simple stress test for reading ACID tables
......................................................................


Patch Set 3:

(8 comments)

http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py
File tests/stress/test_acid_stress.py:

http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@49
PS3, Line 49:  
nit: no space needed


http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@49
PS3, Line 49: '
nit: extra '


http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@67
PS3, Line 67: read
write?


http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@68
PS3, Line 68: from Hive.
Should we add another role and test for an Impala writer?


http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@86
PS3, Line 86:       if len(result.data) == 0:
            :         continue
nit: __verify_result() could just return when result.data is empty


http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@94
PS3, Line 94:     
nit: extra indentation


http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@114
PS3, Line 114: CTRL+C can't interrupt the test
You can use pool.map_async(...).get(long timeout) which will handle keyboard interrupts properly.
See https://stackoverflow.com/a/1408476


http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@116
PS3, Line 116:     for i in pool.imap(do_role, ["impala", "hive"]):
             :       pass
why not just simply pool.imap()? Or better, pool.map_async(...).get(...)?



-- 
To view, visit http://gerrit.cloudera.org:8080/13751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8
Gerrit-Change-Number: 13751
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 30 Sep 2019 15:17:15 +0000
Gerrit-HasComments: Yes