You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/06/30 14:57:36 UTC

[GitHub] [shardingsphere] iamkyu opened a new pull request #11082: Update Readme of docker-compose

iamkyu opened a new pull request #11082:
URL: https://github.com/apache/shardingsphere/pull/11082


   Changes proposed in this pull request:
   - Update to current directory


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero edited a comment on pull request #11082: Update Readme of docker-compose

Posted by GitBox <gi...@apache.org>.
tristaZero edited a comment on pull request #11082:
URL: https://github.com/apache/shardingsphere/pull/11082#issuecomment-872072025


   Hi @iamhuzl 
   I just gave a look at the example module.
   Like @TeslaCN said, `shardingsphere-jdbc` and `shardingsphere-proxy` are preferred, therefore could you help rename the directory names of example modules to them instead of modifying the doc?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #11082: Update Readme of docker-compose

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #11082:
URL: https://github.com/apache/shardingsphere/pull/11082#issuecomment-871528040


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11082?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#11082](https://codecov.io/gh/apache/shardingsphere/pull/11082?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7034828) into [master](https://codecov.io/gh/apache/shardingsphere/commit/7c48b04bef742ad61e128372b9c6be548d1389c5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7c48b04) will **decrease** coverage by `0.10%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/11082/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/11082?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #11082      +/-   ##
   ============================================
   - Coverage     65.62%   65.51%   -0.11%     
     Complexity      686      686              
   ============================================
     Files          1835     1835              
     Lines         31087    31087              
     Branches       5607     5607              
   ============================================
   - Hits          20400    20367      -33     
   - Misses         9076     9098      +22     
   - Partials       1611     1622      +11     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/11082?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...mpl/updater/CreateEncryptRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/11082/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmRsL2ltcGwvdXBkYXRlci9DcmVhdGVFbmNyeXB0UnVsZVN0YXRlbWVudFVwZGF0ZXIuamF2YQ==) | `51.72% <0.00%> (-34.49%)` | :arrow_down: |
   | [...r/CreateDatabaseDiscoveryRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/11082/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmRsL2ltcGwvdXBkYXRlci9DcmVhdGVEYXRhYmFzZURpc2NvdmVyeVJ1bGVTdGF0ZW1lbnRVcGRhdGVyLmphdmE=) | `63.41% <0.00%> (-24.40%)` | :arrow_down: |
   | [...terShardingBroadcastTableRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/11082/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmRsL2ltcGwvdXBkYXRlci9BbHRlclNoYXJkaW5nQnJvYWRjYXN0VGFibGVSdWxlU3RhdGVtZW50VXBkYXRlci5qYXZh) | `78.57% <0.00%> (-21.43%)` | :arrow_down: |
   | [...AlterShardingBindingTableRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/11082/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmRsL2ltcGwvdXBkYXRlci9BbHRlclNoYXJkaW5nQmluZGluZ1RhYmxlUnVsZVN0YXRlbWVudFVwZGF0ZXIuamF2YQ==) | `80.00% <0.00%> (-13.34%)` | :arrow_down: |
   | [.../CreateReadwriteSplittingRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/11082/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmRsL2ltcGwvdXBkYXRlci9DcmVhdGVSZWFkd3JpdGVTcGxpdHRpbmdSdWxlU3RhdGVtZW50VXBkYXRlci5qYXZh) | `86.84% <0.00%> (-13.16%)` | :arrow_down: |
   | [...ckend/text/distsql/rdl/impl/RDLBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/11082/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmRsL2ltcGwvUkRMQmFja2VuZEhhbmRsZXIuamF2YQ==) | `75.86% <0.00%> (-6.90%)` | :arrow_down: |
   | [...pdater/AlterShardingTableRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/11082/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmRsL2ltcGwvdXBkYXRlci9BbHRlclNoYXJkaW5nVGFibGVSdWxlU3RhdGVtZW50VXBkYXRlci5qYXZh) | `83.33% <0.00%> (-5.56%)` | :arrow_down: |
   | [...ingsphere/transaction/core/ResourceDataSource.java](https://codecov.io/gh/apache/shardingsphere/pull/11082/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdHJhbnNhY3Rpb24vc2hhcmRpbmdzcGhlcmUtdHJhbnNhY3Rpb24tY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdHJhbnNhY3Rpb24vY29yZS9SZXNvdXJjZURhdGFTb3VyY2UuamF2YQ==) | `100.00% <0.00%> (+100.00%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11082?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11082?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7c48b04...7034828](https://codecov.io/gh/apache/shardingsphere/pull/11082?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero merged pull request #11082: Update Readme of docker-compose

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #11082:
URL: https://github.com/apache/shardingsphere/pull/11082


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] TeslaCN edited a comment on pull request #11082: Update Readme of docker-compose

Posted by GitBox <gi...@apache.org>.
TeslaCN edited a comment on pull request #11082:
URL: https://github.com/apache/shardingsphere/pull/11082#issuecomment-872058975


   > @tristaZero
   > current version on master branch. (maybe 5.0.0-beta)
   > 
   > I guess @TeslaCN means,
   > 
   > * change directory name `/examples/docker/sharding-jdbc/` to `/examples/docker/shardingsphere-jdbc/` that same as readme
   > * Instead of change directory name in `docker-compose.md` and `docker-compose-zh.md`
   > 
   > is it right? I will pull request ASAP.
   
   Yes. `sharding-jdbc` or `sharding-proxy` were named after the legacy version. The current version are `shardingsphere-jdbc` and `shardingsphere-proxy`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on pull request #11082: Update Readme of docker-compose

Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #11082:
URL: https://github.com/apache/shardingsphere/pull/11082#issuecomment-872072025


   @iamkyu Looks like we need another PR to revert it, could you give a hand?
   But I am curious why your raise this PR? Do you have some problems with our examples?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] iamkyu commented on pull request #11082: Update Readme of docker-compose

Posted by GitBox <gi...@apache.org>.
iamkyu commented on pull request #11082:
URL: https://github.com/apache/shardingsphere/pull/11082#issuecomment-872050972


   @tristaZero 
   current version on master branch. (maybe 5.0.0-beta)
   
   I guess @TeslaCN means, 
   - change directory name `/examples/docker/sharding-jdbc/` to `/examples/docker/shardingsphere-jdbc/` that same as readme
   - Instead of change directory name in `docker-compose.md` and `docker-compose-zh.md`
   
   is it right? I will pull request ASAP.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on pull request #11082: Update Readme of docker-compose

Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #11082:
URL: https://github.com/apache/shardingsphere/pull/11082#issuecomment-872043379


   Hi @iamkyu ,
   
   Thanks for your PR. which version do you use? @TeslaCN feedbacked that the doc is correct.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero edited a comment on pull request #11082: Update Readme of docker-compose

Posted by GitBox <gi...@apache.org>.
tristaZero edited a comment on pull request #11082:
URL: https://github.com/apache/shardingsphere/pull/11082#issuecomment-872072025


   @iamkyu Looks like we need another PR to revert it, could you give a hand?
   But I am curious why you raised this PR? Do you have some problems with examples?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] TeslaCN commented on pull request #11082: Update Readme of docker-compose

Posted by GitBox <gi...@apache.org>.
TeslaCN commented on pull request #11082:
URL: https://github.com/apache/shardingsphere/pull/11082#issuecomment-872058975


   > @tristaZero
   > current version on master branch. (maybe 5.0.0-beta)
   > 
   > I guess @TeslaCN means,
   > 
   > * change directory name `/examples/docker/sharding-jdbc/` to `/examples/docker/shardingsphere-jdbc/` that same as readme
   > * Instead of change directory name in `docker-compose.md` and `docker-compose-zh.md`
   > 
   > is it right? I will pull request ASAP.
   
   Yes. `sharding-jdbc` or `sharding-proxy` was named after the legacy version. The current version is `shardingsphere-jdbc` and `shardingsphere-proxy`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org