You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/01/11 05:15:46 UTC

[GitHub] [incubator-yunikorn-release] yangwwei opened a new pull request #61: [YUNIKORN-1006] add notes about incompatible changes in the release doc

yangwwei opened a new pull request #61:
URL: https://github.com/apache/incubator-yunikorn-release/pull/61


   Fix QU40
   
   The project puts a high priority on backwards compatibility and aims to document any incompatible changes and provide tools and documentation to help users transition to new features.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org


[GitHub] [incubator-yunikorn-release] yangwwei commented on pull request #61: [YUNIKORN-1006] add notes about incompatible changes in the release doc

Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #61:
URL: https://github.com/apache/incubator-yunikorn-release/pull/61#issuecomment-1009612129


   thanks for the quick review @yuchaoran2011 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org


[GitHub] [incubator-yunikorn-release] yuchaoran2011 merged pull request #61: [YUNIKORN-1006] add notes about incompatible changes in the release doc

Posted by GitBox <gi...@apache.org>.
yuchaoran2011 merged pull request #61:
URL: https://github.com/apache/incubator-yunikorn-release/pull/61


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org


[GitHub] [incubator-yunikorn-release] yuchaoran2011 commented on a change in pull request #61: [YUNIKORN-1006] add notes about incompatible changes in the release doc

Posted by GitBox <gi...@apache.org>.
yuchaoran2011 commented on a change in pull request #61:
URL: https://github.com/apache/incubator-yunikorn-release/pull/61#discussion_r781765608



##########
File path: docs/release-procedure.md
##########
@@ -74,6 +74,13 @@ Follow these steps to generate the list:
 - Select the style `Text` and click `create`
 - Scroll to the bottom of the page and copy the content of the text area and update the [CHANGELOG](../release-top-level-artifacts/CHANGELOG) file.
 
+## Incompatible Changes
+YuniKorn community puts a high priority to the backwards compatibility. For each release, all incompatible
+changes must be carefully reviewed and documented. In general, incompatible changes to the public APIs usually requires

Review comment:
       ```suggestion
   changes must be carefully reviewed and documented. In general, incompatible changes to the public APIs usually require
   ```

##########
File path: docs/release-procedure.md
##########
@@ -74,6 +74,13 @@ Follow these steps to generate the list:
 - Select the style `Text` and click `create`
 - Scroll to the bottom of the page and copy the content of the text area and update the [CHANGELOG](../release-top-level-artifacts/CHANGELOG) file.
 
+## Incompatible Changes
+YuniKorn community puts a high priority to the backwards compatibility. For each release, all incompatible
+changes must be carefully reviewed and documented. In general, incompatible changes to the public APIs usually requires
+a major version bump, this needs to be discussed in the private list. Examples are REST API changes, scheduler-interface

Review comment:
       ```suggestion
   a major version bump and they need to be discussed in the private list. Examples are REST API changes, scheduler-interface
   ```

##########
File path: docs/release-procedure.md
##########
@@ -74,6 +74,13 @@ Follow these steps to generate the list:
 - Select the style `Text` and click `create`
 - Scroll to the bottom of the page and copy the content of the text area and update the [CHANGELOG](../release-top-level-artifacts/CHANGELOG) file.
 
+## Incompatible Changes
+YuniKorn community puts a high priority to the backwards compatibility. For each release, all incompatible

Review comment:
       ```suggestion
   YuniKorn community puts a high priority on backward compatibility. For each release, all incompatible
   ```

##########
File path: docs/release-procedure.md
##########
@@ -74,6 +74,13 @@ Follow these steps to generate the list:
 - Select the style `Text` and click `create`
 - Scroll to the bottom of the page and copy the content of the text area and update the [CHANGELOG](../release-top-level-artifacts/CHANGELOG) file.
 
+## Incompatible Changes
+YuniKorn community puts a high priority to the backwards compatibility. For each release, all incompatible
+changes must be carefully reviewed and documented. In general, incompatible changes to the public APIs usually requires
+a major version bump, this needs to be discussed in the private list. Examples are REST API changes, scheduler-interface
+main API changes. In the release notes, all incompatible changes must be clearly documented. User should be able to

Review comment:
       ```suggestion
   main API changes. In the release notes, all incompatible changes must be clearly documented. Users should be able to
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org