You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Ravi Gummadi (JIRA)" <ji...@apache.org> on 2011/04/01 11:25:05 UTC
[jira] [Created] (MAPREDUCE-2416) In Gridmix, in
RoundRobinUserResolver, the list of groups for a user obtained from
users-list-file is incorrect
In Gridmix, in RoundRobinUserResolver, the list of groups for a user obtained from users-list-file is incorrect
---------------------------------------------------------------------------------------------------------------
Key: MAPREDUCE-2416
URL: https://issues.apache.org/jira/browse/MAPREDUCE-2416
Project: Hadoop Map/Reduce
Issue Type: Bug
Components: contrib/gridmix
Reporter: Ravi Gummadi
Assignee: Ravi Gummadi
RoundRobinUserResolver.parseUserList() has a bug in obtaining list of groups for each user --- in the sense that the list is not cleared before obtaining groups list for the next user. So if the first line has some groups, then from 2nd
line onwards, the validation of "whether the users(in the next lines) are also having group names in those lines" is useless as the list is already nonempty.
For example, users-list-file content as shown below also is valid as per parseUserList():
------------------
user1,group1
user2,
user3,
user4,
------------------
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2416) In Gridmix, in
RoundRobinUserResolver, the list of groups for a user obtained from
users-list-file is incorrect
Posted by "Ravi Gummadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ravi Gummadi updated MAPREDUCE-2416:
------------------------------------
Attachment: 2416.patch
Attaching patch that removes the restriction of specifying groups of each user in the users-list-file of RoundRobinUserResolver.
With this patch, the new format of each line of the users-list-file is
{code}
username[,group]*
{code}
[,group]* is just to allow older users-list-files for backward compatibility. Later, may be in the next release, we can fully remove the groups from users-list-file.
This patch is on top of the patch of MAPREDUCE-2417.
> In Gridmix, in RoundRobinUserResolver, the list of groups for a user obtained from users-list-file is incorrect
> ---------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2416
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2416
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/gridmix
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Attachments: 2416.patch
>
>
> RoundRobinUserResolver.parseUserList() has a bug in obtaining list of groups for each user --- in the sense that the list is not cleared before obtaining groups list for the next user. So if the first line has some groups, then from 2nd
> line onwards, the validation of "whether the users(in the next lines) are also having group names in those lines" is useless as the list is already nonempty.
> For example, users-list-file content as shown below also is valid as per parseUserList():
> ------------------
> user1,group1
> user2,
> user3,
> user4,
> ------------------
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2416) In Gridmix, in
RoundRobinUserResolver, the list of groups for a user obtained from
users-list-file is incorrect
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028775#comment-13028775 ]
Hudson commented on MAPREDUCE-2416:
-----------------------------------
Integrated in Hadoop-Mapreduce-trunk #669 (See [https://builds.apache.org/hudson/job/Hadoop-Mapreduce-trunk/669/])
> In Gridmix, in RoundRobinUserResolver, the list of groups for a user obtained from users-list-file is incorrect
> ---------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2416
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2416
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/gridmix
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Fix For: 0.23.0
>
> Attachments: 2416.patch, 2416.v1.patch
>
>
> RoundRobinUserResolver.parseUserList() has a bug in obtaining list of groups for each user --- in the sense that the list is not cleared before obtaining groups list for the next user. So if the first line has some groups, then from 2nd
> line onwards, the validation of "whether the users(in the next lines) are also having group names in those lines" is useless as the list is already nonempty.
> For example, users-list-file content as shown below also is valid as per parseUserList():
> ------------------
> user1,group1
> user2,
> user3,
> user4,
> ------------------
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2416) In Gridmix, in
RoundRobinUserResolver, the list of groups for a user obtained from
users-list-file is incorrect
Posted by "Ravi Gummadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ravi Gummadi updated MAPREDUCE-2416:
------------------------------------
Attachment: 2416.v1.patch
Attaching new patch making some minor changes to the comments and documentation.
> In Gridmix, in RoundRobinUserResolver, the list of groups for a user obtained from users-list-file is incorrect
> ---------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2416
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2416
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/gridmix
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Attachments: 2416.patch, 2416.v1.patch
>
>
> RoundRobinUserResolver.parseUserList() has a bug in obtaining list of groups for each user --- in the sense that the list is not cleared before obtaining groups list for the next user. So if the first line has some groups, then from 2nd
> line onwards, the validation of "whether the users(in the next lines) are also having group names in those lines" is useless as the list is already nonempty.
> For example, users-list-file content as shown below also is valid as per parseUserList():
> ------------------
> user1,group1
> user2,
> user3,
> user4,
> ------------------
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2416) In Gridmix, in
RoundRobinUserResolver, the list of groups for a user obtained from
users-list-file is incorrect
Posted by "Ravi Gummadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ravi Gummadi updated MAPREDUCE-2416:
------------------------------------
Resolution: Fixed
Release Note: Removes the restriction of specifying group names in users-list file for Gridmix in RoundRobinUserResolver mode.
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this to trunk.
> In Gridmix, in RoundRobinUserResolver, the list of groups for a user obtained from users-list-file is incorrect
> ---------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2416
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2416
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/gridmix
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Fix For: 0.23.0
>
> Attachments: 2416.patch, 2416.v1.patch
>
>
> RoundRobinUserResolver.parseUserList() has a bug in obtaining list of groups for each user --- in the sense that the list is not cleared before obtaining groups list for the next user. So if the first line has some groups, then from 2nd
> line onwards, the validation of "whether the users(in the next lines) are also having group names in those lines" is useless as the list is already nonempty.
> For example, users-list-file content as shown below also is valid as per parseUserList():
> ------------------
> user1,group1
> user2,
> user3,
> user4,
> ------------------
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2416) In Gridmix, in
RoundRobinUserResolver, the list of groups for a user obtained from
users-list-file is incorrect
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026834#comment-13026834 ]
Hudson commented on MAPREDUCE-2416:
-----------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #652 (See [https://builds.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/652/])
MAPREDUCE-2416. Remove the restriction of specifying group names in users-list file for Gridmix in RoundRobinUserResolver mode.
> In Gridmix, in RoundRobinUserResolver, the list of groups for a user obtained from users-list-file is incorrect
> ---------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2416
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2416
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/gridmix
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Fix For: 0.23.0
>
> Attachments: 2416.patch, 2416.v1.patch
>
>
> RoundRobinUserResolver.parseUserList() has a bug in obtaining list of groups for each user --- in the sense that the list is not cleared before obtaining groups list for the next user. So if the first line has some groups, then from 2nd
> line onwards, the validation of "whether the users(in the next lines) are also having group names in those lines" is useless as the list is already nonempty.
> For example, users-list-file content as shown below also is valid as per parseUserList():
> ------------------
> user1,group1
> user2,
> user3,
> user4,
> ------------------
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2416) In Gridmix, in
RoundRobinUserResolver, the list of groups for a user obtained from
users-list-file is incorrect
Posted by "Ravi Gummadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017342#comment-13017342 ]
Ravi Gummadi commented on MAPREDUCE-2416:
-----------------------------------------
Since Gridmix doesn't use/need the groups specified in users-list-file, I am planning to remove the restriction of specifying the groups in this file for RoundRobinUserResolver.
So the new format of the users-list-file expected is
user1
user2
user3
....
Just to allow backward compatibility, the list of groups can be there after user name after comma in any/all the lines.
So each line can be of the form
username[,group]*
> In Gridmix, in RoundRobinUserResolver, the list of groups for a user obtained from users-list-file is incorrect
> ---------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2416
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2416
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/gridmix
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
>
> RoundRobinUserResolver.parseUserList() has a bug in obtaining list of groups for each user --- in the sense that the list is not cleared before obtaining groups list for the next user. So if the first line has some groups, then from 2nd
> line onwards, the validation of "whether the users(in the next lines) are also having group names in those lines" is useless as the list is already nonempty.
> For example, users-list-file content as shown below also is valid as per parseUserList():
> ------------------
> user1,group1
> user2,
> user3,
> user4,
> ------------------
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2416) In Gridmix, in
RoundRobinUserResolver, the list of groups for a user obtained from
users-list-file is incorrect
Posted by "Ravi Gummadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017346#comment-13017346 ]
Ravi Gummadi commented on MAPREDUCE-2416:
-----------------------------------------
Because the changes for the fix of MAPREDUCE-2417 and the code changes of this JIRA are at the same place in code, the combined patch of MAPREDUCE-2416 and MAPREDUCE-2417 is uploaded to MAPREDUCE-2417.
> In Gridmix, in RoundRobinUserResolver, the list of groups for a user obtained from users-list-file is incorrect
> ---------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2416
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2416
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/gridmix
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
>
> RoundRobinUserResolver.parseUserList() has a bug in obtaining list of groups for each user --- in the sense that the list is not cleared before obtaining groups list for the next user. So if the first line has some groups, then from 2nd
> line onwards, the validation of "whether the users(in the next lines) are also having group names in those lines" is useless as the list is already nonempty.
> For example, users-list-file content as shown below also is valid as per parseUserList():
> ------------------
> user1,group1
> user2,
> user3,
> user4,
> ------------------
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2416) In Gridmix, in
RoundRobinUserResolver, the list of groups for a user obtained from
users-list-file is incorrect
Posted by "Ravi Gummadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ravi Gummadi updated MAPREDUCE-2416:
------------------------------------
Fix Version/s: 0.23.0
Status: Patch Available (was: Open)
> In Gridmix, in RoundRobinUserResolver, the list of groups for a user obtained from users-list-file is incorrect
> ---------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2416
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2416
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/gridmix
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Fix For: 0.23.0
>
> Attachments: 2416.patch, 2416.v1.patch
>
>
> RoundRobinUserResolver.parseUserList() has a bug in obtaining list of groups for each user --- in the sense that the list is not cleared before obtaining groups list for the next user. So if the first line has some groups, then from 2nd
> line onwards, the validation of "whether the users(in the next lines) are also having group names in those lines" is useless as the list is already nonempty.
> For example, users-list-file content as shown below also is valid as per parseUserList():
> ------------------
> user1,group1
> user2,
> user3,
> user4,
> ------------------
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2416) In Gridmix, in
RoundRobinUserResolver, the list of groups for a user obtained from
users-list-file is incorrect
Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026207#comment-13026207 ]
Amar Kamat commented on MAPREDUCE-2416:
---------------------------------------
Patch looks good to me. +1.
> In Gridmix, in RoundRobinUserResolver, the list of groups for a user obtained from users-list-file is incorrect
> ---------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2416
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2416
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/gridmix
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Fix For: 0.23.0
>
> Attachments: 2416.patch, 2416.v1.patch
>
>
> RoundRobinUserResolver.parseUserList() has a bug in obtaining list of groups for each user --- in the sense that the list is not cleared before obtaining groups list for the next user. So if the first line has some groups, then from 2nd
> line onwards, the validation of "whether the users(in the next lines) are also having group names in those lines" is useless as the list is already nonempty.
> For example, users-list-file content as shown below also is valid as per parseUserList():
> ------------------
> user1,group1
> user2,
> user3,
> user4,
> ------------------
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2416) In Gridmix, in
RoundRobinUserResolver, the list of groups for a user obtained from
users-list-file is incorrect
Posted by "Ravi Gummadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026824#comment-13026824 ]
Ravi Gummadi commented on MAPREDUCE-2416:
-----------------------------------------
Failed contrib tests are not related to this patch at all. I will commit this patch.
> In Gridmix, in RoundRobinUserResolver, the list of groups for a user obtained from users-list-file is incorrect
> ---------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2416
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2416
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/gridmix
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Fix For: 0.23.0
>
> Attachments: 2416.patch, 2416.v1.patch
>
>
> RoundRobinUserResolver.parseUserList() has a bug in obtaining list of groups for each user --- in the sense that the list is not cleared before obtaining groups list for the next user. So if the first line has some groups, then from 2nd
> line onwards, the validation of "whether the users(in the next lines) are also having group names in those lines" is useless as the list is already nonempty.
> For example, users-list-file content as shown below also is valid as per parseUserList():
> ------------------
> user1,group1
> user2,
> user3,
> user4,
> ------------------
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2416) In Gridmix, in
RoundRobinUserResolver, the list of groups for a user obtained from
users-list-file is incorrect
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026261#comment-13026261 ]
Hadoop QA commented on MAPREDUCE-2416:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12477630/2416.v1.patch
against trunk revision 1097345.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/193//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/193//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/193//console
This message is automatically generated.
> In Gridmix, in RoundRobinUserResolver, the list of groups for a user obtained from users-list-file is incorrect
> ---------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2416
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2416
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/gridmix
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Fix For: 0.23.0
>
> Attachments: 2416.patch, 2416.v1.patch
>
>
> RoundRobinUserResolver.parseUserList() has a bug in obtaining list of groups for each user --- in the sense that the list is not cleared before obtaining groups list for the next user. So if the first line has some groups, then from 2nd
> line onwards, the validation of "whether the users(in the next lines) are also having group names in those lines" is useless as the list is already nonempty.
> For example, users-list-file content as shown below also is valid as per parseUserList():
> ------------------
> user1,group1
> user2,
> user3,
> user4,
> ------------------
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira