[jira] [Commented] (HIVE-5966) Fix eclipse:eclipse post shim aggregation changes

["Brock Noland (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-5966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13840199#comment-13840199 ] 

Brock Noland commented on HIVE-5966:
------------------------------------

I see two solutions:

1) Change the bundle to a simple aggregation point of dependencies. I don't see why we actually have to bundle the classes into a single jar. In this scenerio we'd remove the assembly and create a module called say "hive-shims-aggregator" which would do nothing but depend on the other shims with a scope of runtime. That way the other modules could simply use this dep to pull in all shims.

2) Add the three version specific shims to all modules which depend on the shims with a scope of provided. This should make them available to eclipse but not pulled in by children.

I prefer 1.

> Fix eclipse:eclipse post shim aggregation changes
> -------------------------------------------------
>
>                 Key: HIVE-5966
>                 URL: https://issues.apache.org/jira/browse/HIVE-5966
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Brock Noland
>
> The shim bundle module marks it's deps provided so users of the bundle won't pull in the child dependencies. This causes the eclipse workspace generated by eclipse:eclipse to fail because it only includes the source from the bundle source directory, which is empty.



--
This message was sent by Atlassian JIRA
(v6.1#6144)