You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/09/13 07:52:45 UTC

[GitHub] [hudi] liujinhui1994 opened a new pull request #3652: [HUDI-2423] Breakdown HoodieMetricsConfig into HoodieMetricsGraphiteConfig

liujinhui1994 opened a new pull request #3652:
URL: https://github.com/apache/hudi/pull/3652


   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   *(For example: This pull request adds quick-start document.)*
   
   ## Brief change log
   
   *(for example:)*
     - *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] liujinhui1994 commented on pull request #3652: [HUDI-2423] Breakdown HoodieMetricsConfig into HoodieMetricsGraphiteConfig、HoodieMetricsJmxConfig

Posted by GitBox <gi...@apache.org>.
liujinhui1994 commented on pull request #3652:
URL: https://github.com/apache/hudi/pull/3652#issuecomment-919862538


   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] liujinhui1994 commented on pull request #3652: [HUDI-2423] Breakdown HoodieMetricsConfig into HoodieMetricsGraphiteConfig

Posted by GitBox <gi...@apache.org>.
liujinhui1994 commented on pull request #3652:
URL: https://github.com/apache/hudi/pull/3652#issuecomment-919642227


   @pratyakshsharma  Can you help merge? thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] liujinhui1994 commented on pull request #3652: [HUDI-2423] Separate some config logic from HoodieMetricsConfig into HoodieMetricsGraphiteConfig HoodieMetricsJmxConfig

Posted by GitBox <gi...@apache.org>.
liujinhui1994 commented on pull request #3652:
URL: https://github.com/apache/hudi/pull/3652#issuecomment-920635637


   @yanghua  thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3652: [HUDI-2423] Breakdown HoodieMetricsConfig into HoodieMetricsGraphiteConfig

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3652:
URL: https://github.com/apache/hudi/pull/3652#issuecomment-917936364


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d56d7168748f63e71d8ce5b28d46d31b8a5eb92d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2183",
       "triggerID" : "d56d7168748f63e71d8ce5b28d46d31b8a5eb92d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2185",
       "triggerID" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2189",
       "triggerID" : "918219181",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2192",
       "triggerID" : "918277232",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "188523ea282b43bddcb5f188f68322513b6fc9e3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2203",
       "triggerID" : "188523ea282b43bddcb5f188f68322513b6fc9e3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "188523ea282b43bddcb5f188f68322513b6fc9e3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2205",
       "triggerID" : "918915683",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 188523ea282b43bddcb5f188f68322513b6fc9e3 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2203) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2205) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3652: [HUDI-2423] Breakdown HoodieMetricsConfig into HoodieMetricsGraphiteConfig

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3652:
URL: https://github.com/apache/hudi/pull/3652#issuecomment-917936364


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d56d7168748f63e71d8ce5b28d46d31b8a5eb92d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2183",
       "triggerID" : "d56d7168748f63e71d8ce5b28d46d31b8a5eb92d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2185",
       "triggerID" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2189",
       "triggerID" : "918219181",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2192",
       "triggerID" : "918277232",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 5a2aed9baf58604d489104ca6fb3750643f0e984 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2185) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2189) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2192) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] liujinhui1994 commented on pull request #3652: [HUDI-2423] Breakdown HoodieMetricsConfig into HoodieMetricsGraphiteConfig、HoodieMetricsJmxConfig

Posted by GitBox <gi...@apache.org>.
liujinhui1994 commented on pull request #3652:
URL: https://github.com/apache/hudi/pull/3652#issuecomment-919826819


   @hudi-bot  run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3652: [HUDI-2423] Breakdown HoodieMetricsConfig into HoodieMetricsGraphiteConfig

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3652:
URL: https://github.com/apache/hudi/pull/3652#issuecomment-917936364


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d56d7168748f63e71d8ce5b28d46d31b8a5eb92d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2183",
       "triggerID" : "d56d7168748f63e71d8ce5b28d46d31b8a5eb92d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2185",
       "triggerID" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2189",
       "triggerID" : "918219181",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 5a2aed9baf58604d489104ca6fb3750643f0e984 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2185) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2189) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3652: [HUDI-2423] Breakdown HoodieMetricsConfig into HoodieMetricsGraphiteConfig

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3652:
URL: https://github.com/apache/hudi/pull/3652#issuecomment-917936364


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d56d7168748f63e71d8ce5b28d46d31b8a5eb92d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2183",
       "triggerID" : "d56d7168748f63e71d8ce5b28d46d31b8a5eb92d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2185",
       "triggerID" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5a2aed9baf58604d489104ca6fb3750643f0e984 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2185) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #3652: [HUDI-2423] Breakdown HoodieMetricsConfig into HoodieMetricsGraphiteConfig

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3652:
URL: https://github.com/apache/hudi/pull/3652#issuecomment-917936364


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d56d7168748f63e71d8ce5b28d46d31b8a5eb92d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d56d7168748f63e71d8ce5b28d46d31b8a5eb92d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d56d7168748f63e71d8ce5b28d46d31b8a5eb92d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3652: [HUDI-2423] Breakdown HoodieMetricsConfig into HoodieMetricsGraphiteConfig

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3652:
URL: https://github.com/apache/hudi/pull/3652#issuecomment-917936364


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d56d7168748f63e71d8ce5b28d46d31b8a5eb92d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2183",
       "triggerID" : "d56d7168748f63e71d8ce5b28d46d31b8a5eb92d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d56d7168748f63e71d8ce5b28d46d31b8a5eb92d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2183) 
   * 5a2aed9baf58604d489104ca6fb3750643f0e984 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] liujinhui1994 commented on a change in pull request #3652: [HUDI-2423] Breakdown HoodieMetricsConfig into HoodieMetricsGraphiteConfig、HoodieMetricsJmxConfig

Posted by GitBox <gi...@apache.org>.
liujinhui1994 commented on a change in pull request #3652:
URL: https://github.com/apache/hudi/pull/3652#discussion_r708891159



##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java
##########
@@ -198,10 +203,7 @@ private HoodieWriteConfig createMetadataWriteConfig(HoodieWriteConfig writeConfi
         default:
           throw new HoodieMetadataException("Unsupported Metrics Reporter type " + writeConfig.getMetricsReporterType());
       }
-
-      builder.withMetricsConfig(metricsConfig.build());
     }
-

Review comment:
       The extra blank lines should be deleted here

##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java
##########
@@ -175,19 +177,22 @@ private HoodieWriteConfig createMetadataWriteConfig(HoodieWriteConfig writeConfi
         .withFinalizeWriteParallelism(parallelism);
 
     if (writeConfig.isMetricsOn()) {
-      HoodieMetricsConfig.Builder metricsConfig = HoodieMetricsConfig.newBuilder()
-          .withReporterType(writeConfig.getMetricsReporterType().toString())
-          .withExecutorMetrics(writeConfig.isExecutorMetricsEnabled())
-          .on(true);
+      builder.withMetricsConfig(HoodieMetricsConfig.newBuilder()
+               .withReporterType(writeConfig.getMetricsReporterType().toString())
+               .withExecutorMetrics(writeConfig.isExecutorMetricsEnabled())
+               .on(true).build());
       switch (writeConfig.getMetricsReporterType()) {
         case GRAPHITE:
-          metricsConfig.onGraphitePort(writeConfig.getGraphiteServerPort())
-              .toGraphiteHost(writeConfig.getGraphiteServerHost())
-              .usePrefix(writeConfig.getGraphiteMetricPrefix());
+          builder.withMetricsGraphiteConfig(HoodieMetricsGraphiteConfig.newBuilder()
+                   .onGraphitePort(writeConfig.getGraphiteServerPort())
+                   .toGraphiteHost(writeConfig.getGraphiteServerHost())
+                   .usePrefix(writeConfig.getGraphiteMetricPrefix()).build());
           break;
         case JMX:
-          metricsConfig.onJmxPort(writeConfig.getJmxPort())
-              .toJmxHost(writeConfig.getJmxHost());
+          builder.withMetricsJmxConfig(HoodieMetricsJmxConfig.newBuilder()
+                   .onJmxPort(writeConfig.getJmxPort())

Review comment:
       ok

##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java
##########
@@ -175,19 +177,22 @@ private HoodieWriteConfig createMetadataWriteConfig(HoodieWriteConfig writeConfi
         .withFinalizeWriteParallelism(parallelism);
 
     if (writeConfig.isMetricsOn()) {
-      HoodieMetricsConfig.Builder metricsConfig = HoodieMetricsConfig.newBuilder()
-          .withReporterType(writeConfig.getMetricsReporterType().toString())
-          .withExecutorMetrics(writeConfig.isExecutorMetricsEnabled())
-          .on(true);
+      builder.withMetricsConfig(HoodieMetricsConfig.newBuilder()
+               .withReporterType(writeConfig.getMetricsReporterType().toString())
+               .withExecutorMetrics(writeConfig.isExecutorMetricsEnabled())
+               .on(true).build());
       switch (writeConfig.getMetricsReporterType()) {
         case GRAPHITE:
-          metricsConfig.onGraphitePort(writeConfig.getGraphiteServerPort())
-              .toGraphiteHost(writeConfig.getGraphiteServerHost())
-              .usePrefix(writeConfig.getGraphiteMetricPrefix());
+          builder.withMetricsGraphiteConfig(HoodieMetricsGraphiteConfig.newBuilder()
+                   .onGraphitePort(writeConfig.getGraphiteServerPort())

Review comment:
       ok

##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java
##########
@@ -175,19 +177,22 @@ private HoodieWriteConfig createMetadataWriteConfig(HoodieWriteConfig writeConfi
         .withFinalizeWriteParallelism(parallelism);
 
     if (writeConfig.isMetricsOn()) {
-      HoodieMetricsConfig.Builder metricsConfig = HoodieMetricsConfig.newBuilder()
-          .withReporterType(writeConfig.getMetricsReporterType().toString())
-          .withExecutorMetrics(writeConfig.isExecutorMetricsEnabled())
-          .on(true);
+      builder.withMetricsConfig(HoodieMetricsConfig.newBuilder()
+               .withReporterType(writeConfig.getMetricsReporterType().toString())

Review comment:
       ok




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3652: [HUDI-2423] Breakdown HoodieMetricsConfig into HoodieMetricsGraphiteConfig、HoodieMetricsJmxConfig

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3652:
URL: https://github.com/apache/hudi/pull/3652#issuecomment-917936364


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d56d7168748f63e71d8ce5b28d46d31b8a5eb92d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2183",
       "triggerID" : "d56d7168748f63e71d8ce5b28d46d31b8a5eb92d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2185",
       "triggerID" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2189",
       "triggerID" : "918219181",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2192",
       "triggerID" : "918277232",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "188523ea282b43bddcb5f188f68322513b6fc9e3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2203",
       "triggerID" : "188523ea282b43bddcb5f188f68322513b6fc9e3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "188523ea282b43bddcb5f188f68322513b6fc9e3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2205",
       "triggerID" : "918915683",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "82c5783f99eccbb5728658ad2c91e7d36e51280a",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2229",
       "triggerID" : "82c5783f99eccbb5728658ad2c91e7d36e51280a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "82c5783f99eccbb5728658ad2c91e7d36e51280a",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2237",
       "triggerID" : "919862538",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 82c5783f99eccbb5728658ad2c91e7d36e51280a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2229) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2237) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] liujinhui1994 commented on pull request #3652: [HUDI-2423] Breakdown HoodieMetricsConfig into HoodieMetricsGraphiteConfig

Posted by GitBox <gi...@apache.org>.
liujinhui1994 commented on pull request #3652:
URL: https://github.com/apache/hudi/pull/3652#issuecomment-918219181


   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] yanghua commented on a change in pull request #3652: [HUDI-2423] Breakdown HoodieMetricsConfig into HoodieMetricsGraphiteConfig

Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #3652:
URL: https://github.com/apache/hudi/pull/3652#discussion_r708881025



##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java
##########
@@ -175,19 +177,22 @@ private HoodieWriteConfig createMetadataWriteConfig(HoodieWriteConfig writeConfi
         .withFinalizeWriteParallelism(parallelism);
 
     if (writeConfig.isMetricsOn()) {
-      HoodieMetricsConfig.Builder metricsConfig = HoodieMetricsConfig.newBuilder()
-          .withReporterType(writeConfig.getMetricsReporterType().toString())
-          .withExecutorMetrics(writeConfig.isExecutorMetricsEnabled())
-          .on(true);
+      builder.withMetricsConfig(HoodieMetricsConfig.newBuilder()
+               .withReporterType(writeConfig.getMetricsReporterType().toString())

Review comment:
       recover the indent?

##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java
##########
@@ -198,10 +203,7 @@ private HoodieWriteConfig createMetadataWriteConfig(HoodieWriteConfig writeConfi
         default:
           throw new HoodieMetadataException("Unsupported Metrics Reporter type " + writeConfig.getMetricsReporterType());
       }
-
-      builder.withMetricsConfig(metricsConfig.build());
     }
-

Review comment:
       keep this empty line?

##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java
##########
@@ -175,19 +177,22 @@ private HoodieWriteConfig createMetadataWriteConfig(HoodieWriteConfig writeConfi
         .withFinalizeWriteParallelism(parallelism);
 
     if (writeConfig.isMetricsOn()) {
-      HoodieMetricsConfig.Builder metricsConfig = HoodieMetricsConfig.newBuilder()
-          .withReporterType(writeConfig.getMetricsReporterType().toString())
-          .withExecutorMetrics(writeConfig.isExecutorMetricsEnabled())
-          .on(true);
+      builder.withMetricsConfig(HoodieMetricsConfig.newBuilder()
+               .withReporterType(writeConfig.getMetricsReporterType().toString())
+               .withExecutorMetrics(writeConfig.isExecutorMetricsEnabled())
+               .on(true).build());
       switch (writeConfig.getMetricsReporterType()) {
         case GRAPHITE:
-          metricsConfig.onGraphitePort(writeConfig.getGraphiteServerPort())
-              .toGraphiteHost(writeConfig.getGraphiteServerHost())
-              .usePrefix(writeConfig.getGraphiteMetricPrefix());
+          builder.withMetricsGraphiteConfig(HoodieMetricsGraphiteConfig.newBuilder()
+                   .onGraphitePort(writeConfig.getGraphiteServerPort())

Review comment:
       ditto

##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java
##########
@@ -175,19 +177,22 @@ private HoodieWriteConfig createMetadataWriteConfig(HoodieWriteConfig writeConfi
         .withFinalizeWriteParallelism(parallelism);
 
     if (writeConfig.isMetricsOn()) {
-      HoodieMetricsConfig.Builder metricsConfig = HoodieMetricsConfig.newBuilder()
-          .withReporterType(writeConfig.getMetricsReporterType().toString())
-          .withExecutorMetrics(writeConfig.isExecutorMetricsEnabled())
-          .on(true);
+      builder.withMetricsConfig(HoodieMetricsConfig.newBuilder()
+               .withReporterType(writeConfig.getMetricsReporterType().toString())
+               .withExecutorMetrics(writeConfig.isExecutorMetricsEnabled())
+               .on(true).build());
       switch (writeConfig.getMetricsReporterType()) {
         case GRAPHITE:
-          metricsConfig.onGraphitePort(writeConfig.getGraphiteServerPort())
-              .toGraphiteHost(writeConfig.getGraphiteServerHost())
-              .usePrefix(writeConfig.getGraphiteMetricPrefix());
+          builder.withMetricsGraphiteConfig(HoodieMetricsGraphiteConfig.newBuilder()
+                   .onGraphitePort(writeConfig.getGraphiteServerPort())
+                   .toGraphiteHost(writeConfig.getGraphiteServerHost())
+                   .usePrefix(writeConfig.getGraphiteMetricPrefix()).build());
           break;
         case JMX:
-          metricsConfig.onJmxPort(writeConfig.getJmxPort())
-              .toJmxHost(writeConfig.getJmxHost());
+          builder.withMetricsJmxConfig(HoodieMetricsJmxConfig.newBuilder()
+                   .onJmxPort(writeConfig.getJmxPort())

Review comment:
       ditto




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3652: [HUDI-2423] Breakdown HoodieMetricsConfig into HoodieMetricsGraphiteConfig

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3652:
URL: https://github.com/apache/hudi/pull/3652#issuecomment-917936364


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d56d7168748f63e71d8ce5b28d46d31b8a5eb92d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2183",
       "triggerID" : "d56d7168748f63e71d8ce5b28d46d31b8a5eb92d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2185",
       "triggerID" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2189",
       "triggerID" : "918219181",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2192",
       "triggerID" : "918277232",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 5a2aed9baf58604d489104ca6fb3750643f0e984 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2185) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2189) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2192) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3652: [HUDI-2423] Breakdown HoodieMetricsConfig into HoodieMetricsGraphiteConfig

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3652:
URL: https://github.com/apache/hudi/pull/3652#issuecomment-917936364


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d56d7168748f63e71d8ce5b28d46d31b8a5eb92d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2183",
       "triggerID" : "d56d7168748f63e71d8ce5b28d46d31b8a5eb92d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2185",
       "triggerID" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2189",
       "triggerID" : "918219181",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2192",
       "triggerID" : "918277232",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "188523ea282b43bddcb5f188f68322513b6fc9e3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2203",
       "triggerID" : "188523ea282b43bddcb5f188f68322513b6fc9e3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "188523ea282b43bddcb5f188f68322513b6fc9e3",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2205",
       "triggerID" : "918915683",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 188523ea282b43bddcb5f188f68322513b6fc9e3 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2203) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2205) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] liujinhui1994 commented on pull request #3652: [HUDI-2423] Breakdown HoodieMetricsConfig into HoodieMetricsGraphiteConfig

Posted by GitBox <gi...@apache.org>.
liujinhui1994 commented on pull request #3652:
URL: https://github.com/apache/hudi/pull/3652#issuecomment-917975529


   thanks
   @pratyakshsharma 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] yanghua merged pull request #3652: [HUDI-2423] Separate some config logic from HoodieMetricsConfig into HoodieMetricsGraphiteConfig HoodieMetricsJmxConfig

Posted by GitBox <gi...@apache.org>.
yanghua merged pull request #3652:
URL: https://github.com/apache/hudi/pull/3652


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3652: [HUDI-2423] Breakdown HoodieMetricsConfig into HoodieMetricsGraphiteConfig、HoodieMetricsJmxConfig

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3652:
URL: https://github.com/apache/hudi/pull/3652#issuecomment-917936364


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d56d7168748f63e71d8ce5b28d46d31b8a5eb92d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2183",
       "triggerID" : "d56d7168748f63e71d8ce5b28d46d31b8a5eb92d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2185",
       "triggerID" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2189",
       "triggerID" : "918219181",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2192",
       "triggerID" : "918277232",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "188523ea282b43bddcb5f188f68322513b6fc9e3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2203",
       "triggerID" : "188523ea282b43bddcb5f188f68322513b6fc9e3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "188523ea282b43bddcb5f188f68322513b6fc9e3",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2205",
       "triggerID" : "918915683",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "82c5783f99eccbb5728658ad2c91e7d36e51280a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "82c5783f99eccbb5728658ad2c91e7d36e51280a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 188523ea282b43bddcb5f188f68322513b6fc9e3 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2203) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2205) 
   * 82c5783f99eccbb5728658ad2c91e7d36e51280a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3652: [HUDI-2423] Breakdown HoodieMetricsConfig into HoodieMetricsGraphiteConfig、HoodieMetricsJmxConfig

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3652:
URL: https://github.com/apache/hudi/pull/3652#issuecomment-917936364


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d56d7168748f63e71d8ce5b28d46d31b8a5eb92d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2183",
       "triggerID" : "d56d7168748f63e71d8ce5b28d46d31b8a5eb92d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2185",
       "triggerID" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2189",
       "triggerID" : "918219181",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2192",
       "triggerID" : "918277232",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "188523ea282b43bddcb5f188f68322513b6fc9e3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2203",
       "triggerID" : "188523ea282b43bddcb5f188f68322513b6fc9e3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "188523ea282b43bddcb5f188f68322513b6fc9e3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2205",
       "triggerID" : "918915683",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "82c5783f99eccbb5728658ad2c91e7d36e51280a",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2229",
       "triggerID" : "82c5783f99eccbb5728658ad2c91e7d36e51280a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "82c5783f99eccbb5728658ad2c91e7d36e51280a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2237",
       "triggerID" : "919862538",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 82c5783f99eccbb5728658ad2c91e7d36e51280a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2229) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2237) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3652: [HUDI-2423] Breakdown HoodieMetricsConfig into HoodieMetricsGraphiteConfig、HoodieMetricsJmxConfig

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3652:
URL: https://github.com/apache/hudi/pull/3652#issuecomment-917936364


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d56d7168748f63e71d8ce5b28d46d31b8a5eb92d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2183",
       "triggerID" : "d56d7168748f63e71d8ce5b28d46d31b8a5eb92d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2185",
       "triggerID" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2189",
       "triggerID" : "918219181",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2192",
       "triggerID" : "918277232",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "188523ea282b43bddcb5f188f68322513b6fc9e3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2203",
       "triggerID" : "188523ea282b43bddcb5f188f68322513b6fc9e3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "188523ea282b43bddcb5f188f68322513b6fc9e3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2205",
       "triggerID" : "918915683",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "82c5783f99eccbb5728658ad2c91e7d36e51280a",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2229",
       "triggerID" : "82c5783f99eccbb5728658ad2c91e7d36e51280a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 82c5783f99eccbb5728658ad2c91e7d36e51280a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2229) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3652: [HUDI-2423] Breakdown HoodieMetricsConfig into HoodieMetricsGraphiteConfig、HoodieMetricsJmxConfig

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3652:
URL: https://github.com/apache/hudi/pull/3652#issuecomment-917936364


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d56d7168748f63e71d8ce5b28d46d31b8a5eb92d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2183",
       "triggerID" : "d56d7168748f63e71d8ce5b28d46d31b8a5eb92d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2185",
       "triggerID" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2189",
       "triggerID" : "918219181",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2192",
       "triggerID" : "918277232",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "188523ea282b43bddcb5f188f68322513b6fc9e3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2203",
       "triggerID" : "188523ea282b43bddcb5f188f68322513b6fc9e3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "188523ea282b43bddcb5f188f68322513b6fc9e3",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2205",
       "triggerID" : "918915683",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "82c5783f99eccbb5728658ad2c91e7d36e51280a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2229",
       "triggerID" : "82c5783f99eccbb5728658ad2c91e7d36e51280a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 188523ea282b43bddcb5f188f68322513b6fc9e3 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2203) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2205) 
   * 82c5783f99eccbb5728658ad2c91e7d36e51280a Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2229) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3652: [HUDI-2423] Breakdown HoodieMetricsConfig into HoodieMetricsGraphiteConfig

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3652:
URL: https://github.com/apache/hudi/pull/3652#issuecomment-917936364


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d56d7168748f63e71d8ce5b28d46d31b8a5eb92d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2183",
       "triggerID" : "d56d7168748f63e71d8ce5b28d46d31b8a5eb92d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2185",
       "triggerID" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2189",
       "triggerID" : "918219181",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 5a2aed9baf58604d489104ca6fb3750643f0e984 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2185) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2189) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] liujinhui1994 commented on pull request #3652: [HUDI-2423] Breakdown HoodieMetricsConfig into HoodieMetricsGraphiteConfig

Posted by GitBox <gi...@apache.org>.
liujinhui1994 commented on pull request #3652:
URL: https://github.com/apache/hudi/pull/3652#issuecomment-918915683


   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3652: [HUDI-2423] Breakdown HoodieMetricsConfig into HoodieMetricsGraphiteConfig

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3652:
URL: https://github.com/apache/hudi/pull/3652#issuecomment-917936364


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d56d7168748f63e71d8ce5b28d46d31b8a5eb92d",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2183",
       "triggerID" : "d56d7168748f63e71d8ce5b28d46d31b8a5eb92d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2185",
       "triggerID" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d56d7168748f63e71d8ce5b28d46d31b8a5eb92d Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2183) 
   * 5a2aed9baf58604d489104ca6fb3750643f0e984 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2185) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3652: [HUDI-2423] Breakdown HoodieMetricsConfig into HoodieMetricsGraphiteConfig

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3652:
URL: https://github.com/apache/hudi/pull/3652#issuecomment-917936364


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d56d7168748f63e71d8ce5b28d46d31b8a5eb92d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2183",
       "triggerID" : "d56d7168748f63e71d8ce5b28d46d31b8a5eb92d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d56d7168748f63e71d8ce5b28d46d31b8a5eb92d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2183) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3652: [HUDI-2423] Breakdown HoodieMetricsConfig into HoodieMetricsGraphiteConfig

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3652:
URL: https://github.com/apache/hudi/pull/3652#issuecomment-917936364


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d56d7168748f63e71d8ce5b28d46d31b8a5eb92d",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2183",
       "triggerID" : "d56d7168748f63e71d8ce5b28d46d31b8a5eb92d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d56d7168748f63e71d8ce5b28d46d31b8a5eb92d Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2183) 
   * 5a2aed9baf58604d489104ca6fb3750643f0e984 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3652: [HUDI-2423] Breakdown HoodieMetricsConfig into HoodieMetricsGraphiteConfig

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3652:
URL: https://github.com/apache/hudi/pull/3652#issuecomment-917936364


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d56d7168748f63e71d8ce5b28d46d31b8a5eb92d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2183",
       "triggerID" : "d56d7168748f63e71d8ce5b28d46d31b8a5eb92d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2185",
       "triggerID" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2189",
       "triggerID" : "918219181",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2192",
       "triggerID" : "918277232",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "188523ea282b43bddcb5f188f68322513b6fc9e3",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "188523ea282b43bddcb5f188f68322513b6fc9e3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5a2aed9baf58604d489104ca6fb3750643f0e984 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2185) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2189) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2192) 
   * 188523ea282b43bddcb5f188f68322513b6fc9e3 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3652: [HUDI-2423] Breakdown HoodieMetricsConfig into HoodieMetricsGraphiteConfig

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3652:
URL: https://github.com/apache/hudi/pull/3652#issuecomment-917936364


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d56d7168748f63e71d8ce5b28d46d31b8a5eb92d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2183",
       "triggerID" : "d56d7168748f63e71d8ce5b28d46d31b8a5eb92d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2185",
       "triggerID" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2189",
       "triggerID" : "918219181",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2192",
       "triggerID" : "918277232",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "188523ea282b43bddcb5f188f68322513b6fc9e3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2203",
       "triggerID" : "188523ea282b43bddcb5f188f68322513b6fc9e3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 188523ea282b43bddcb5f188f68322513b6fc9e3 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2203) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] liujinhui1994 commented on pull request #3652: [HUDI-2423] Breakdown HoodieMetricsConfig into HoodieMetricsGraphiteConfig

Posted by GitBox <gi...@apache.org>.
liujinhui1994 commented on pull request #3652:
URL: https://github.com/apache/hudi/pull/3652#issuecomment-918277232


   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3652: [HUDI-2423] Breakdown HoodieMetricsConfig into HoodieMetricsGraphiteConfig

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3652:
URL: https://github.com/apache/hudi/pull/3652#issuecomment-917936364


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d56d7168748f63e71d8ce5b28d46d31b8a5eb92d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2183",
       "triggerID" : "d56d7168748f63e71d8ce5b28d46d31b8a5eb92d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2185",
       "triggerID" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2189",
       "triggerID" : "918219181",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "5a2aed9baf58604d489104ca6fb3750643f0e984",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2192",
       "triggerID" : "918277232",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "188523ea282b43bddcb5f188f68322513b6fc9e3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2203",
       "triggerID" : "188523ea282b43bddcb5f188f68322513b6fc9e3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5a2aed9baf58604d489104ca6fb3750643f0e984 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2185) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2189) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2192) 
   * 188523ea282b43bddcb5f188f68322513b6fc9e3 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2203) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] yanghua commented on pull request #3652: [HUDI-2423] Breakdown HoodieMetricsConfig into HoodieMetricsGraphiteConfig、HoodieMetricsJmxConfig

Posted by GitBox <gi...@apache.org>.
yanghua commented on pull request #3652:
URL: https://github.com/apache/hudi/pull/3652#issuecomment-919914225


   Will review it later


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org