You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Jörg Schaible <jo...@scalaris.com> on 2011/03/02 13:17:56 UTC

Re: svn commit: r1076181 - in /commons/sandbox/digester3/trunk/src/main/java/org/apache/commons/digester3: Digester.java internal/DigesterImpl.java rule/CallMethodRule.java rule/CallParamRule.java rule/ObjectParamRule.java rule/PathCallParamRule.java

Hi Simon,

simonetripodi@apache.org wrote:

[snip]

> @@ -335,7 +335,7 @@ public interface Digester extends Conten
>       *
>       * @param object The new object
>       */
> -    void pushParams(Object object);
> +    void pushParams(Object[] object);
>  
>      /**
>       * <p>Pop the top object off of the parameters stack, and return it. 
>       If there are

[snip]

> @@ -423,7 +423,7 @@ public final class DigesterImpl implemen
>      /**
>       * {@inheritDoc}
>       */
> -    public void pushParams(Object object) {
> +    public void pushParams(Object[] object) {
>          if (this.log.isTraceEnabled()) {
>              this.log.trace("Pushing params");
>          }

[snip]

Good candidates for varargs ... :-)

- Jörg


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: svn commit: r1076181 - in /commons/sandbox/digester3/trunk/src/main/java/org/apache/commons/digester3: Digester.java internal/DigesterImpl.java rule/CallMethodRule.java rule/CallParamRule.java rule/ObjectParamRule.java rule/PathCallParamRule.java

Posted by Simone Tripodi <si...@apache.org>.
Hi Jorg,
indeed, thanks for your feedback, very appreciated!
Have a nice day,
Simo

http://people.apache.org/~simonetripodi/
http://www.99soft.org/



On Wed, Mar 2, 2011 at 1:17 PM, Jörg Schaible
<jo...@scalaris.com> wrote:
> Hi Simon,
>
> simonetripodi@apache.org wrote:
>
> [snip]
>
>> @@ -335,7 +335,7 @@ public interface Digester extends Conten
>>       *
>>       * @param object The new object
>>       */
>> -    void pushParams(Object object);
>> +    void pushParams(Object[] object);
>>
>>      /**
>>       * <p>Pop the top object off of the parameters stack, and return it.
>>       If there are
>
> [snip]
>
>> @@ -423,7 +423,7 @@ public final class DigesterImpl implemen
>>      /**
>>       * {@inheritDoc}
>>       */
>> -    public void pushParams(Object object) {
>> +    public void pushParams(Object[] object) {
>>          if (this.log.isTraceEnabled()) {
>>              this.log.trace("Pushing params");
>>          }
>
> [snip]
>
> Good candidates for varargs ... :-)
>
> - Jörg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org