You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/06/24 20:54:45 UTC
Review Request 22942: Add test coverage for ResourceCounter.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22942/
-----------------------------------------------------------
Review request for Aurora, David McLaughlin and Maxim Khutornenko.
Repository: aurora
Description
-------
This brings ResourceCounter to 100% instruction coverage.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/http/Utilization.java 06dc846ae091be28c6b4269c21a8c50ccf9be098
src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java 60dfc56d41179813d622b4ef23659e4a114457cd
src/test/java/org/apache/aurora/scheduler/stats/ResourceCounterTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/22942/diff/
Testing
-------
$ ./gradlew clean build -Pq
Thanks,
Bill Farner
Re: Review Request 22942: Add test coverage for ResourceCounter.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22942/#review46599
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On June 24, 2014, 6:54 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22942/
> -----------------------------------------------------------
>
> (Updated June 24, 2014, 6:54 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This brings ResourceCounter to 100% instruction coverage.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/Utilization.java 06dc846ae091be28c6b4269c21a8c50ccf9be098
> src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java 60dfc56d41179813d622b4ef23659e4a114457cd
> src/test/java/org/apache/aurora/scheduler/stats/ResourceCounterTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/22942/diff/
>
>
> Testing
> -------
>
> $ ./gradlew clean build -Pq
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 22942: Add test coverage for ResourceCounter.
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22942/#review46588
-----------------------------------------------------------
Ship it!
Ship It!
- David McLaughlin
On June 24, 2014, 6:54 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22942/
> -----------------------------------------------------------
>
> (Updated June 24, 2014, 6:54 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This brings ResourceCounter to 100% instruction coverage.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/Utilization.java 06dc846ae091be28c6b4269c21a8c50ccf9be098
> src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java 60dfc56d41179813d622b4ef23659e4a114457cd
> src/test/java/org/apache/aurora/scheduler/stats/ResourceCounterTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/22942/diff/
>
>
> Testing
> -------
>
> $ ./gradlew clean build -Pq
>
>
> Thanks,
>
> Bill Farner
>
>