You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/10/27 23:58:05 UTC

[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #19401: Python Custom op infer shape large tensor fix (v1.x)

Zha0q1 commented on pull request #19401:
URL: https://github.com/apache/incubator-mxnet/pull/19401#issuecomment-717609436


   > > @samskalicky Does the c++ custom op use the same custom op c api?
   > > https://github.com/apache/incubator-mxnet/blob/bc887c0827913634cb67060f940916e8d714fe31/include/mxnet/c_api.h#L189
   > 
   > No, its a totally different path for C++ CustomOps. Heres where C++ CustomOps are defined:
   > 
   > https://github.com/apache/incubator-mxnet/blob/f9bdf34370cdc53a66d1aaa90eb74aa8cdb8fd7a/src/c_api/c_api.cc#L137-L138
   > 
   > We already use int64_t for the shapes there
   > 
   > I renamed this PR "Python Custom op" to disambiguate now that we have lots of different custom ops in MXNet.
   
   Sounds good thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org