You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "HappenLee (via GitHub)" <gi...@apache.org> on 2026/03/03 12:07:58 UTC

[PR] [feat](hll) add to_hll(bigint) scalar function [doris]

HappenLee opened a new pull request, #60996:
URL: https://github.com/apache/doris/pull/60996

   Add a new built-in scalar function to_hll(bigint) that constructs an HLL value from a BIGINT directly, bypassing any hash — the bigint is fed as-is into HyperLogLog::update(uint64_t).
   
   Changes:
   - BE (vec/functions/function_hll.cpp): implement struct ToHll with Status-returning execute/vector/vector_nullable methods; register as FunctionAlwaysNotNullable<ToHll, true> so InvalidArgument status is propagated on negative input.
   - BE test (be/test/vec/function/function_hll_test.cpp): add unit test function_hll_test.function_to_hll_test covering values 0, 1, 2, 100.
   - FE Nereids (scalar/ToHll.java): new ScalarFunction with signature BIGINT -> HLL.
   - FE catalog (BuiltinScalarFunctions.java): register to_hll.
   - FE visitor (ScalarFunctionVisitor.java): add visitToHll visitor hook.
   
   ### What problem does this PR solve?
   
   Issue Number: close #xxx
   
   Related PR: #xxx
   
   Problem Summary:
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test <!-- At least one of them must be included. -->
       - [ ] Regression test
       - [x] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason <!-- Add your reason?  -->
   
   - Behavior changed:
       - [ ] No.
       - [ ] Yes. <!-- Explain the behavior change -->
   
   - Does this need documentation?
       - [ ] No.
       - [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](storage) add read_null_map support for COUNT_NULL push down aggregate [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-4044128992

   # FE UT Coverage Report
   Increment line coverage `  70.00% (28/40)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60996_1193ea77d2cdee00a96155833c71a084d1e05e07/fe_increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60996_1193ea77d2cdee00a96155833c71a084d1e05e07/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](storage) add read_null_map support for COUNT_NULL push down aggregate [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-4053079910

   # BE UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/e944dd4a165faace2722f6391e8ddf0eec31fc6f_e944dd4a165faace2722f6391e8ddf0eec31fc6f/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/e944dd4a165faace2722f6391e8ddf0eec31fc6f_e944dd4a165faace2722f6391e8ddf0eec31fc6f/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 52.65% (19709/37434) |
   | Line Coverage     | 36.23% (184167/508316) |
   | Region Coverage   | 32.39% (142357/439528) |
   | Branch Coverage   | 33.56% (62176/185259) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](storage) add read_null_map support for COUNT_NULL push down aggregate [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-4053299759

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/4cd38b5c5bf6c82a58e54deb9a98a87a62eeb195_4cd38b5c5bf6c82a58e54deb9a98a87a62eeb195_cloud/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/4cd38b5c5bf6c82a58e54deb9a98a87a62eeb195_4cd38b5c5bf6c82a58e54deb9a98a87a62eeb195_cloud/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 79.24% (1798/2269) |
   | Line Coverage     | 64.53% (32280/50026) |
   | Region Coverage   | 65.44% (16166/24702) |
   | Branch Coverage   | 55.86% (8611/15416) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](hll) add to_hll(bigint) scalar function [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-3996569516

   # BE Regression && UT Coverage Report
   Increment line coverage `70.00% (21/30)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60996_cbea9552a1c1b59c015a9b22f7676dc7a3f2a5a8_merge/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60996_cbea9552a1c1b59c015a9b22f7676dc7a3f2a5a8_merge/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 73.35% (26832/36583) |
   | Line Coverage     | 56.61% (285955/505138) |
   | Region Coverage   | 54.05% (238882/442005) |
   | Branch Coverage   | 55.68% (103045/185056) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](hll) add to_hll(bigint) scalar function [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-3995284257

   # BE Regression && UT Coverage Report
   Increment line coverage `70.00% (21/30)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60996_cbea9552a1c1b59c015a9b22f7676dc7a3f2a5a8_merge/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60996_cbea9552a1c1b59c015a9b22f7676dc7a3f2a5a8_merge/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 73.36% (26837/36583) |
   | Line Coverage     | 56.63% (286073/505138) |
   | Region Coverage   | 54.07% (238973/442005) |
   | Branch Coverage   | 55.71% (103098/185056) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](hll) add to_hll(bigint) scalar function [doris]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #60996:
URL: https://github.com/apache/doris/pull/60996#discussion_r2877915252


##########
be/src/vec/functions/function_hll.cpp:
##########
@@ -259,6 +259,47 @@ struct HLLHash {
     }
 };
 
+struct ToHll {
+    static constexpr auto name = "to_hll";
+
+    using ReturnType = DataTypeHLL;
+    template <typename ColumnType>
+    static Status vector(const ColumnType* col, MutableColumnPtr& col_res) {
+        return execute<ColumnType, false>(col, nullptr, col_res);
+    }
+    template <typename ColumnType>
+    static Status vector_nullable(const ColumnType* col, const NullMap& nullmap,
+                                  MutableColumnPtr& col_res) {
+        return execute<ColumnType, true>(col, &nullmap, col_res);
+    }
+    template <typename ColumnType, bool arg_is_nullable>
+    static Status execute(const ColumnType* col, const NullMap* nullmap,
+                          MutableColumnPtr& col_res) {
+        if constexpr (std::is_same_v<ColumnType, ColumnInt64>) {
+            auto* res_column = reinterpret_cast<ColumnHLL*>(col_res.get());
+            auto& res_data = res_column->get_data();
+            size_t size = col->size();
+            const auto& data = col->get_data();
+
+            for (size_t i = 0; i < size; ++i) {
+                if (arg_is_nullable && (*nullmap)[i]) {
+                    continue;
+                } else {
+                    int64_t value = data[i];
+                    if (value < 0) {
+                        return Status::InvalidArgument(
+                                "to_hll does not support negative bigint value: {}", value);
+                    }
+                    res_data[i].update(static_cast<uint64_t>(value));
+                }

Review Comment:
   In the non-nullable instantiation, `nullmap` is passed as `nullptr`, but the loop still references `(*nullmap)[i]` inside a normal `if` condition. While short-circuiting avoids evaluation when `arg_is_nullable` is `false`, rewriting this as an `if constexpr (arg_is_nullable)` block (or splitting nullable/non-nullable loops) avoids relying on that subtlety and keeps static analyzers/sanitizers from flagging a potential null dereference.
   ```suggestion
                   if constexpr (arg_is_nullable) {
                       if ((*nullmap)[i]) {
                           continue;
                       }
                   }
                   int64_t value = data[i];
                   if (value < 0) {
                       return Status::InvalidArgument(
                               "to_hll does not support negative bigint value: {}", value);
                   }
                   res_data[i].update(static_cast<uint64_t>(value));
   ```



##########
be/test/vec/function/function_hll_test.cpp:
##########
@@ -133,4 +133,25 @@ TEST(function_hll_test, function_hll_from_base64_test) {
 
     static_cast<void>(check_function<DataTypeHLL, true>(func_name, input_types, data_set));
 }
+
+TEST(function_hll_test, function_to_hll_test) {
+    std::string func_name = "to_hll";
+    InputTypeSet input_types = {PrimitiveType::TYPE_BIGINT};
+
+    HyperLogLog hll1;
+    hll1.update(1);
+    HyperLogLog hll2;
+    hll2.update(2);
+    HyperLogLog hll3;
+    hll3.update(100);
+    HyperLogLog hll4;
+    hll4.update(0);
+
+    DataSet data_set = {{{(int64_t)1}, &hll1},
+                        {{(int64_t)2}, &hll2},
+                        {{(int64_t)100}, &hll3},
+                        {{(int64_t)0}, &hll4}};
+
+    static_cast<void>(check_function<DataTypeHLL>(func_name, input_types, data_set));
+}

Review Comment:
   The new `to_hll` behavior has an explicit error path for negative BIGINT values (returns `Status::InvalidArgument`) and a special null-handling path (skips update and returns a default/empty HLL). The unit test currently only covers a few positive values; please add coverage for at least one negative input (expect execute failure) and a NULL input row (verify it returns an empty HLL rather than NULL).
   ```suggestion
       HyperLogLog empty_hll;
   
       DataSet data_set = {{{(int64_t)1}, &hll1},
                           {{(int64_t)2}, &hll2},
                           {{(int64_t)100}, &hll3},
                           {{(int64_t)0}, &hll4},
                           {{Null()}, &empty_hll}};
   
       static_cast<void>(check_function<DataTypeHLL, true>(func_name, input_types, data_set));
   }
   
   TEST(function_hll_test, function_to_hll_negative_input_test) {
       std::string func_name = "to_hll";
       InputTypeSet input_types = {PrimitiveType::TYPE_BIGINT};
   
       HyperLogLog dummy_hll;
   
       // Negative BIGINT input should cause function execution to fail.
       DataSet data_set = {{{(int64_t)-1}, &dummy_hll}};
   
       EXPECT_FALSE(check_function<DataTypeHLL>(func_name, input_types, data_set));
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](storage) add read_null_map support for COUNT_NULL push down aggregate [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-4043967579

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/1193ea77d2cdee00a96155833c71a084d1e05e07_1193ea77d2cdee00a96155833c71a084d1e05e07_cloud/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/1193ea77d2cdee00a96155833c71a084d1e05e07_1193ea77d2cdee00a96155833c71a084d1e05e07_cloud/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 79.31% (1798/2267) |
   | Line Coverage     | 64.67% (32301/49944) |
   | Region Coverage   | 65.58% (16172/24659) |
   | Branch Coverage   | 56.02% (8621/15388) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](hll) add to_hll(bigint) scalar function [doris]

Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-3997040814

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](hll) add to_hll(bigint) scalar function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-3997310972

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 184251 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 644a371416e33ab20451719fcd53eb467923cef9, data reload: false
   
   query5	4651	651	510	510
   query6	329	211	196	196
   query7	4218	466	266	266
   query8	346	251	231	231
   query9	8801	2749	2692	2692
   query10	513	395	338	338
   query11	17048	17816	17338	17338
   query12	209	134	134	134
   query13	1325	480	379	379
   query14	7381	3418	2991	2991
   query14_1	2949	2942	3034	2942
   query15	210	206	183	183
   query16	1008	465	462	462
   query17	1301	749	607	607
   query18	4031	437	334	334
   query19	215	206	178	178
   query20	141	131	133	131
   query21	221	162	132	132
   query22	5813	5232	5053	5053
   query23	17126	16798	16660	16660
   query23_1	16773	16632	16692	16632
   query24	7057	1638	1255	1255
   query24_1	1248	1240	1226	1226
   query25	550	478	393	393
   query26	1222	255	156	156
   query27	2751	465	293	293
   query28	4498	1854	1864	1854
   query29	797	554	467	467
   query30	312	245	209	209
   query31	876	730	633	633
   query32	80	67	78	67
   query33	519	331	279	279
   query34	908	910	561	561
   query35	630	676	591	591
   query36	1087	1133	1014	1014
   query37	135	95	84	84
   query38	2995	2913	2932	2913
   query39	1001	847	855	847
   query39_1	819	825	825	825
   query40	235	150	133	133
   query41	61	60	60	60
   query42	104	102	101	101
   query43	364	374	346	346
   query44	
   query45	199	188	182	182
   query46	871	978	617	617
   query47	2109	2166	2060	2060
   query48	318	318	232	232
   query49	624	456	414	414
   query50	683	288	217	217
   query51	4074	4111	4097	4097
   query52	107	111	98	98
   query53	290	340	279	279
   query54	294	270	258	258
   query55	92	84	82	82
   query56	329	304	298	298
   query57	1367	1349	1264	1264
   query58	299	282	272	272
   query59	2611	2669	2527	2527
   query60	335	336	327	327
   query61	150	138	151	138
   query62	636	588	547	547
   query63	312	277	275	275
   query64	4838	1255	969	969
   query65	
   query66	1389	455	349	349
   query67	16430	16387	16386	16386
   query68	
   query69	393	302	279	279
   query70	960	981	944	944
   query71	348	315	299	299
   query72	2707	2834	2445	2445
   query73	551	540	321	321
   query74	10019	9962	9743	9743
   query75	2838	2745	2477	2477
   query76	2284	1029	664	664
   query77	386	413	314	314
   query78	11114	11269	10681	10681
   query79	2989	800	596	596
   query80	1762	639	566	566
   query81	561	290	248	248
   query82	987	151	118	118
   query83	344	274	249	249
   query84	257	134	106	106
   query85	978	550	518	518
   query86	408	301	328	301
   query87	3092	3078	3017	3017
   query88	3542	2675	2648	2648
   query89	440	363	349	349
   query90	1894	180	175	175
   query91	173	174	149	149
   query92	81	79	78	78
   query93	1190	840	510	510
   query94	643	345	282	282
   query95	585	400	315	315
   query96	647	512	226	226
   query97	2457	2467	2464	2464
   query98	234	220	210	210
   query99	1008	997	913	913
   Total cold run time: 258426 ms
   Total hot run time: 184251 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](storage) add read_null_map support for COUNT_NULL push down aggregate [doris]

Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt merged PR #60996:
URL: https://github.com/apache/doris/pull/60996


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](hll) add to_hll(bigint) scalar function [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-3994994375

   # BE UT Coverage Report
   Increment line coverage `70.00% (21/30)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/cbea9552a1c1b59c015a9b22f7676dc7a3f2a5a8_cbea9552a1c1b59c015a9b22f7676dc7a3f2a5a8/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/cbea9552a1c1b59c015a9b22f7676dc7a3f2a5a8_cbea9552a1c1b59c015a9b22f7676dc7a3f2a5a8/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 52.61% (19657/37361) |
   | Line Coverage     | 36.21% (183489/506691) |
   | Region Coverage   | 32.51% (142336/437868) |
   | Branch Coverage   | 33.47% (61747/184492) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](storage) add read_null_map support for COUNT_NULL push down aggregate [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-4052250646

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/e944dd4a165faace2722f6391e8ddf0eec31fc6f_e944dd4a165faace2722f6391e8ddf0eec31fc6f_cloud/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/e944dd4a165faace2722f6391e8ddf0eec31fc6f_e944dd4a165faace2722f6391e8ddf0eec31fc6f_cloud/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 79.24% (1798/2269) |
   | Line Coverage     | 64.51% (32272/50026) |
   | Region Coverage   | 65.39% (16153/24702) |
   | Branch Coverage   | 55.86% (8612/15416) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](hll) add to_hll(bigint) scalar function [doris]

Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-3990742977

   run buidall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](storage) add read_null_map support for COUNT_NULL push down aggregate [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-4039130792

   # FE UT Coverage Report
   Increment line coverage `  70.00% (28/40)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60996_113bcd8f85b16b6553a51613bc160812198867ac/fe_increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60996_113bcd8f85b16b6553a51613bc160812198867ac/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](hll) add to_hll(bigint) scalar function [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-3998430923

   # BE Regression && UT Coverage Report
   Increment line coverage `83.87% (26/31)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60996_697bd4d9548658b747f0762d9c258b127e1ec128_merge/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60996_697bd4d9548658b747f0762d9c258b127e1ec128_merge/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 73.27% (26820/36604) |
   | Line Coverage     | 56.59% (286006/505432) |
   | Region Coverage   | 54.05% (239014/442239) |
   | Branch Coverage   | 55.61% (103005/185219) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](storage) add read_null_map support for COUNT_NULL push down aggregate [doris]

Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-4052362237

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](storage) add read_null_map support for COUNT_NULL push down aggregate [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-4044318988

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 28010 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 1193ea77d2cdee00a96155833c71a084d1e05e07, data reload: false
   
   ------ Round 1 ----------------------------------
   ============================================
   q1	17635	4435	4304	4304
   q2	q3	10740	815	529	529
   q4	4743	371	248	248
   q5	8232	1221	1025	1025
   q6	244	176	145	145
   q7	822	840	676	676
   q8	10935	1504	1346	1346
   q9	6679	4950	4734	4734
   q10	6544	1954	1764	1764
   q11	479	263	246	246
   q12	747	581	466	466
   q13	18096	2931	2194	2194
   q14	231	230	215	215
   q15	957	791	842	791
   q16	736	742	714	714
   q17	704	857	420	420
   q18	6299	5365	5347	5347
   q19	1130	1006	614	614
   q20	497	513	432	432
   q21	4604	1912	1530	1530
   q22	349	325	270	270
   Total cold run time: 101403 ms
   Total hot run time: 28010 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   ============================================
   q1	4776	4678	4615	4615
   q2	q3	3985	4325	3800	3800
   q4	872	1189	813	813
   q5	4074	4408	4313	4313
   q6	184	175	136	136
   q7	1732	1643	1525	1525
   q8	2515	2762	2602	2602
   q9	7602	7363	7498	7363
   q10	3749	4021	3701	3701
   q11	522	481	435	435
   q12	507	598	452	452
   q13	2851	3203	2267	2267
   q14	282	295	275	275
   q15	852	826	804	804
   q16	743	755	724	724
   q17	1192	1442	1359	1359
   q18	7220	6900	6993	6900
   q19	866	857	905	857
   q20	2100	2201	1993	1993
   q21	3970	3469	3349	3349
   q22	450	425	382	382
   Total cold run time: 51044 ms
   Total hot run time: 48665 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](storage) add read_null_map support for COUNT_NULL push down aggregate [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-4048716801

   # BE Regression && UT Coverage Report
   Increment line coverage `100% (0/0)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60996_dce35cb8c7f83be72faab2407ecf6f50d768989b_merge/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60996_dce35cb8c7f83be72faab2407ecf6f50d768989b_merge/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 71.60% (26233/36637) |
   | Line Coverage     | 54.36% (275368/506521) |
   | Region Coverage   | 51.47% (228212/443383) |
   | Branch Coverage   | 52.94% (98296/185665) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](hll) add to_hll(bigint) scalar function [doris]

Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-3990592716

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](storage) add read_null_map support for COUNT_NULL push down aggregate [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-4052605849

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 27913 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit e944dd4a165faace2722f6391e8ddf0eec31fc6f, data reload: false
   
   ------ Round 1 ----------------------------------
   ============================================
   q1	17710	4557	4465	4465
   q2	q3	10725	815	525	525
   q4	4720	384	258	258
   q5	8106	1205	1030	1030
   q6	217	186	145	145
   q7	821	863	670	670
   q8	10429	1483	1357	1357
   q9	6753	4756	4757	4756
   q10	6298	1931	1653	1653
   q11	465	269	248	248
   q12	702	580	479	479
   q13	18059	2958	2172	2172
   q14	234	236	228	228
   q15	962	818	826	818
   q16	779	725	660	660
   q17	729	882	409	409
   q18	6065	5389	5221	5221
   q19	1109	1010	626	626
   q20	503	492	394	394
   q21	4420	1975	1522	1522
   q22	392	315	277	277
   Total cold run time: 100198 ms
   Total hot run time: 27913 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   ============================================
   q1	4573	4563	4549	4549
   q2	q3	3876	4308	3868	3868
   q4	905	1201	793	793
   q5	4077	4533	4454	4454
   q6	210	180	145	145
   q7	1805	1674	1505	1505
   q8	2543	2730	2565	2565
   q9	7529	7481	7414	7414
   q10	3832	4018	3615	3615
   q11	502	430	428	428
   q12	483	590	458	458
   q13	2860	3289	2333	2333
   q14	307	322	280	280
   q15	836	798	853	798
   q16	721	771	733	733
   q17	1219	1503	1508	1503
   q18	7273	7075	6698	6698
   q19	905	908	961	908
   q20	2170	2187	2036	2036
   q21	4046	3511	3315	3315
   q22	441	415	365	365
   Total cold run time: 51113 ms
   Total hot run time: 48763 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](storage) add read_null_map support for COUNT_NULL push down aggregate [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-4052671514

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 153454 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit e944dd4a165faace2722f6391e8ddf0eec31fc6f, data reload: false
   
   query5	4342	668	542	542
   query6	317	222	216	216
   query7	4211	484	269	269
   query8	334	245	230	230
   query9	8702	2715	2718	2715
   query10	504	387	341	341
   query11	7516	5860	5627	5627
   query12	186	135	121	121
   query13	1268	461	351	351
   query14	5704	3830	3614	3614
   query14_1	2872	2833	2845	2833
   query15	200	199	173	173
   query16	986	477	468	468
   query17	891	729	609	609
   query18	2441	460	355	355
   query19	214	217	187	187
   query20	137	137	133	133
   query21	227	149	121	121
   query22	4876	4993	4822	4822
   query23	15995	15626	15399	15399
   query23_1	15559	16107	15972	15972
   query24	7983	1743	1274	1274
   query24_1	1258	1348	1292	1292
   query25	612	531	473	473
   query26	1327	301	165	165
   query27	3357	503	305	305
   query28	4772	1961	1914	1914
   query29	896	673	517	517
   query30	327	281	230	230
   query31	1644	1379	1290	1290
   query32	84	72	75	72
   query33	514	358	294	294
   query34	1023	1013	597	597
   query35	680	671	609	609
   query36	1073	1110	988	988
   query37	133	97	88	88
   query38	3011	2909	2856	2856
   query39	877	892	834	834
   query39_1	816	834	836	834
   query40	231	151	136	136
   query41	63	62	58	58
   query42	306	312	291	291
   query43	243	251	221	221
   query44	
   query45	206	191	192	191
   query46	883	1007	610	610
   query47	2114	2098	2040	2040
   query48	326	317	241	241
   query49	663	466	383	383
   query50	690	277	220	220
   query51	4112	4053	4056	4053
   query52	287	294	277	277
   query53	299	337	285	285
   query54	307	278	290	278
   query55	94	96	81	81
   query56	313	321	313	313
   query57	1350	1342	1277	1277
   query58	285	278	278	278
   query59	1336	1463	1263	1263
   query60	340	347	327	327
   query61	147	142	144	142
   query62	634	598	552	552
   query63	320	281	273	273
   query64	4994	1284	1001	1001
   query65	
   query66	1453	467	381	381
   query67	16336	16428	16388	16388
   query68	
   query69	381	317	289	289
   query70	1029	987	960	960
   query71	344	315	297	297
   query72	2850	2801	2473	2473
   query73	568	608	321	321
   query74	9944	9923	9760	9760
   query75	2847	2812	2458	2458
   query76	2289	1051	678	678
   query77	362	388	308	308
   query78	11115	11301	10676	10676
   query79	3038	814	601	601
   query80	1750	617	541	541
   query81	588	283	245	245
   query82	985	150	119	119
   query83	338	267	250	250
   query84	304	120	92	92
   query85	883	475	437	437
   query86	488	331	306	306
   query87	3128	3109	2989	2989
   query88	3625	2688	2655	2655
   query89	422	376	348	348
   query90	2076	185	186	185
   query91	165	160	138	138
   query92	95	79	73	73
   query93	1646	838	506	506
   query94	654	318	314	314
   query95	591	406	324	324
   query96	649	526	232	232
   query97	2474	2445	2425	2425
   query98	232	219	216	216
   query99	999	971	941	941
   Total cold run time: 237948 ms
   Total hot run time: 153454 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](storage) add read_null_map support for COUNT_NULL push down aggregate [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-4047588737

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 27752 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit dce35cb8c7f83be72faab2407ecf6f50d768989b, data reload: false
   
   ------ Round 1 ----------------------------------
   ============================================
   q1	17678	4460	4364	4364
   q2	q3	10736	835	529	529
   q4	4750	384	257	257
   q5	8187	1210	1036	1036
   q6	239	174	143	143
   q7	824	841	668	668
   q8	10814	1481	1356	1356
   q9	6943	4732	4736	4732
   q10	6333	1929	1696	1696
   q11	470	273	236	236
   q12	706	572	465	465
   q13	18055	3018	2185	2185
   q14	233	227	225	225
   q15	932	800	825	800
   q16	741	722	701	701
   q17	730	865	433	433
   q18	6401	5409	5217	5217
   q19	1122	1007	616	616
   q20	496	496	394	394
   q21	4627	1923	1442	1442
   q22	370	327	257	257
   Total cold run time: 101387 ms
   Total hot run time: 27752 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   ============================================
   q1	4589	4554	4651	4554
   q2	q3	3869	4447	3865	3865
   q4	894	1235	787	787
   q5	4075	4388	4347	4347
   q6	183	177	142	142
   q7	1735	1677	1597	1597
   q8	2477	2742	2634	2634
   q9	7716	7466	7579	7466
   q10	3771	3960	3577	3577
   q11	515	426	414	414
   q12	479	580	444	444
   q13	2687	3320	2428	2428
   q14	291	308	291	291
   q15	874	804	813	804
   q16	729	778	720	720
   q17	1125	1451	1405	1405
   q18	7227	6778	6552	6552
   q19	943	886	897	886
   q20	2056	2225	2020	2020
   q21	3977	3519	3327	3327
   q22	466	438	384	384
   Total cold run time: 50678 ms
   Total hot run time: 48644 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](storage) add read_null_map support for COUNT_NULL push down aggregate [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-4059631491

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](hll) add to_hll(bigint) scalar function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-3991274475

   # BE UT Coverage Report
   Increment line coverage `70.00% (21/30)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/b57dd74a960c5ba2bacefe818681755e22808d15_b57dd74a960c5ba2bacefe818681755e22808d15/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/b57dd74a960c5ba2bacefe818681755e22808d15_b57dd74a960c5ba2bacefe818681755e22808d15/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 52.58% (19644/37357) |
   | Line Coverage     | 36.20% (183376/506586) |
   | Region Coverage   | 32.48% (142169/437764) |
   | Branch Coverage   | 33.45% (61705/184449) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](hll) add to_hll(bigint) scalar function [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-3990592237

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and after the optimization?
       


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](storage) add read_null_map support for COUNT_NULL push down aggregate [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-4059631439

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](storage) add read_null_map support for COUNT_NULL push down aggregate [doris]

Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-4043766473

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](storage) add read_null_map support for COUNT_NULL push down aggregate [doris]

Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-4038686994

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](storage) add read_null_map support for COUNT_NULL push down aggregate [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-4044361885

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 153157 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 1193ea77d2cdee00a96155833c71a084d1e05e07, data reload: false
   
   query5	4319	633	490	490
   query6	324	217	219	217
   query7	4208	478	270	270
   query8	344	256	242	242
   query9	8724	2755	2735	2735
   query10	527	386	332	332
   query11	7261	5888	5608	5608
   query12	198	132	127	127
   query13	1273	463	353	353
   query14	5701	3878	3603	3603
   query14_1	2842	2851	2794	2794
   query15	203	200	176	176
   query16	985	478	450	450
   query17	982	717	625	625
   query18	2441	447	350	350
   query19	209	207	181	181
   query20	131	132	135	132
   query21	225	144	124	124
   query22	5113	5349	5133	5133
   query23	16953	16032	15729	15729
   query23_1	15935	15701	15773	15701
   query24	8967	1738	1318	1318
   query24_1	1322	1319	1327	1319
   query25	580	518	457	457
   query26	2468	286	166	166
   query27	2834	566	297	297
   query28	4476	1847	1835	1835
   query29	812	550	486	486
   query30	310	259	212	212
   query31	1344	1276	1213	1213
   query32	80	75	73	73
   query33	509	321	272	272
   query34	916	914	574	574
   query35	632	665	607	607
   query36	1107	1131	1030	1030
   query37	132	96	80	80
   query38	2906	2897	2866	2866
   query39	870	897	847	847
   query39_1	846	826	827	826
   query40	227	148	135	135
   query41	62	60	57	57
   query42	307	295	302	295
   query43	239	247	212	212
   query44	
   query45	202	194	183	183
   query46	886	991	616	616
   query47	2109	2121	2051	2051
   query48	311	317	229	229
   query49	653	451	401	401
   query50	670	276	206	206
   query51	4096	4153	4059	4059
   query52	287	300	278	278
   query53	298	338	279	279
   query54	306	277	251	251
   query55	98	85	86	85
   query56	315	315	299	299
   query57	1336	1317	1303	1303
   query58	285	277	267	267
   query59	1342	1453	1274	1274
   query60	355	334	322	322
   query61	151	143	149	143
   query62	622	598	534	534
   query63	311	283	280	280
   query64	4981	1252	966	966
   query65	
   query66	1472	460	357	357
   query67	16417	16306	16233	16233
   query68	
   query69	393	307	274	274
   query70	1007	984	905	905
   query71	333	308	314	308
   query72	2805	2681	2463	2463
   query73	545	559	325	325
   query74	10032	9923	9728	9728
   query75	2901	2774	2478	2478
   query76	2292	1045	672	672
   query77	352	385	306	306
   query78	11238	11376	10660	10660
   query79	1125	796	580	580
   query80	1332	609	543	543
   query81	561	270	246	246
   query82	987	152	118	118
   query83	343	264	239	239
   query84	273	129	95	95
   query85	905	499	437	437
   query86	411	308	290	290
   query87	3131	3153	2985	2985
   query88	3537	2673	2639	2639
   query89	431	389	350	350
   query90	2038	175	188	175
   query91	169	188	133	133
   query92	79	73	73	73
   query93	999	808	510	510
   query94	650	317	291	291
   query95	595	404	317	317
   query96	638	514	232	232
   query97	2490	2522	2394	2394
   query98	228	215	235	215
   query99	1011	988	911	911
   Total cold run time: 237102 ms
   Total hot run time: 153157 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](storage) add read_null_map support for COUNT_NULL push down aggregate [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-4048438998

   # BE UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/dce35cb8c7f83be72faab2407ecf6f50d768989b_dce35cb8c7f83be72faab2407ecf6f50d768989b/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/dce35cb8c7f83be72faab2407ecf6f50d768989b_dce35cb8c7f83be72faab2407ecf6f50d768989b/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 52.63% (19699/37432) |
   | Line Coverage     | 36.18% (183901/508243) |
   | Region Coverage   | 32.31% (141945/439335) |
   | Branch Coverage   | 33.46% (61961/185183) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](storage) add read_null_map support for COUNT_NULL push down aggregate [doris]

Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-4046537719

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](hll) add to_hll(bigint) scalar function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-3997583750

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 183969 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 697bd4d9548658b747f0762d9c258b127e1ec128, data reload: false
   
   query5	5197	666	525	525
   query6	345	237	212	212
   query7	4231	469	270	270
   query8	350	253	240	240
   query9	8772	2801	2753	2753
   query10	576	379	333	333
   query11	16998	17435	17327	17327
   query12	226	146	132	132
   query13	1302	484	371	371
   query14	7584	3351	3120	3120
   query14_1	3001	2956	2858	2858
   query15	216	198	192	192
   query16	1026	514	492	492
   query17	1364	767	649	649
   query18	2748	430	358	358
   query19	219	213	183	183
   query20	139	127	123	123
   query21	213	136	118	118
   query22	4812	4830	4773	4773
   query23	17214	16813	16593	16593
   query23_1	16708	16752	16676	16676
   query24	6889	1621	1230	1230
   query24_1	1221	1236	1242	1236
   query25	566	495	476	476
   query26	1233	256	143	143
   query27	2777	467	285	285
   query28	4513	1894	1874	1874
   query29	796	564	462	462
   query30	311	246	214	214
   query31	860	746	632	632
   query32	82	72	74	72
   query33	537	331	288	288
   query34	916	924	553	553
   query35	633	684	588	588
   query36	1095	1145	984	984
   query37	148	91	83	83
   query38	2995	2976	2856	2856
   query39	890	874	843	843
   query39_1	831	840	834	834
   query40	226	147	134	134
   query41	78	74	72	72
   query42	111	108	112	108
   query43	397	381	359	359
   query44	
   query45	194	188	182	182
   query46	881	969	615	615
   query47	2108	2148	2040	2040
   query48	305	326	238	238
   query49	629	464	371	371
   query50	684	276	216	216
   query51	4053	4121	4059	4059
   query52	109	111	99	99
   query53	292	333	277	277
   query54	287	277	272	272
   query55	85	88	81	81
   query56	306	297	348	297
   query57	1374	1329	1250	1250
   query58	301	288	276	276
   query59	2597	2724	2508	2508
   query60	342	336	338	336
   query61	151	150	153	150
   query62	622	583	532	532
   query63	308	277	279	277
   query64	4809	1268	988	988
   query65	
   query66	1384	455	358	358
   query67	16426	16409	16366	16366
   query68	
   query69	395	299	282	282
   query70	961	959	922	922
   query71	349	310	304	304
   query72	2766	2746	2435	2435
   query73	546	548	319	319
   query74	10018	9949	9820	9820
   query75	2853	2758	2449	2449
   query76	2289	1045	667	667
   query77	361	382	314	314
   query78	11253	11367	10650	10650
   query79	2958	799	619	619
   query80	1812	629	545	545
   query81	562	280	251	251
   query82	1018	147	119	119
   query83	341	260	242	242
   query84	253	126	106	106
   query85	886	521	434	434
   query86	422	297	291	291
   query87	3118	3130	3019	3019
   query88	3553	2682	2681	2681
   query89	424	366	340	340
   query90	1994	181	174	174
   query91	166	158	139	139
   query92	79	75	69	69
   query93	1169	849	516	516
   query94	639	317	283	283
   query95	569	341	310	310
   query96	638	520	234	234
   query97	2432	2494	2465	2465
   query98	229	226	216	216
   query99	926	997	945	945
   Total cold run time: 257319 ms
   Total hot run time: 183969 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](hll) add to_hll(bigint) scalar function [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-3995327429

   # FE Regression Coverage Report
   Increment line coverage `  8.33% (1/12)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60996_cbea9552a1c1b59c015a9b22f7676dc7a3f2a5a8_merge_fe/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60996_cbea9552a1c1b59c015a9b22f7676dc7a3f2a5a8_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](hll) add to_hll(bigint) scalar function [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-3997798521

   # BE UT Coverage Report
   Increment line coverage `83.87% (26/31)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/697bd4d9548658b747f0762d9c258b127e1ec128_697bd4d9548658b747f0762d9c258b127e1ec128/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/697bd4d9548658b747f0762d9c258b127e1ec128_697bd4d9548658b747f0762d9c258b127e1ec128/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 52.58% (19656/37382) |
   | Line Coverage     | 36.20% (183537/506985) |
   | Region Coverage   | 32.51% (142419/438102) |
   | Branch Coverage   | 33.45% (61766/184655) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](hll) add to_hll(bigint) scalar function [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-3997794011

   # FE UT Coverage Report
   Increment line coverage `  8.33% (1/12)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60996_697bd4d9548658b747f0762d9c258b127e1ec128/fe_increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60996_697bd4d9548658b747f0762d9c258b127e1ec128/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](hll) add to_hll(bigint) scalar function [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-3998522239

   # FE Regression Coverage Report
   Increment line coverage `  8.33% (1/12)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60996_697bd4d9548658b747f0762d9c258b127e1ec128_merge_fe/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60996_697bd4d9548658b747f0762d9c258b127e1ec128_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](hll) add to_hll(bigint) scalar function [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-3994962774

   # FE UT Coverage Report
   Increment line coverage `  8.33% (1/12)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60996_cbea9552a1c1b59c015a9b22f7676dc7a3f2a5a8/fe_increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60996_cbea9552a1c1b59c015a9b22f7676dc7a3f2a5a8/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](hll) add to_hll(bigint) scalar function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-3994874951

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 183883 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit cbea9552a1c1b59c015a9b22f7676dc7a3f2a5a8, data reload: false
   
   query5	4320	630	520	520
   query6	328	214	195	195
   query7	4215	479	278	278
   query8	352	255	240	240
   query9	8733	2782	2751	2751
   query10	526	396	350	350
   query11	16904	17378	17120	17120
   query12	263	167	173	167
   query13	2069	486	361	361
   query14	6999	3462	3094	3094
   query14_1	2920	2903	2867	2867
   query15	207	207	185	185
   query16	1031	504	480	480
   query17	1271	746	639	639
   query18	2620	467	362	362
   query19	280	216	187	187
   query20	141	140	130	130
   query21	218	138	118	118
   query22	5570	5540	4992	4992
   query23	17325	16809	16646	16646
   query23_1	16667	16726	16714	16714
   query24	7365	1601	1234	1234
   query24_1	1229	1241	1246	1241
   query25	605	445	391	391
   query26	1230	272	156	156
   query27	2734	462	281	281
   query28	4443	1853	1890	1853
   query29	786	555	480	480
   query30	309	243	216	216
   query31	867	724	639	639
   query32	84	72	71	71
   query33	502	338	281	281
   query34	907	913	573	573
   query35	619	671	603	603
   query36	1058	1120	982	982
   query37	127	95	83	83
   query38	2957	2935	2867	2867
   query39	1019	856	872	856
   query39_1	835	835	832	832
   query40	231	152	136	136
   query41	64	61	58	58
   query42	106	102	105	102
   query43	386	380	347	347
   query44	
   query45	205	193	178	178
   query46	883	979	603	603
   query47	2111	2156	2029	2029
   query48	308	308	226	226
   query49	654	502	382	382
   query50	683	293	221	221
   query51	4071	4117	4166	4117
   query52	106	107	93	93
   query53	289	330	294	294
   query54	293	262	260	260
   query55	96	82	78	78
   query56	311	311	309	309
   query57	1371	1333	1249	1249
   query58	307	272	268	268
   query59	2548	2651	2559	2559
   query60	335	330	323	323
   query61	147	144	151	144
   query62	640	591	552	552
   query63	311	283	272	272
   query64	4849	1264	985	985
   query65	
   query66	1444	451	345	345
   query67	16203	16336	16250	16250
   query68	
   query69	404	301	282	282
   query70	999	983	969	969
   query71	342	311	305	305
   query72	2796	2605	2407	2407
   query73	543	545	325	325
   query74	9994	9922	9769	9769
   query75	2870	2765	2492	2492
   query76	2300	1040	674	674
   query77	364	382	310	310
   query78	11172	11352	10645	10645
   query79	2525	805	633	633
   query80	1792	640	582	582
   query81	566	274	249	249
   query82	1012	147	113	113
   query83	333	258	241	241
   query84	248	119	94	94
   query85	876	485	435	435
   query86	414	336	290	290
   query87	3183	3070	3060	3060
   query88	3546	2677	2684	2677
   query89	424	370	341	341
   query90	2000	174	169	169
   query91	166	150	143	143
   query92	82	79	72	72
   query93	1059	824	515	515
   query94	635	324	275	275
   query95	581	394	304	304
   query96	621	517	231	231
   query97	2506	2487	2395	2395
   query98	251	233	239	233
   query99	1007	1004	952	952
   Total cold run time: 256345 ms
   Total hot run time: 183883 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](storage) add read_null_map support for COUNT_NULL push down aggregate [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-4053729622

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 168312 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 4cd38b5c5bf6c82a58e54deb9a98a87a62eeb195, data reload: false
   
   query5	4341	660	533	533
   query6	338	241	214	214
   query7	4242	486	277	277
   query8	345	256	240	240
   query9	8688	2769	2764	2764
   query10	532	384	359	359
   query11	7029	5074	4874	4874
   query12	185	132	127	127
   query13	1261	467	349	349
   query14	5741	3719	3455	3455
   query14_1	2889	2817	2797	2797
   query15	225	198	175	175
   query16	968	479	459	459
   query17	890	728	616	616
   query18	2444	461	355	355
   query19	224	209	182	182
   query20	131	130	126	126
   query21	215	132	115	115
   query22	13244	14083	14894	14083
   query23	16158	15984	15649	15649
   query23_1	15681	15534	15869	15534
   query24	7147	1605	1240	1240
   query24_1	1228	1235	1235	1235
   query25	565	488	439	439
   query26	1249	273	155	155
   query27	2771	487	300	300
   query28	4460	1859	1852	1852
   query29	766	546	467	467
   query30	285	225	187	187
   query31	1024	940	868	868
   query32	83	66	73	66
   query33	512	334	283	283
   query34	889	867	530	530
   query35	647	682	610	610
   query36	1077	1112	992	992
   query37	132	95	80	80
   query38	2923	2910	2856	2856
   query39	848	839	811	811
   query39_1	795	814	787	787
   query40	229	150	132	132
   query41	62	60	60	60
   query42	259	255	257	255
   query43	240	243	214	214
   query44	
   query45	198	188	187	187
   query46	856	983	620	620
   query47	2105	2655	2054	2054
   query48	314	318	229	229
   query49	668	462	377	377
   query50	690	276	210	210
   query51	4065	4011	4000	4000
   query52	266	271	271	271
   query53	294	331	279	279
   query54	297	266	256	256
   query55	94	90	84	84
   query56	318	311	312	311
   query57	1916	1860	1645	1645
   query58	287	276	272	272
   query59	2763	2938	2720	2720
   query60	340	341	323	323
   query61	148	136	139	136
   query62	620	587	541	541
   query63	314	275	275	275
   query64	4828	1261	984	984
   query65	
   query66	1457	460	352	352
   query67	24217	24231	24275	24231
   query68	
   query69	402	308	294	294
   query70	983	985	954	954
   query71	344	316	298	298
   query72	2892	2632	2356	2356
   query73	552	536	330	330
   query74	9580	9583	9359	9359
   query75	2856	2767	2488	2488
   query76	2279	1033	691	691
   query77	359	370	303	303
   query78	10879	11080	10430	10430
   query79	2909	772	576	576
   query80	1760	647	541	541
   query81	582	261	224	224
   query82	1019	147	124	124
   query83	341	278	241	241
   query84	301	118	101	101
   query85	895	478	433	433
   query86	483	307	325	307
   query87	3181	3114	3036	3036
   query88	3537	2688	2665	2665
   query89	418	367	354	354
   query90	2058	177	175	175
   query91	167	167	133	133
   query92	88	76	74	74
   query93	1487	825	489	489
   query94	633	297	270	270
   query95	588	404	323	323
   query96	628	508	234	234
   query97	2437	2481	2450	2450
   query98	247	236	220	220
   query99	996	989	937	937
   Total cold run time: 251153 ms
   Total hot run time: 168312 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](storage) add read_null_map support for COUNT_NULL push down aggregate [doris]

Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-4053174953

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](storage) add read_null_map support for COUNT_NULL push down aggregate [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-4053681834

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 27278 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 4cd38b5c5bf6c82a58e54deb9a98a87a62eeb195, data reload: false
   
   ------ Round 1 ----------------------------------
   orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	17665	4539	4433	4433
   q2	q3	10758	788	523	523
   q4	4732	357	251	251
   q5	8129	1214	1044	1044
   q6	227	179	150	150
   q7	836	838	678	678
   q8	10533	1479	1389	1389
   q9	6852	4849	4837	4837
   q10	6391	1946	1657	1657
   q11	456	258	256	256
   q12	788	577	475	475
   q13	18077	2928	2219	2219
   q14	233	228	210	210
   q15	q16	742	760	679	679
   q17	723	820	468	468
   q18	5915	5394	5246	5246
   q19	1127	985	619	619
   q20	543	481	392	392
   q21	4790	2030	1490	1490
   q22	421	343	262	262
   Total cold run time: 99938 ms
   Total hot run time: 27278 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	4658	4630	4700	4630
   q2	q3	3975	4371	3842	3842
   q4	902	1197	759	759
   q5	4066	4409	4324	4324
   q6	185	178	142	142
   q7	1817	1689	1574	1574
   q8	2587	2748	2558	2558
   q9	7616	7366	7372	7366
   q10	3721	4019	3572	3572
   q11	551	453	430	430
   q12	507	642	461	461
   q13	2841	3230	2392	2392
   q14	296	301	271	271
   q15	q16	721	761	719	719
   q17	1182	1318	1377	1318
   q18	7218	6925	6847	6847
   q19	941	896	883	883
   q20	2078	2174	1983	1983
   q21	3953	3503	3381	3381
   q22	495	434	383	383
   Total cold run time: 50310 ms
   Total hot run time: 47835 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](storage) add read_null_map support for COUNT_NULL push down aggregate [doris]

Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-4043879270

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](storage) add read_null_map support for COUNT_NULL push down aggregate [doris]

Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-4051992712

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](storage) add read_null_map support for COUNT_NULL push down aggregate [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-4047118829

   # FE UT Coverage Report
   Increment line coverage `  70.00% (28/40)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60996_dce35cb8c7f83be72faab2407ecf6f50d768989b/fe_increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60996_dce35cb8c7f83be72faab2407ecf6f50d768989b/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](storage) add read_null_map support for COUNT_NULL push down aggregate [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-4047676643

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 152871 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit dce35cb8c7f83be72faab2407ecf6f50d768989b, data reload: false
   
   query5	4328	647	511	511
   query6	328	217	207	207
   query7	4219	460	259	259
   query8	345	235	223	223
   query9	8693	2736	2688	2688
   query10	518	401	328	328
   query11	7328	5802	5558	5558
   query12	187	122	126	122
   query13	1263	450	335	335
   query14	5729	3844	3516	3516
   query14_1	2780	2808	2778	2778
   query15	204	191	174	174
   query16	961	486	367	367
   query17	1104	688	581	581
   query18	2426	463	333	333
   query19	213	204	176	176
   query20	136	132	125	125
   query21	223	144	118	118
   query22	4739	4836	4747	4747
   query23	15804	15529	15280	15280
   query23_1	15520	16301	15830	15830
   query24	8451	1718	1288	1288
   query24_1	1305	1295	1358	1295
   query25	571	532	467	467
   query26	1332	285	177	177
   query27	3328	509	328	328
   query28	4964	1956	1944	1944
   query29	893	666	492	492
   query30	339	254	216	216
   query31	1382	1385	1297	1297
   query32	82	82	82	82
   query33	529	347	286	286
   query34	945	948	607	607
   query35	663	707	626	626
   query36	1144	1108	988	988
   query37	135	96	90	90
   query38	2964	2930	2864	2864
   query39	878	860	857	857
   query39_1	843	828	810	810
   query40	228	154	137	137
   query41	60	58	56	56
   query42	305	295	294	294
   query43	238	270	221	221
   query44	
   query45	206	187	186	186
   query46	875	984	603	603
   query47	2117	2149	2062	2062
   query48	314	310	229	229
   query49	635	461	377	377
   query50	679	282	218	218
   query51	4101	4077	4094	4077
   query52	285	289	278	278
   query53	288	330	283	283
   query54	295	277	264	264
   query55	95	88	82	82
   query56	307	326	339	326
   query57	1367	1339	1298	1298
   query58	286	291	275	275
   query59	1339	1441	1318	1318
   query60	341	325	308	308
   query61	151	149	154	149
   query62	637	595	540	540
   query63	306	282	281	281
   query64	5089	1292	1012	1012
   query65	
   query66	1464	453	349	349
   query67	16439	16495	16339	16339
   query68	
   query69	375	308	280	280
   query70	980	941	966	941
   query71	354	307	301	301
   query72	2979	2892	2640	2640
   query73	541	551	324	324
   query74	9981	10002	9806	9806
   query75	2879	2784	2497	2497
   query76	2272	1046	664	664
   query77	368	400	314	314
   query78	11224	11526	10712	10712
   query79	1144	792	584	584
   query80	1603	651	572	572
   query81	568	290	250	250
   query82	1271	152	117	117
   query83	355	269	249	249
   query84	256	123	102	102
   query85	1365	495	465	465
   query86	430	307	300	300
   query87	3131	3108	2999	2999
   query88	3534	2640	2620	2620
   query89	422	366	362	362
   query90	1892	171	170	170
   query91	174	162	140	140
   query92	82	76	75	75
   query93	943	838	493	493
   query94	660	331	290	290
   query95	596	413	319	319
   query96	636	517	229	229
   query97	2452	2458	2414	2414
   query98	247	212	217	212
   query99	1000	994	908	908
   Total cold run time: 236110 ms
   Total hot run time: 152871 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](hll) add to_hll(bigint) scalar function [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-3996624047

   # FE Regression Coverage Report
   Increment line coverage `  8.33% (1/12)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60996_cbea9552a1c1b59c015a9b22f7676dc7a3f2a5a8_merge_fe/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60996_cbea9552a1c1b59c015a9b22f7676dc7a3f2a5a8_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](hll) add to_hll(bigint) scalar function [doris]

Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-3994738395

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](hll) add to_hll(bigint) scalar function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-3994842394

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 28759 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit cbea9552a1c1b59c015a9b22f7676dc7a3f2a5a8, data reload: false
   
   ------ Round 1 ----------------------------------
   ============================================
   q1	17693	4451	4336	4336
   q2	q3	10656	788	519	519
   q4	4681	350	253	253
   q5	7558	1189	1031	1031
   q6	172	174	147	147
   q7	794	831	679	679
   q8	9291	1456	1367	1367
   q9	4895	4796	4679	4679
   q10	6826	1867	1637	1637
   q11	466	263	236	236
   q12	730	573	465	465
   q13	17764	4207	3410	3410
   q14	227	232	209	209
   q15	954	813	794	794
   q16	766	726	659	659
   q17	735	861	403	403
   q18	5910	5469	5195	5195
   q19	1109	961	621	621
   q20	502	492	399	399
   q21	4715	1969	1459	1459
   q22	378	324	261	261
   Total cold run time: 96822 ms
   Total hot run time: 28759 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   ============================================
   q1	4633	4610	4624	4610
   q2	q3	1791	2165	1795	1795
   q4	865	1193	772	772
   q5	4100	4398	4302	4302
   q6	185	173	138	138
   q7	1799	1687	1586	1586
   q8	2509	2723	2519	2519
   q9	7473	7421	7349	7349
   q10	2721	2816	2403	2403
   q11	503	422	413	413
   q12	510	615	478	478
   q13	4030	4409	3602	3602
   q14	282	300	295	295
   q15	880	828	815	815
   q16	725	752	712	712
   q17	1217	1567	1324	1324
   q18	7171	6851	6812	6812
   q19	866	849	889	849
   q20	2072	2204	2074	2074
   q21	4106	3691	3402	3402
   q22	468	432	380	380
   Total cold run time: 48906 ms
   Total hot run time: 46630 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](hll) add to_hll(bigint) scalar function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-3997256134

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 28842 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 644a371416e33ab20451719fcd53eb467923cef9, data reload: false
   
   ------ Round 1 ----------------------------------
   ============================================
   q1	17647	4463	4285	4285
   q2	q3	10644	765	516	516
   q4	4671	351	256	256
   q5	7555	1208	1028	1028
   q6	175	176	144	144
   q7	778	849	656	656
   q8	9708	1465	1328	1328
   q9	5275	4756	4721	4721
   q10	6838	1871	1638	1638
   q11	474	253	227	227
   q12	732	557	461	461
   q13	17775	4200	3433	3433
   q14	227	222	208	208
   q15	938	794	788	788
   q16	738	726	667	667
   q17	731	867	388	388
   q18	5890	5406	5311	5311
   q19	1283	962	599	599
   q20	517	489	374	374
   q21	4810	1964	1550	1550
   q22	336	294	264	264
   Total cold run time: 97742 ms
   Total hot run time: 28842 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   ============================================
   q1	4624	4607	4714	4607
   q2	q3	1800	2191	1790	1790
   q4	885	1176	765	765
   q5	4043	4350	4397	4350
   q6	181	176	136	136
   q7	1754	1678	1524	1524
   q8	2446	2734	2544	2544
   q9	7548	7295	7509	7295
   q10	2625	2891	2452	2452
   q11	500	422	406	406
   q12	490	595	455	455
   q13	4135	4422	3613	3613
   q14	285	296	273	273
   q15	867	804	805	804
   q16	772	757	723	723
   q17	1197	1543	1285	1285
   q18	7094	6892	6675	6675
   q19	883	834	895	834
   q20	2088	2191	2038	2038
   q21	4073	3450	3436	3436
   q22	454	417	370	370
   Total cold run time: 48744 ms
   Total hot run time: 46375 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](hll) add to_hll(bigint) scalar function [doris]

Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-3997396415

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](hll) add to_hll(bigint) scalar function [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60996:
URL: https://github.com/apache/doris/pull/60996#issuecomment-3997514972

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 28948 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 697bd4d9548658b747f0762d9c258b127e1ec128, data reload: false
   
   ------ Round 1 ----------------------------------
   ============================================
   q1	17631	4455	4331	4331
   q2	q3	10653	779	521	521
   q4	4682	361	254	254
   q5	7554	1228	1009	1009
   q6	176	172	153	153
   q7	759	843	656	656
   q8	9291	1440	1317	1317
   q9	4754	4714	4736	4714
   q10	6761	1860	1643	1643
   q11	434	261	234	234
   q12	706	568	484	484
   q13	17775	4220	3391	3391
   q14	235	232	213	213
   q15	912	791	790	790
   q16	726	728	692	692
   q17	723	874	410	410
   q18	5992	5398	5287	5287
   q19	1255	969	628	628
   q20	493	490	396	396
   q21	5227	1982	1553	1553
   q22	384	311	272	272
   Total cold run time: 97123 ms
   Total hot run time: 28948 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   ============================================
   q1	4629	4584	4463	4463
   q2	q3	1779	2193	1783	1783
   q4	861	1181	789	789
   q5	4038	4388	4282	4282
   q6	207	169	138	138
   q7	1795	1653	1496	1496
   q8	2493	2880	2530	2530
   q9	7613	7323	7353	7323
   q10	2617	2774	2380	2380
   q11	509	433	427	427
   q12	516	607	444	444
   q13	4059	4389	3647	3647
   q14	290	315	297	297
   q15	913	797	816	797
   q16	749	804	732	732
   q17	1173	1514	1331	1331
   q18	7080	6776	6584	6584
   q19	937	992	1026	992
   q20	2080	2174	1996	1996
   q21	3944	3504	3412	3412
   q22	474	441	373	373
   Total cold run time: 48756 ms
   Total hot run time: 46216 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org