[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #600: DISPATCH-1463 - Add detection for stuck deliveries

[GitBox <gi...@apache.org>]

kgiusti commented on a change in pull request #600: DISPATCH-1463 - Add detection for stuck deliveries
URL: https://github.com/apache/qpid-dispatch/pull/600#discussion_r339235290
 
 

 ##########
 File path: src/router_core/router_core_thread.c
 ##########
 @@ -123,6 +123,33 @@ void qdr_modules_finalize(qdr_core_t *core)
 }
 
 
+/*
+ * router_core_process_background_action_LH
+ *
+ * Process up to one available background action.
+ * Return true iff an action was processed.
+ */
+static bool router_core_process_background_action_LH(qdr_core_t *core)
+{
+    qdr_action_t *action = DEQ_HEAD(core->action_list_background);
+
+    if (!!action) {
+        DEQ_REMOVE_HEAD(core->action_list_background);
+        if (action->label)
 
 Review comment:
   Can the call to qd_log be moved to the unlocked section?  qd_log() takes locks and IIRC does sync I/O.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org