[GitHub] [airflow] dimberman commented on a change in pull request #4551: [AIRFLOW-2955] Fix kubernetes pod operator to set requests and limits on task pods

[GitBox <gi...@apache.org>]

dimberman commented on a change in pull request #4551: [AIRFLOW-2955] Fix kubernetes pod operator to set requests and limits on task pods
URL: https://github.com/apache/airflow/pull/4551#discussion_r279853452
 
 

 ##########
 File path: airflow/contrib/operators/kubernetes_pod_operator.py
 ##########
 @@ -140,6 +142,15 @@ def execute(self, context):
         except AirflowException as ex:
             raise AirflowException('Pod Launching failed: {error}'.format(error=ex))
 
+    def _set_resources(self, resources):
+        inputResource = Resources()
+        if resources is not None:
 
 Review comment:
   you can just write "if resources:" here

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services