You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by lw-lin <gi...@git.apache.org> on 2016/09/27 14:17:07 UTC
[GitHub] flink pull request #2556: [FLINK-4573] Fix potential resource leak due to un...
GitHub user lw-lin opened a pull request:
https://github.com/apache/flink/pull/2556
[FLINK-4573] Fix potential resource leak due to unclosed RandomAccess\u2026
\u2026File in TaskManagerLogHandler
--
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lw-lin/flink raf-close
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2556.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2556
----
commit 8ec0dfae40c7b06e01e57260d16d6256f885f4e6
Author: Liwei Lin <lw...@gmail.com>
Date: 2016-09-27T12:49:52Z
[FLINK-4573] Fix potential resource leak due to unclosed RandomAccessFile in TaskManagerLogHandler
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2556: [FLINK-4573] Fix potential resource leak due to un...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2556
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2556: [FLINK-4573] Fix potential resource leak due to un...
Posted by lw-lin <gi...@git.apache.org>.
Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/flink/pull/2556#discussion_r80947439
--- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/TaskManagerLogHandler.java ---
@@ -210,7 +210,17 @@ public void onSuccess(Object filePathOption) throws Throwable {
LOG.error("Displaying TaskManager log failed.", e);
return;
}
- long fileLength = raf.length();
+ long fileLength;
+ try {
+ fileLength = raf.length();
+ } catch (IOException ioe) {
+ display(ctx, request, "Displaying TaskManager log failed.");
+ LOG.error("Displaying TaskManager log failed.", ioe);
+ if (raf != null) {
--- End diff --
@zentol comments addressed; thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2556: [FLINK-4573] Fix potential resource leak due to un...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2556#discussion_r80885477
--- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/TaskManagerLogHandler.java ---
@@ -210,7 +210,17 @@ public void onSuccess(Object filePathOption) throws Throwable {
LOG.error("Displaying TaskManager log failed.", e);
return;
}
- long fileLength = raf.length();
+ long fileLength;
+ try {
+ fileLength = raf.length();
+ } catch (IOException ioe) {
+ display(ctx, request, "Displaying TaskManager log failed.");
+ LOG.error("Displaying TaskManager log failed.", ioe);
+ if (raf != null) {
--- End diff --
this should never be false, as we would otherwise get an NPE and would never enter this block.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2556: [FLINK-4573] Fix potential resource leak due to un...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2556#discussion_r80885273
--- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/TaskManagerLogHandler.java ---
@@ -210,7 +210,17 @@ public void onSuccess(Object filePathOption) throws Throwable {
LOG.error("Displaying TaskManager log failed.", e);
return;
}
- long fileLength = raf.length();
+ long fileLength;
+ try {
+ fileLength = raf.length();
+ } catch (IOException ioe) {
+ display(ctx, request, "Displaying TaskManager log failed.");
+ LOG.error("Displaying TaskManager log failed.", ioe);
+ if (raf != null) {
+ raf.close();
+ }
+ return;
--- End diff --
let's just re-throw the exception to retain current behavior.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2556: [FLINK-4573] Fix potential resource leak due to unclosed ...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2556
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2556: [FLINK-4573] Fix potential resource leak due to unclosed ...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2556
I think this is good to merge...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---