[GitHub] [airflow] potiuk commented on a change in pull request #10329: Breeze: More fancy environment checking

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #10329:
URL: https://github.com/apache/airflow/pull/10329#discussion_r471025217



##########
File path: scripts/ci/in_container/check_environment.sh
##########
@@ -131,34 +119,21 @@ function resetdb_if_requested() {
     return $?
 }
 
-if [[ -n ${BACKEND:=} ]]; then
-    echo "==============================================================================================="
-    echo "             Checking backend: ${BACKEND}"
-    echo "==============================================================================================="
 
-    set +e
+echo "==============================================================================================="
+echo "             Checking integrations and backends"
+echo "==============================================================================================="
+if [[ -n ${BACKEND:=} ]]; then

Review comment:
       The problem is that you can get some extra output in this check. Bash function might either pass output by printing result in the output or returning exit code. I. This case I chose exit code in other to avoid ambiguity of printed stdout by the check command. It is of course possible to avoid it but I figured exit code is better, simpler and avoids unexpected behaviour. 
   
   But feel free to change it if you take care about the ambiguity .




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org