You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "lostluck (via GitHub)" <gi...@apache.org> on 2023/02/17 20:01:47 UTC

[GitHub] [beam] lostluck opened a new pull request, #25542: [#25541] Stop use of self hosted runners for some workflows.

lostluck opened a new pull request, #25542:
URL: https://github.com/apache/beam/pull/25542

   Stop use of self hosted runners for some workflows. This is a stopgap to get the repo automation healthy again.
   
   See #25541 for context.
   
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck commented on pull request #25542: [#25541] Stop use of self hosted runners for some workflows.

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #25542:
URL: https://github.com/apache/beam/pull/25542#issuecomment-1435174018

   R: @damccorm 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on a diff in pull request #25542: [#25541] Stop use of self hosted runners for some workflows.

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #25542:
URL: https://github.com/apache/beam/pull/25542#discussion_r1110311183


##########
.github/workflows/git_tag_released_version.yml:
##########
@@ -32,7 +32,7 @@ on:
 
 jobs:
   generate_tags:
-    runs-on: [self-hosted, ubuntu-20.04]
+    runs-on: ubuntu-latest

Review Comment:
   No, that one is different - this is only run manually and can do one of the release steps (tagging a released version in GitHub) - https://github.com/apache/beam/blob/fac67922cad99979aa6bba5339616fd253e932a7/.github/workflows/git_tag_released_version.yml#L24 (workflow_dispatch means manual trigger only). You're thinking of https://github.com/apache/beam/blob/20c8d3a2ba11f3965022e2ba5e12a241a4ec3442/.github/workflows/assign_milestone.yml#L20



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on a diff in pull request #25542: [#25541] Stop use of self hosted runners for some workflows.

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #25542:
URL: https://github.com/apache/beam/pull/25542#discussion_r1110305430


##########
.github/workflows/git_tag_released_version.yml:
##########
@@ -32,7 +32,7 @@ on:
 
 jobs:
   generate_tags:
-    runs-on: [self-hosted, ubuntu-20.04]
+    runs-on: ubuntu-latest

Review Comment:
   Its not totally clear if these release tasks will work on hosted runners (or if they'll work at all), but its probably fine to include them. I may try these out during my release



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck commented on pull request #25542: [#25541] Stop use of self hosted runners for some workflows.

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #25542:
URL: https://github.com/apache/beam/pull/25542#issuecomment-1435185788

   And now we wait.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck commented on a diff in pull request #25542: [#25541] Stop use of self hosted runners for some workflows.

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on code in PR #25542:
URL: https://github.com/apache/beam/pull/25542#discussion_r1110307058


##########
.github/workflows/git_tag_released_version.yml:
##########
@@ -32,7 +32,7 @@ on:
 
 jobs:
   generate_tags:
-    runs-on: [self-hosted, ubuntu-20.04]
+    runs-on: ubuntu-latest

Review Comment:
   I thought this was the bot that tagged finished issues/PRs with the release that includes them, and since a release just went out...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on pull request #25542: [#25541] Stop use of self hosted runners for some workflows.

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #25542:
URL: https://github.com/apache/beam/pull/25542#issuecomment-1435184893

   GitHub won't pick up workflow changes until they're merged, so LabelPrs will still not work on this PR - just calling that out so that you don't block on it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on a diff in pull request #25542: [#25541] Stop use of self hosted runners for some workflows.

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #25542:
URL: https://github.com/apache/beam/pull/25542#discussion_r1110311589


##########
.github/workflows/git_tag_released_version.yml:
##########
@@ -32,7 +32,7 @@ on:
 
 jobs:
   generate_tags:
-    runs-on: [self-hosted, ubuntu-20.04]
+    runs-on: ubuntu-latest

Review Comment:
   Fortunately, that should be functioning fine since its on a hosted runner



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck merged pull request #25542: [#25541] Stop use of self hosted runners for some workflows.

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck merged PR #25542:
URL: https://github.com/apache/beam/pull/25542


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org