[GitHub] [activemq-artemis] gtully commented on pull request #4207: ARTEMIS-3978 - allow federation upstream configuration via properties

[GitBox <gi...@apache.org>]

gtully commented on PR #4207:
URL: https://github.com/apache/activemq-artemis/pull/4207#issuecomment-1242077467

   it is related to the logic around typed collections. in this example, all of the policies go in the policyMap, but to be able to create or reference a queuePolicy I expose the collection via getQueuePolicies that has a typed addQueuePolicie(FederationQueuePolicy...)
   Then:
   prop.queuePolicies.x will create a FederationQueuePolicy.name=x and add it to the map.
   
   B/c plural or policy does not just drop the s, it is a little ugly, but largely hidden, only BeanUtil makes use of it.
   
   At some stage it may make sense to throw out beanutil but it is not trivial and it works to date. We could also get the type information from somewhere else, but I don't see the point as that convention of stripping the s from the collection name is mostly sensible. Policy is the exception!
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org